From: Taniya Das <taniya.das@oss.qualcomm.com>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jagadeesh Kona <quic_jkona@quicinc.com>
Cc: Ajit Pandey <ajit.pandey@oss.qualcomm.com>,
Imran Shaik <imran.shaik@oss.qualcomm.com>,
Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] dt-bindings: clock: qcom: Add camera clock controller for SM8750 SoC
Date: Wed, 17 Dec 2025 15:28:54 +0530 [thread overview]
Message-ID: <ca336f38-f831-4cb7-8f2d-66a4302e0efb@oss.qualcomm.com> (raw)
In-Reply-To: <7e22e126-cb08-4bc2-bad6-a895a4e35a8d@linaro.org>
On 12/3/2025 7:39 PM, Vladimir Zapolskiy wrote:
> Hi Taniya.
>
> On 12/2/25 12:26, Taniya Das wrote:
>> Add device tree bindings for the camera clock controller on
>> Qualcomm SM8750 platform. The camera clock controller is split between
>> camcc and cambist. The cambist controls the mclks of the camera clock
>> controller.
>>
>> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
>> ---
>> .../bindings/clock/qcom,sm8450-camcc.yaml | 5 +
>> .../dt-bindings/clock/qcom,sm8750-cambistmclkcc.h | 30 ++++
>> include/dt-bindings/clock/qcom,sm8750-camcc.h | 151 +++++++++++
>> ++++++++++
>> 3 files changed, 186 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-
>> camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-
>> camcc.yaml
>> index
>> c1e06f39431e68a3cd2f6c2dba84be2a3c143bb1..8e3baba5270b384eb03a68b4e47785e6c91ec6f7 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
>> @@ -9,6 +9,7 @@ title: Qualcomm Camera Clock & Reset Controller on SM8450
>> maintainers:
>> - Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
>> - Jagadeesh Kona <quic_jkona@quicinc.com>
>> + - Taniya Das <taniya.das@oss.qualcomm.com>
>> description: |
>> Qualcomm camera clock control module provides the clocks, resets
>> and power
>> @@ -18,6 +19,8 @@ description: |
>> include/dt-bindings/clock/qcom,sm8450-camcc.h
>> include/dt-bindings/clock/qcom,sm8550-camcc.h
>> include/dt-bindings/clock/qcom,sm8650-camcc.h
>> + include/dt-bindings/clock/qcom,sm8750-cambistmclkcc.h
>> + include/dt-bindings/clock/qcom,sm8750-camcc.h
>> properties:
>> compatible:
>> @@ -26,6 +29,8 @@ properties:
>> - qcom,sm8475-camcc
>> - qcom,sm8550-camcc
>> - qcom,sm8650-camcc
>> + - qcom,sm8750-cambistmclkcc
>
> Due to the very distinct nature of this new clock controller, I suppose
> it does not inherit most of the properties of other CAMCC clocks, and
> therefore it should be described in a separate dt binding documentation
> file.
>
Vladimir, from a clock controller design PoV, CAMBISTMCLK CC does
support resets/_ares at hardware level and thus documenting the same.
But currently SW is not using them, thus I have not modelled the resets
in the macro definition.
> Looking at the list of macro definitions from a new header file, a
> noticeable
> remark is that this new clock controller is neither a reset controller nor
> a power domain controller.
>
>> + - qcom,sm8750-camcc
>> clocks:
>> items:
>> diff --git a/include/dt-bindings/clock/qcom,sm8750-cambistmclkcc.h b/
>> include/dt-bindings/clock/qcom,sm8750-cambistmclkcc.h
>> new file mode 100644
>> index
>> 0000000000000000000000000000000000000000..51615bee307fd9e7f81f7e5c1662535093dd8b55
>> --- /dev/null
>> +++ b/include/dt-bindings/clock/qcom,sm8750-cambistmclkcc.h
>> @@ -0,0 +1,30 @@
>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>> +/*
>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
>> + */
>> +
>> +#ifndef _DT_BINDINGS_CLK_QCOM_CAM_BIST_MCLK_CC_SM8750_H
>> +#define _DT_BINDINGS_CLK_QCOM_CAM_BIST_MCLK_CC_SM8750_H
>> +
>> +/* CAM_BIST_MCLK_CC clocks */
>> +#define CAM_BIST_MCLK_CC_MCLK0_CLK 0
>> +#define CAM_BIST_MCLK_CC_MCLK0_CLK_SRC 1
>> +#define CAM_BIST_MCLK_CC_MCLK1_CLK 2
>> +#define CAM_BIST_MCLK_CC_MCLK1_CLK_SRC 3
>> +#define CAM_BIST_MCLK_CC_MCLK2_CLK 4
>> +#define CAM_BIST_MCLK_CC_MCLK2_CLK_SRC 5
>> +#define CAM_BIST_MCLK_CC_MCLK3_CLK 6
>> +#define CAM_BIST_MCLK_CC_MCLK3_CLK_SRC 7
>> +#define CAM_BIST_MCLK_CC_MCLK4_CLK 8
>> +#define CAM_BIST_MCLK_CC_MCLK4_CLK_SRC 9
>> +#define CAM_BIST_MCLK_CC_MCLK5_CLK 10
>> +#define CAM_BIST_MCLK_CC_MCLK5_CLK_SRC 11
>> +#define CAM_BIST_MCLK_CC_MCLK6_CLK 12
>> +#define CAM_BIST_MCLK_CC_MCLK6_CLK_SRC 13
>> +#define CAM_BIST_MCLK_CC_MCLK7_CLK 14
>> +#define CAM_BIST_MCLK_CC_MCLK7_CLK_SRC 15
>> +#define CAM_BIST_MCLK_CC_PLL0 16
>> +#define CAM_BIST_MCLK_CC_SLEEP_CLK 17
>> +#define CAM_BIST_MCLK_CC_SLEEP_CLK_SRC 18
>> +
>> +#endif
>> diff --git a/include/dt-bindings/clock/qcom,sm8750-camcc.h b/include/
>> dt-bindings/clock/qcom,sm8750-camcc.h
>> new file mode 100644
>> index
>> 0000000000000000000000000000000000000000..dae788247afe896ef812bef716897c6cf80df2bb
>> --- /dev/null
>> +++ b/include/dt-bindings/clock/qcom,sm8750-camcc.h
>> @@ -0,0 +1,151 @@
>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>> +/*
>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
>> + */
>> +
>> +#ifndef _DT_BINDINGS_CLK_QCOM_CAM_CC_SM8750_H
>> +#define _DT_BINDINGS_CLK_QCOM_CAM_CC_SM8750_H
>> +
>> +/* CAM_CC clocks */
>> +#define CAM_CC_CAM_TOP_AHB_CLK 0
>> +#define CAM_CC_CAM_TOP_FAST_AHB_CLK 1
>> +#define CAM_CC_CAMNOC_DCD_XO_CLK 2
>> +#define CAM_CC_CAMNOC_NRT_AXI_CLK 3
>> +#define CAM_CC_CAMNOC_NRT_CRE_CLK 4
>> +#define CAM_CC_CAMNOC_NRT_IPE_NPS_CLK 5
>> +#define CAM_CC_CAMNOC_NRT_OFE_ANCHOR_CLK 6
>> +#define CAM_CC_CAMNOC_NRT_OFE_HDR_CLK 7
>> +#define CAM_CC_CAMNOC_NRT_OFE_MAIN_CLK 8
>> +#define CAM_CC_CAMNOC_RT_AXI_CLK 9
>> +#define CAM_CC_CAMNOC_RT_AXI_CLK_SRC 10
>> +#define CAM_CC_CAMNOC_RT_IFE_LITE_CLK 11
>> +#define CAM_CC_CAMNOC_RT_TFE_0_BAYER_CLK 12
>> +#define CAM_CC_CAMNOC_RT_TFE_0_MAIN_CLK 13
>> +#define CAM_CC_CAMNOC_RT_TFE_1_BAYER_CLK 14
>> +#define CAM_CC_CAMNOC_RT_TFE_1_MAIN_CLK 15
>> +#define CAM_CC_CAMNOC_RT_TFE_2_BAYER_CLK 16
>> +#define CAM_CC_CAMNOC_RT_TFE_2_MAIN_CLK 17
>> +#define CAM_CC_CAMNOC_XO_CLK 18
>> +#define CAM_CC_CCI_0_CLK 19
>> +#define CAM_CC_CCI_0_CLK_SRC 20
>> +#define CAM_CC_CCI_1_CLK 21
>> +#define CAM_CC_CCI_1_CLK_SRC 22
>> +#define CAM_CC_CCI_2_CLK 23
>> +#define CAM_CC_CCI_2_CLK_SRC 24
>> +#define CAM_CC_CORE_AHB_CLK 25
>> +#define CAM_CC_CPHY_RX_CLK_SRC 26
>> +#define CAM_CC_CRE_AHB_CLK 27
>> +#define CAM_CC_CRE_CLK 28
>> +#define CAM_CC_CRE_CLK_SRC 29
>> +#define CAM_CC_CSI0PHYTIMER_CLK 30
>> +#define CAM_CC_CSI0PHYTIMER_CLK_SRC 31
>> +#define CAM_CC_CSI1PHYTIMER_CLK 32
>> +#define CAM_CC_CSI1PHYTIMER_CLK_SRC 33
>> +#define CAM_CC_CSI2PHYTIMER_CLK 34
>> +#define CAM_CC_CSI2PHYTIMER_CLK_SRC 35
>> +#define CAM_CC_CSI3PHYTIMER_CLK 36
>> +#define CAM_CC_CSI3PHYTIMER_CLK_SRC 37
>> +#define CAM_CC_CSI4PHYTIMER_CLK 38
>> +#define CAM_CC_CSI4PHYTIMER_CLK_SRC 39
>> +#define CAM_CC_CSI5PHYTIMER_CLK 40
>> +#define CAM_CC_CSI5PHYTIMER_CLK_SRC 41
>> +#define CAM_CC_CSID_CLK 42
>> +#define CAM_CC_CSID_CLK_SRC 43
>> +#define CAM_CC_CSID_CSIPHY_RX_CLK 44
>> +#define CAM_CC_CSIPHY0_CLK 45
>> +#define CAM_CC_CSIPHY1_CLK 46
>> +#define CAM_CC_CSIPHY2_CLK 47
>> +#define CAM_CC_CSIPHY3_CLK 48
>> +#define CAM_CC_CSIPHY4_CLK 49
>> +#define CAM_CC_CSIPHY5_CLK 50
>> +#define CAM_CC_DRV_AHB_CLK 51
>> +#define CAM_CC_DRV_XO_CLK 52
>> +#define CAM_CC_FAST_AHB_CLK_SRC 53
>> +#define CAM_CC_GDSC_CLK 54
>> +#define CAM_CC_ICP_0_AHB_CLK 55
>> +#define CAM_CC_ICP_0_CLK 56
>> +#define CAM_CC_ICP_0_CLK_SRC 57
>> +#define CAM_CC_ICP_1_AHB_CLK 58
>> +#define CAM_CC_ICP_1_CLK 59
>> +#define CAM_CC_ICP_1_CLK_SRC 60
>> +#define CAM_CC_IFE_LITE_AHB_CLK 61
>> +#define CAM_CC_IFE_LITE_CLK 62
>> +#define CAM_CC_IFE_LITE_CLK_SRC 63
>> +#define CAM_CC_IFE_LITE_CPHY_RX_CLK 64
>> +#define CAM_CC_IFE_LITE_CSID_CLK 65
>> +#define CAM_CC_IFE_LITE_CSID_CLK_SRC 66
>> +#define CAM_CC_IPE_NPS_AHB_CLK 67
>> +#define CAM_CC_IPE_NPS_CLK 68
>> +#define CAM_CC_IPE_NPS_CLK_SRC 69
>> +#define CAM_CC_IPE_NPS_FAST_AHB_CLK 70
>> +#define CAM_CC_IPE_PPS_CLK 71
>> +#define CAM_CC_IPE_PPS_FAST_AHB_CLK 72
>> +#define CAM_CC_JPEG_0_CLK 73
>> +#define CAM_CC_JPEG_1_CLK 74
>> +#define CAM_CC_JPEG_CLK_SRC 75
>> +#define CAM_CC_OFE_AHB_CLK 76
>> +#define CAM_CC_OFE_ANCHOR_CLK 77
>> +#define CAM_CC_OFE_ANCHOR_FAST_AHB_CLK 78
>> +#define CAM_CC_OFE_CLK_SRC 79
>> +#define CAM_CC_OFE_HDR_CLK 80
>> +#define CAM_CC_OFE_HDR_FAST_AHB_CLK 81
>> +#define CAM_CC_OFE_MAIN_CLK 82
>> +#define CAM_CC_OFE_MAIN_FAST_AHB_CLK 83
>> +#define CAM_CC_PLL0 84
>> +#define CAM_CC_PLL0_OUT_EVEN 85
>> +#define CAM_CC_PLL0_OUT_ODD 86
>> +#define CAM_CC_PLL1 87
>> +#define CAM_CC_PLL1_OUT_EVEN 88
>> +#define CAM_CC_PLL2 89
>> +#define CAM_CC_PLL2_OUT_EVEN 90
>> +#define CAM_CC_PLL3 91
>> +#define CAM_CC_PLL3_OUT_EVEN 92
>> +#define CAM_CC_PLL4 93
>> +#define CAM_CC_PLL4_OUT_EVEN 94
>> +#define CAM_CC_PLL5 95
>> +#define CAM_CC_PLL5_OUT_EVEN 96
>> +#define CAM_CC_PLL6 97
>> +#define CAM_CC_PLL6_OUT_EVEN 98
>> +#define CAM_CC_PLL6_OUT_ODD 99
>> +#define CAM_CC_QDSS_DEBUG_CLK 100
>> +#define CAM_CC_QDSS_DEBUG_CLK_SRC 101
>> +#define CAM_CC_QDSS_DEBUG_XO_CLK 102
>> +#define CAM_CC_SLEEP_CLK 103
>> +#define CAM_CC_SLEEP_CLK_SRC 104
>> +#define CAM_CC_SLOW_AHB_CLK_SRC 105
>> +#define CAM_CC_TFE_0_BAYER_CLK 106
>> +#define CAM_CC_TFE_0_BAYER_FAST_AHB_CLK 107
>> +#define CAM_CC_TFE_0_CLK_SRC 108
>> +#define CAM_CC_TFE_0_MAIN_CLK 109
>> +#define CAM_CC_TFE_0_MAIN_FAST_AHB_CLK 110
>> +#define CAM_CC_TFE_1_BAYER_CLK 111
>> +#define CAM_CC_TFE_1_BAYER_FAST_AHB_CLK 112
>> +#define CAM_CC_TFE_1_CLK_SRC 113
>> +#define CAM_CC_TFE_1_MAIN_CLK 114
>> +#define CAM_CC_TFE_1_MAIN_FAST_AHB_CLK 115
>> +#define CAM_CC_TFE_2_BAYER_CLK 116
>> +#define CAM_CC_TFE_2_BAYER_FAST_AHB_CLK 117
>> +#define CAM_CC_TFE_2_CLK_SRC 118
>> +#define CAM_CC_TFE_2_MAIN_CLK 119
>> +#define CAM_CC_TFE_2_MAIN_FAST_AHB_CLK 120
>> +#define CAM_CC_XO_CLK_SRC 121
>> +
>> +/* CAM_CC power domains */
>> +#define CAM_CC_TITAN_TOP_GDSC 0
>> +#define CAM_CC_IPE_0_GDSC 1
>> +#define CAM_CC_OFE_GDSC 2
>> +#define CAM_CC_TFE_0_GDSC 3
>> +#define CAM_CC_TFE_1_GDSC 4
>> +#define CAM_CC_TFE_2_GDSC 5
>> +
>> +/* CAM_CC resets */
>> +#define CAM_CC_DRV_BCR 0
>> +#define CAM_CC_ICP_BCR 1
>> +#define CAM_CC_IPE_0_BCR 2
>> +#define CAM_CC_OFE_BCR 3
>> +#define CAM_CC_QDSS_DEBUG_BCR 4
>> +#define CAM_CC_TFE_0_BCR 5
>> +#define CAM_CC_TFE_1_BCR 6
>> +#define CAM_CC_TFE_2_BCR 7
>> +
>> +#endif
>>
>
--
Thanks,
Taniya Das
next prev parent reply other threads:[~2025-12-17 9:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 10:26 [PATCH 0/3] Add the support for SM8750 Camera clock controller Taniya Das
2025-12-02 10:26 ` [PATCH 1/3] clk: qcom: clk-alpha-pll: Add support for Rivian ELU PLL Taniya Das
2025-12-02 15:37 ` Konrad Dybcio
2025-12-02 10:26 ` [PATCH 2/3] dt-bindings: clock: qcom: Add camera clock controller for SM8750 SoC Taniya Das
2025-12-03 14:09 ` Vladimir Zapolskiy
2025-12-17 9:58 ` Taniya Das [this message]
2025-12-02 10:26 ` [PATCH 3/3] clk: qcom: camcc: Add camera clock controller driver " Taniya Das
2025-12-06 4:02 ` Dmitry Baryshkov
2025-12-18 12:36 ` Konrad Dybcio
2026-01-07 18:38 ` (subset) [PATCH 0/3] Add the support for SM8750 Camera clock controller Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca336f38-f831-4cb7-8f2d-66a4302e0efb@oss.qualcomm.com \
--to=taniya.das@oss.qualcomm.com \
--cc=ajit.pandey@oss.qualcomm.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imran.shaik@oss.qualcomm.com \
--cc=jagadeesh.kona@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mturquette@baylibre.com \
--cc=quic_jkona@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®