mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Gregory Price <gourry@gourry.net>
Cc: Li Zhe <lizhe.67@bytedance.com>,
	akpm@linux-foundation.org, ljs@kernel.org, liam@infradead.org,
	rppt@kernel.org, mhocko@suse.com, corbet@lwn.net,
	skhan@linuxfoundation.org, ziy@nvidia.com,
	joshua.hahnjy@gmail.com, ying.huang@linux.alibaba.com,
	apopple@nvidia.com, linux-mm@kvack.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/numa_balancing: allow migrate on protnone reference with MPOL_WEIGHTED_INTERLEAVE policy
Date: Wed, 30 Sep 2026 14:32:16 +0200	[thread overview]
Message-ID: <ca35c989-9aa1-491f-a247-ed36724f10a0@kernel.org> (raw)
In-Reply-To: <arz56nVu8TzSjqlg@gourry-fedora-PF4VCD3F>

On 9/30/26 14:03, Gregory Price wrote:
> On Wed, Sep 30, 2026 at 01:26:17PM +0200, David Hildenbrand (Arm) wrote:
>>>
>>> Initial placement is only a starting point.  Pages initially allocated on
>>> fast memory are not necessarily the long-term hot pages, and pages
>>> initially allocated on slower memory may become hot as the workload's hot
>>> set changes.  The policy therefore needs to be able to combine weighted
>>> initial placement with memory tiering's NUMA fault based hot-page
>>> promotion.
>>
>> Ok, so memory allocation will respect the weights but balancing will ignore
>> them? That really sounds rather odd to me.
>>
>> And I assume that was the reason why we might have disallowed the combination:
>> it turns a weighted mechanism into an unweighted mechanism.
>>
>> So are we really sure these semantics that you would essentially set in stone
>> here are the semantics we want? (ignoring weights)
>>
> 
> Right, but you're requesting this configuration.  If you didn't set
> F_NUMA_BALANCING then you get the existing semantics.
> 
> In the existing semantics, if we're INTERLEAVE and WEIGHTED_INTERLEAVE
> we just always say "no tiering for you".
> 
> But as an opt-in option?  I don't quite see the argument for saying
> interleaved regions (or tasks) to be opted-out if the user asks for it -
> that just seems like an arbitrary limitation.

Just to be clear, what I am saying is: the proposed semantics are inconsistent
(weighted when mechanism A honors them and mechanism B doesn't honor them), but
once we set these semantics in stone like that, we cannot easily change them
later because some user might depend on that behavior.

So you'll need yet another flag to say "NUMA balancing really also honors the
weights". And that's where it all gets ugly.

-- 
Cheers,

David

  reply	other threads:[~2026-09-30 12:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-30  7:26 Li Zhe
2026-09-30  8:43 ` Gregory Price
2026-09-30  8:59   ` Li Zhe
2026-09-30  9:11     ` Gregory Price
2026-09-30 10:59       ` Joshua Hahn
2026-09-30 11:22       ` Li Zhe
2026-09-30 12:25         ` Gregory Price
2026-09-30 11:26 ` David Hildenbrand (Arm)
2026-09-30 11:52   ` Li Zhe
2026-09-30 12:11     ` Joshua Hahn
2026-09-30 14:02       ` Li Zhe
2026-09-30 12:03   ` Gregory Price
2026-09-30 12:32     ` David Hildenbrand (Arm) [this message]
2026-09-30 13:40       ` Gregory Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca35c989-9aa1-491f-a247-ed36724f10a0@kernel.org \
    --to=david@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=corbet@lwn.net \
    --cc=gourry@gourry.net \
    --cc=joshua.hahnjy@gmail.com \
    --cc=liam@infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizhe.67@bytedance.com \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=ying.huang@linux.alibaba.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®