mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	David Airlie <airlied@gmail.com>,
	Felix Kuehling <Felix.Kuehling@amd.com>,
	Harry Wentland <harry.wentland@amd.com>,
	Leo Li <sunpeng.li@amd.com>, Simona Vetter <simona@ffwll.ch>,
	Sumit Semwal <sumit.semwal@linaro.org>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH v4 00/12] drm/amdgpu: use all SDMA instances for TTM clears and moves
Date: Thu, 26 Mar 2026 13:48:05 +0100	[thread overview]
Message-ID: <ca366b4a-ae51-4387-b0e7-86e9844b01e1@amd.com> (raw)
In-Reply-To: <20260203102236.3456-1-pierre-eric.pelloux-prayer@amd.com>

Finally coming back to this patch set here.

Fell free to add Reviewed-by: Christian König <christian.koenig@amd.com> to the first two patches as well and then please start pushing the patches to amd-staging-drm-next.

I probably need to go over the last patches once more, but I think it would be better to have the first few upstream first.

Regards,
Christian.

On 2/3/26 11:22, Pierre-Eric Pelloux-Prayer wrote:
> The drm/ttm patch modifies TTM to support multiple contexts for the pipelined moves.
> 
> Then amdgpu/ttm is updated to express dependencies between jobs explicitely,
> instead of relying on the ordering of execution guaranteed by the use of a single
> instance.
> With all of this in place, we can use multiple entities, with each having access
> to the available SDMA instances.
> 
> This rework also gives the opportunity to merge the clear functions into a single
> one and to optimize a bit GART usage.
> 
> Since v3 some patches have been already reviewed and merged separately:
> - https://lists.freedesktop.org/archives/amd-gfx/2026-January/137747.html
> - https://gitlab.freedesktop.org/drm/kernel/-/commit/ddf055b80a544d6f36f77be5f0c6d3c80177d57c
> This version depend on them.
> 
> v3: https://lists.freedesktop.org/archives/dri-devel/2025-November/537830.html
> 
> Pierre-Eric Pelloux-Prayer (12):
>   drm/amdgpu: allocate clear entities dynamically
>   drm/amdgpu: allocate move entities dynamically
>   drm/amdgpu: round robin through clear_entities in amdgpu_fill_buffer
>   drm/amdgpu: use TTM_NUM_MOVE_FENCES when reserving fences
>   drm/amdgpu: use multiple entities in amdgpu_move_blit
>   drm/amdgpu: pass all the sdma scheds to amdgpu_mman
>   drm/amdgpu: only use working sdma schedulers for ttm
>   drm/amdgpu: create multiple clear/move ttm entities
>   drm/amdgpu: give ttm entities access to all the sdma scheds
>   drm/amdgpu: get rid of amdgpu_ttm_clear_buffer
>   drm/amdgpu: rename amdgpu_fill_buffer as amdgpu_ttm_clear_buffer
>   drm/amdgpu: split amdgpu_ttm_set_buffer_funcs_status in 2 funcs
> 
>  drivers/gpu/drm/amd/amdgpu/amdgpu.h           |   2 +
>  drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c        |   5 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |  16 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c       |   4 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_object.c    |  17 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c       | 329 ++++++++++--------
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h       |  29 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c      |   6 +-
>  drivers/gpu/drm/amd/amdgpu/cik_sdma.c         |  13 +-
>  drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c        |   8 +-
>  drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c        |   8 +-
>  drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c        |  15 +-
>  drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c      |  12 +-
>  drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c        |  11 +-
>  drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c        |  14 +-
>  drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c        |   5 +-
>  drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c        |   5 +-
>  drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c        |  12 +-
>  drivers/gpu/drm/amd/amdgpu/si_dma.c           |  12 +-
>  drivers/gpu/drm/amd/amdkfd/kfd_migrate.c      |   5 +-
>  drivers/gpu/drm/amd/amdkfd/kfd_svm.c          |   3 +-
>  .../amd/display/amdgpu_dm/amdgpu_dm_plane.c   |   6 +-
>  .../drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c  |   6 +-
>  23 files changed, 300 insertions(+), 243 deletions(-)
> 


      parent reply	other threads:[~2026-03-26 12:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03 10:22 Pierre-Eric Pelloux-Prayer
2026-02-03 10:22 ` [PATCH v4 01/12] drm/amdgpu: allocate clear entities dynamically Pierre-Eric Pelloux-Prayer
2026-02-03 10:22 ` [PATCH v4 02/12] drm/amdgpu: allocate move " Pierre-Eric Pelloux-Prayer
2026-02-03 10:22 ` [PATCH v4 03/12] drm/amdgpu: round robin through clear_entities in amdgpu_fill_buffer Pierre-Eric Pelloux-Prayer
2026-02-03 10:22 ` [PATCH v4 04/12] drm/amdgpu: use TTM_NUM_MOVE_FENCES when reserving fences Pierre-Eric Pelloux-Prayer
2026-02-03 10:22 ` [PATCH v4 05/12] drm/amdgpu: use multiple entities in amdgpu_move_blit Pierre-Eric Pelloux-Prayer
2026-02-03 10:22 ` [PATCH v4 06/12] drm/amdgpu: pass all the sdma scheds to amdgpu_mman Pierre-Eric Pelloux-Prayer
2026-02-03 10:22 ` [PATCH v4 07/12] drm/amdgpu: only use working sdma schedulers for ttm Pierre-Eric Pelloux-Prayer
2026-02-03 10:22 ` [PATCH v4 08/12] drm/amdgpu: create multiple clear/move ttm entities Pierre-Eric Pelloux-Prayer
2026-02-03 10:22 ` [PATCH v4 09/12] drm/amdgpu: give ttm entities access to all the sdma scheds Pierre-Eric Pelloux-Prayer
2026-02-03 10:22 ` [PATCH v4 10/12] drm/amdgpu: get rid of amdgpu_ttm_clear_buffer Pierre-Eric Pelloux-Prayer
2026-02-03 10:22 ` [PATCH v4 11/12] drm/amdgpu: rename amdgpu_fill_buffer as amdgpu_ttm_clear_buffer Pierre-Eric Pelloux-Prayer
2026-02-03 10:22 ` [PATCH v4 12/12] drm/amdgpu: split amdgpu_ttm_set_buffer_funcs_status in 2 funcs Pierre-Eric Pelloux-Prayer
2026-03-26 12:48 ` Christian König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca366b4a-ae51-4387-b0e7-86e9844b01e1@amd.com \
    --to=christian.koenig@amd.com \
    --cc=Felix.Kuehling@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=pierre-eric.pelloux-prayer@amd.com \
    --cc=simona@ffwll.ch \
    --cc=sumit.semwal@linaro.org \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®