From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98BEC20DF4 for ; Wed, 14 Aug 2024 08:18:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723623533; cv=none; b=EjxNGJZY0LCxTf9HMwk/LjNmqDAr/bvd7jIwSG38m1ER5BqO+/pZV6OMKWcriTVI/EcgctP4koxrCh0CXIgLQd77avNs5SLpaDB8QmXhZqIm/yCrPjBG21lb5CldWDFQu5aBGD+cffqcz9EfpjdI978sD58RUxDA6nCsSOb6W8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723623533; c=relaxed/simple; bh=Bo+cvE6AzFqGuhj9yQ85orHVEh4e45C2T9RFCQcQqRQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gO9CPvmgB+YWA3xp3x+406nzOl1L7o3E1mnspIOYIZX/IOffqasbkZmcIqwaExv5Otd/y9/kY6JksyfzvgIXOHmU/RJF/ppPsmCApc4BTGLOoRUerJhuBMQTlvGwIN1/ZJ+wu/Z8okvwJK0Nn1VxMzcN8GdCVngDACpgNL8rqUU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hNWupK9l; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hNWupK9l" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723623530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Z94kh2aK5DKJ1BUORso0hBz/WCm43VlL59JWdkhMVvY=; b=hNWupK9lZLLDHVLDh+o+JSkFruQQvq4vNR2dyJxKv5YorbTMoPnPiSYGTvIKCmZAoB3jRX AaCwc5vyGOTtoS381l2erZOOA5exdOtmrZt57IYwQ/4Dtqd/3Z2BxZLG6JoX4b/3YPv0rN Sr/F6Pc/sNH8wy7VtFC8JUNfHiHYR7M= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-214-fGHC01zoNB6Fr8r7BQqbPQ-1; Wed, 14 Aug 2024 04:18:48 -0400 X-MC-Unique: fGHC01zoNB6Fr8r7BQqbPQ-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-371730a4870so626202f8f.3 for ; Wed, 14 Aug 2024 01:18:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723623527; x=1724228327; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Z94kh2aK5DKJ1BUORso0hBz/WCm43VlL59JWdkhMVvY=; b=fFJ7cJD3x/L2d9Oug3kOCOOaa8B1dXbfbE2K+k0WBgMzcJ/MFjwFL8IsRiB5vBsK7s qZMwxd7H6vGGgxPpK6NqY6rpzIZoNQZpW0FQgPxpMo0NrCnKTZbGBXt6Sy/LDw26htfK GVuyOavFNWZyi053SX7A7jPIpFDduC7pG76wKSQoaEafoE7Qfkqmx0g7XXUBrqzQn4bG T0L+5jBlb3o7IlwNXNdeapgzWtPTvTBqIVSfwLvApEhdXEuQ2XKkM8Z68UogGSSB0w/m yjOXf+sQSnU75m/qo7Lnbf5yD7Wd11pHJr68XNv1k3RN6RKtP89EeXT5MHdChn0diZkQ WbTA== X-Forwarded-Encrypted: i=1; AJvYcCX64sM6IVRlwx+lSUJFpF/aAh8HGDDvqjJ4rlGS/O+RiyonY5RA8QizE9I9oYiQ6W//x1YKRFr80+IJxoZIbluqZg70Sq+NOGU0lhiO X-Gm-Message-State: AOJu0YxeozhBAKy//dP2jjH4nXiK/sCqaeGdQYw/Jxr2TuHcqnLyp6kc YWLFg+DoCurqN0ZREbtQNeSO15+6qn0lc0L1xtMkzyFFnW2hbX3pViej9Anp6+w3UUeCYATA7hY J8RR6AO/KAW+k60RWJL7jbxE6dePERZumT4rbvleCzf5p/KulWrzx4axnNypnOw== X-Received: by 2002:a5d:614e:0:b0:369:f7f9:9ee with SMTP id ffacd0b85a97d-3717775f755mr1442935f8f.6.1723623527183; Wed, 14 Aug 2024 01:18:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEQQepLhMSJVK+6laO5CjE0En1HAThAETBNbr0Zt6IO9xIIyhRLRlpQsE8C/wS0ClIhxII2hw== X-Received: by 2002:a5d:614e:0:b0:369:f7f9:9ee with SMTP id ffacd0b85a97d-3717775f755mr1442918f8f.6.1723623526625; Wed, 14 Aug 2024 01:18:46 -0700 (PDT) Received: from ?IPV6:2003:d8:2f09:3f00:d228:bd67:7baa:d604? (p200300d82f093f00d228bd677baad604.dip0.t-ipconnect.de. [2003:d8:2f09:3f00:d228:bd67:7baa:d604]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36e4e51ebe4sm12213719f8f.85.2024.08.14.01.18.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Aug 2024 01:18:46 -0700 (PDT) Message-ID: Date: Wed, 14 Aug 2024 10:18:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] mm: Override mTHP "enabled" defaults at kernel cmdline To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: baohua@kernel.org, baolin.wang@linux.alibaba.com, corbet@lwn.net, ioworker0@gmail.com, linux-kernel@vger.kernel.org, ryan.roberts@arm.com, v-songbaohua@oppo.com References: <20240814020247.67297-1-21cnbao@gmail.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240814020247.67297-1-21cnbao@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14.08.24 04:02, Barry Song wrote: > From: Ryan Roberts > > Add thp_anon= cmdline parameter to allow specifying the default > enablement of each supported anon THP size. The parameter accepts the > following format and can be provided multiple times to configure each > size: > > thp_anon=,[KMG]:;-[KMG]: > > An example: > > thp_anon=16K-64K:always;128K,512K:inherit;256K:madvise;1M-2M:never > > See Documentation/admin-guide/mm/transhuge.rst for more details. > > Configuring the defaults at boot time is useful to allow early user > space to take advantage of mTHP before its been configured through > sysfs. > > Signed-off-by: Ryan Roberts > Co-developed-by: Barry Song > Signed-off-by: Barry Song > --- > -v4: > * use bitmap APIs to set and clear bits. thanks very much for > David's comment! > > .../admin-guide/kernel-parameters.txt | 9 ++ > Documentation/admin-guide/mm/transhuge.rst | 37 +++++-- > mm/huge_memory.c | 96 ++++++++++++++++++- > 3 files changed, 134 insertions(+), 8 deletions(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index f0057bac20fb..d0d141d50638 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -6629,6 +6629,15 @@ > : poll all this frequency > 0: no polling (default) > > + thp_anon= [KNL] > + Format: ,[KMG]:;-[KMG]: > + state is one of "always", "madvise", "never" or "inherit". > + Can be used to control the default behavior of the > + system with respect to anonymous transparent hugepages. > + Can be used multiple times for multiple anon THP sizes. > + See Documentation/admin-guide/mm/transhuge.rst for more > + details. > + > threadirqs [KNL,EARLY] > Force threading of all interrupt handlers except those > marked explicitly IRQF_NO_THREAD. > diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst > index 7072469de8a8..528e1a19d63f 100644 > --- a/Documentation/admin-guide/mm/transhuge.rst > +++ b/Documentation/admin-guide/mm/transhuge.rst > @@ -284,13 +284,36 @@ that THP is shared. Exceeding the number would block the collapse:: > > A higher value may increase memory footprint for some workloads. > > -Boot parameter > -============== > - > -You can change the sysfs boot time defaults of Transparent Hugepage > -Support by passing the parameter ``transparent_hugepage=always`` or > -``transparent_hugepage=madvise`` or ``transparent_hugepage=never`` > -to the kernel command line. > +Boot parameters > +=============== > + > +You can change the sysfs boot time default for the top-level "enabled" > +control by passing the parameter ``transparent_hugepage=always`` or > +``transparent_hugepage=madvise`` or ``transparent_hugepage=never`` to the > +kernel command line. > + > +Alternatively, each supported anonymous THP size can be controlled by > +passing ``thp_anon=,[KMG]:;-[KMG]:``, > +where ```` is the THP size and ```` is one of ``always``, > +``madvise``, ``never`` or ``inherit``. > + > +For example, the following will set 16K, 32K, 64K THP to ``always``, > +set 128K, 512K to ``inherit``, set 256K to ``madvise`` and 1M, 2M > +to ``never``:: > + > + thp_anon=16K-64K:always;128K,512K:inherit;256K:madvise;1M-2M:never > + > +``thp_anon=`` may be specified multiple times to configure all THP sizes as > +required. If ``thp_anon=`` is specified at least once, any anon THP sizes > +not explicitly configured on the command line are implicitly set to > +``never``. > + > +``transparent_hugepage`` setting only affects the global toggle. If > +``thp_anon`` is not specified, PMD_ORDER THP will default to ``inherit``. > +However, if a valid ``thp_anon`` setting is provided by the user, the > +PMD_ORDER THP policy will be overridden. If the policy for PMD_ORDER > +is not defined within a valid ``thp_anon``, its policy will default to > +``never``. > > Hugepages in tmpfs/shmem > ======================== > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 1a12c011e2df..c5f4e97b49de 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -81,6 +81,7 @@ unsigned long huge_zero_pfn __read_mostly = ~0UL; > unsigned long huge_anon_orders_always __read_mostly; > unsigned long huge_anon_orders_madvise __read_mostly; > unsigned long huge_anon_orders_inherit __read_mostly; > +static bool anon_orders_configured; > > unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma, > unsigned long vm_flags, > @@ -737,7 +738,10 @@ static int __init hugepage_init_sysfs(struct kobject **hugepage_kobj) > * disable all other sizes. powerpc's PMD_ORDER isn't a compile-time > * constant so we have to do this here. > */ > - huge_anon_orders_inherit = BIT(PMD_ORDER); > + if (!anon_orders_configured) { > + huge_anon_orders_inherit = BIT(PMD_ORDER); > + anon_orders_configured = true; > + } > > *hugepage_kobj = kobject_create_and_add("transparent_hugepage", mm_kobj); > if (unlikely(!*hugepage_kobj)) { > @@ -922,6 +926,96 @@ static int __init setup_transparent_hugepage(char *str) > } > __setup("transparent_hugepage=", setup_transparent_hugepage); > > +static inline int get_order_from_str(const char *size_str) > +{ > + unsigned long size; > + char *endptr; > + int order; > + > + size = memparse(size_str, &endptr); Do we have to also test if is_power_of_2(), and refuse if not? For example, what if someone would pass 3K, would the existing check catch it? > + order = fls(size >> PAGE_SHIFT) - 1; Is this a fancy way of writing order = log2(size >> PAGE_SHIFT); ? :) Anyhow, if get_order() wraps that, all good. > + if ((1 << order) & ~THP_ORDERS_ALL_ANON) { > + pr_err("invalid size %s(order %d) in thp_anon boot parameter\n", > + size_str, order); > + return -EINVAL; > + } > + > + return order; > +} Apart from that, nothing jumped at me. -- Cheers, David / dhildenb