mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vishnu Santhosh <vishnu.santhosh@oss.qualcomm.com>
To: Stephan Gerhold <stephan@gerhold.net>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Loic Poulain <loic.poulain@oss.qualcomm.com>,
	Sergey Ryazanov <ryazanov.s.a@gmail.com>,
	Johannes Berg <johannes@sipsolutions.net>
Cc: linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Deepak Kumar Singh <deepak.singh@oss.qualcomm.com>
Subject: Re: [PATCH net-next v2 0/2] net: wwan: qcom_bam_dmux: Add restricted DMA pool support
Date: Mon, 28 Sep 2026 16:02:47 +0530	[thread overview]
Message-ID: <ca3c86b6-c837-4298-a1ab-4fc61a2f8a0a@oss.qualcomm.com> (raw)
In-Reply-To: <20260920-qcom-bam-dmux-vmid-ext-v2-0-ef5ca2178378@oss.qualcomm.com>


On 20-09-2026 08:32 am, Vishnu Santhosh wrote:
> Some Qualcomm SoCs, such as Shikra, run the modem in a separate security
> domain with restricted access to system memory. BAM-DMUX DMA mappings
> and BAM descriptor FIFOs must therefore be constrained to a designated
> memory region that can be shared with the modem. Accesses outside that
> region can trigger an XPU violation.
>
> Add memory-region and qcom,vmid properties to the BAM-DMUX binding.
> When qcom,vmid is present, the driver SCM-assigns the entire restricted
> DMA pool to the local and remote execution environments before requesting
> the DMA channels.
>
> The restricted pool then contains the BAM-DMUX mappings. When the BAM DMA
> controller references the same pool, its descriptor FIFOs are covered by
> the assignment as well.
>
> A related binding change allows the BAM DMA controller to use the same
> restricted pool for descriptor FIFO allocations:
>
> https://lore.kernel.org/all/20260920-qcom-bam-dma-vmid-ext-v2-1-4dbbff0e57c8@oss.qualcomm.com/
> ("dt-bindings: dma: qcom,bam-dma: Allow memory-region property")
>
> Signed-off-by: Vishnu Santhosh <vishnu.santhosh@oss.qualcomm.com>
> ---
> Changes in v2:
> - Replace the Shikra-specific compatible and coherent RX allocation with
>    memory-region and qcom,vmid properties.
> - Use a restricted DMA pool for BAM-DMUX mappings and BAM descriptor FIFOs.
> - SCM-assign the complete pool before requesting the DMA channels.
> - Validate the remote VMID and restricted DMA pool configuration.
> - Link to v1: https://lore.kernel.org/r/20260714-qcom-bam-dmux-vmid-ext-v1-0-3f29da7cca76@oss.qualcomm.com
>
> ---
> Vishnu Santhosh (2):
>        dt-bindings: net: qcom,bam-dmux: Add memory-region and qcom,vmid properties
>        net: wwan: qcom_bam_dmux: Assign restricted DMA pool to remote processor
>
>   .../devicetree/bindings/net/qcom,bam-dmux.yaml     | 38 +++++++++
>   drivers/net/wwan/Kconfig                           |  1 +
>   drivers/net/wwan/qcom_bam_dmux.c                   | 95 ++++++++++++++++++++++
>   3 files changed, 134 insertions(+)
> ---
> base-commit: 8830e65ed46de41f849eefb8ba227d4852c460f6
> change-id: 20260714-qcom-bam-dmux-vmid-ext-d9289db310c1
>
> Best regards,

Hi Stephan,

I followed your suggestion and updated v2 to use the restricted DMA pool.

Please let me know if this approach and the implementation look reasonable and
meets your expectations.

Thanks,
Vishnu


      parent reply	other threads:[~2026-09-28 10:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-20  3:02 Vishnu Santhosh
2026-09-20  3:02 ` [PATCH net-next v2 1/2] dt-bindings: net: qcom,bam-dmux: Add memory-region and qcom,vmid properties Vishnu Santhosh
2026-09-20 10:36   ` Krzysztof Kozlowski
2026-09-21  8:16     ` Loic Poulain
2026-09-21 11:04     ` Vishnu Santhosh
2026-09-21  3:48   ` netdev-bot+sashiko
2026-09-20  3:02 ` [PATCH net-next v2 2/2] net: wwan: qcom_bam_dmux: Assign restricted DMA pool to remote processor Vishnu Santhosh
2026-09-21  3:48   ` netdev-bot+sashiko
2026-09-21  7:59   ` Loic Poulain
2026-09-21 11:13     ` Vishnu Santhosh
2026-09-28 10:32 ` Vishnu Santhosh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca3c86b6-c837-4298-a1ab-4fc61a2f8a0a@oss.qualcomm.com \
    --to=vishnu.santhosh@oss.qualcomm.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=deepak.singh@oss.qualcomm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=johannes@sipsolutions.net \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=ryazanov.s.a@gmail.com \
    --cc=stephan@gerhold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®