From: "Andreas Färber" <afaerber@suse.de>
To: James Tai <james.tai@realtek.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-realtek-soc@lists.infradead.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: realtek: Document RTD1319 and Realtek PymParticle EVB
Date: Thu, 5 Dec 2019 09:33:54 +0100 [thread overview]
Message-ID: <ca3edb07-b2d4-7305-9a34-c4d55f30d778@suse.de> (raw)
In-Reply-To: <20191205082555.22633-2-james.tai@realtek.com>
Hi James,
Am 05.12.19 um 09:25 schrieb James Tai:
> Define compatible strings for Realtek RTD1319 SoC and Realtek PymParticle
> EVB.
>
> Signed-off-by: James Tai <james.tai@realtek.com>
> ---
> Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml b/Documentation/devicetree/bindings/arm/realtek.yaml
> index 2444eff2c3d5..f018d683a544 100644
> --- a/Documentation/devicetree/bindings/arm/realtek.yaml
> +++ b/Documentation/devicetree/bindings/arm/realtek.yaml
> @@ -39,4 +39,10 @@ properties:
> - enum:
> - realtek,mjolnir # Realtek Mjolnir EVB
> - const: realtek,rtd1619
> +
> + # RTD1319 SoC based boards
> + - items:
> + - enum:
> + - realtek,pymparticle # Realtek PymParticle EVB
> + - const: realtek,rtd1319
> ...
I think it would be better to order this alphabetically before RTD1395.
Otherwise looking good.
Thanks,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
next prev parent reply other threads:[~2019-12-05 8:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 8:25 [PATCH 0/2] Initial RTD1319 SoC and Realtek PymParticle EVB support James Tai
2019-12-05 8:25 ` [PATCH 1/2] dt-bindings: arm: realtek: Document RTD1319 and Realtek PymParticle EVB James Tai
2019-12-05 8:33 ` Andreas Färber [this message]
2019-12-18 23:28 ` Rob Herring
2019-12-05 8:25 ` [PATCH 2/2] arm64: dts: realtek: Add RTD1319 SoC " James Tai
2019-12-05 10:58 ` Andreas Färber
2019-12-05 12:10 ` Robin Murphy
2019-12-27 7:17 ` James Tai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca3edb07-b2d4-7305-9a34-c4d55f30d778@suse.de \
--to=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=james.tai@realtek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-realtek-soc@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®