mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Niklas Cassel <niklas.cassel@axis.com>
Cc: wim@iguana.be, edumazet@google.com, peterz@infradead.org,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: watchdog: softdog: fire watchdog even if softirqs do not get to run
Date: Mon, 27 Feb 2017 06:31:12 -0800	[thread overview]
Message-ID: <ca40e1a7-e1cc-07f0-f8f4-d020cf36b1e8@roeck-us.net> (raw)
In-Reply-To: <e550bcd0-2628-080a-c04c-f15623055a67@axis.com>

On 02/27/2017 04:58 AM, Niklas Cassel wrote:
> On 02/27/2017 05:04 AM, Guenter Roeck wrote:
>> On Fri, Feb 17, 2017 at 07:25:02PM +0100, Niklas Cassel wrote:
>>> From: Niklas Cassel <niklas.cassel@axis.com>
>>>
>>> Checking for timer expiration is done from the softirq TIMER_SOFTIRQ.
>>>
>>> Since commit 4cd13c21b207 ("softirq: Let ksoftirqd do its job"),
>>> pending softirqs are no longer always handled immediately, instead,
>>> if there are pending softirqs, and ksoftirqd is in state TASK_RUNNING,
>>> the handling of the softirqs are deferred, and are instead supposed
>>> to be handled by ksoftirqd, when ksoftirqd gets scheduled.
>>>
>>> If a user space process with a real-time policy starts to misbehave
>>> by never relinquishing the CPU while ksoftirqd is in state TASK_RUNNING,
>>> what will happen is that all softirqs will get deferred, while ksoftirqd,
>>> which is supposed to handle the deferred softirqs, will never get to run.
>>>
>>> To make sure that the watchdog is able to fire even when we do not get
>>> to run softirqs, replace the timers with hrtimers.
>>>
>>> Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
>>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>> Niklas,
>>
>> Please rebase onto current mainline, test, and resubmit.
>
> I've sent out a v2 now :)
>
> Although, I thought that it was a bit weird that the conflicting patch
> was in Linus tree but is not in next-20170227.
>
It was in the watchdog-next branch of my repository at kernel.org,
which is not in -next. I'll have to sort that out with Wim at some point.

> I'm not sure if you are the web master for www.linux-watchdog.org,
> but their cgit seems to be broken:
> http://www.linux-watchdog.org/cgi-bin/gitweb.cgi?p=linux-watchdog.git;a=summary
> http://www.linux-watchdog.org/cgi-bin/gitweb.cgi?p=linux-watchdog-next.git;a=summary
>
Wim knows about it, and plans to replace the server.

Guenter

      reply	other threads:[~2017-02-27 14:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-17 18:25 [PATCH] " Niklas Cassel
2017-02-19 16:46 ` Guenter Roeck
2017-02-20  8:36   ` Peter Zijlstra
2017-02-20  9:02     ` Guenter Roeck
2017-02-20 10:03   ` Niklas Cassel
2017-02-20 15:31     ` Guenter Roeck
2017-02-20 15:35 ` Guenter Roeck
2017-02-27  4:04 ` Guenter Roeck
2017-02-27 12:58   ` Niklas Cassel
2017-02-27 14:31     ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca40e1a7-e1cc-07f0-f8f4-d020cf36b1e8@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=edumazet@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=niklas.cassel@axis.com \
    --cc=peterz@infradead.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®