From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 357AE52BE2F for ; Wed, 9 Sep 2026 10:56:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788951375; cv=none; b=n5SLfQpAwhGFzABw4RZBYYqbIfIHl063LAdm8fxagyg27i1ZqWcFvIN2Gm/oAm7nF/eWk/vDcGsljqXT+jkFZs3dZEzm1aD2Tbg8r7sNcYuGZhMFBFlqdbA9fTIhEqrFESs9wAEK9xlIrX/ai0XJLCDv5aaiU8CKYwg3WadshqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788951375; c=relaxed/simple; bh=DxxddZWg+QBWyHQkUpleRuQRXk/I9FUByrHy5QgB98g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KRE5RbL6dcnK4KiJJiuDyWeYGhDOe7dS28bJb/CC8JSvar3hlFPf60jg0ahJZRl586UPcXZc/d+0Lr1wJXDMh+kdzEHolvoSkZeFEgTwZzVHV/aXtxCsdDjgTkNdkM9rAW2FTm+ndPjxddPKOuf9B9JzSNJmvftEF4VJwuQKD6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hclNH5M4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=F1gwJRde; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hclNH5M4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="F1gwJRde" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 689Apg79515689 for ; Wed, 9 Sep 2026 10:56:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= auQFLUmyjDXuDTVQTivuKNJ2Vj1/bxUapYoge8mUhQA=; b=hclNH5M4ux6dUmNI R2Ru0QWruT4/BEHvLI6nILGeRAot9YguXGZ4dlB3v9J32SUYxFQOQUTUYcHAzVBa jHyDIIWTlDEKqNCSYcV1AI649MQ5JjqBgZ6mUq3vOs6+hD8vGEn+WEfy2eqaDpQr Fva0CtM0OPGp6TwANOJQ66Ra9iQ+8jr0wcTeqvqhfNGDFR+1w11x/90PP9mJjAAQ N219zCcuq9DsUltUlC+ld90esYdar9b06dUoGGx93QWiv58sTnsUjtX3RwvRBcaV p/oum13fZr1Iw8zq/Qb0CoMFIbvehnWHnxcw+biINwPmNqq8j/tW3/efr3WLlDIJ 14eh+Q== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gjywr1kky-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 09 Sep 2026 10:56:11 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-90520763ceaso12781546d6.2 for ; Wed, 09 Sep 2026 03:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788951370; x=1789556170; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=auQFLUmyjDXuDTVQTivuKNJ2Vj1/bxUapYoge8mUhQA=; b=F1gwJRdeXELiEziaKtSkEvhlUA8eiDzlJQ13xllQdM6aMTzkggvZOWp/+VBs2hR6vc qoEhran81t/dxM4QC0j4fE0cQ9zMtmswCO4IHR4Wa8avbP4idtU+oL5H7mOIP35zUHKH jRsaU2hBbgx1B+T2TmnFZ9k7MVioDyKn1d6BJ+LmTfLPD5W+myTtf3mqyMsYQYbb4iUX Pr730k+kfCeR4o97+xu4fzGWNGThE7eXfXmH60ktyLwrTnmUJgtwgEUmhJM+rZZujYs8 QmxG6Fub+0lI+5FaZRPRhbq9gaxq6H4nyzFcnUOpIivu+bUZILMH/e99NA5rjcdKTVQu xRJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788951370; x=1789556170; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=auQFLUmyjDXuDTVQTivuKNJ2Vj1/bxUapYoge8mUhQA=; b=f7GoqIFuv38SlkVkqLvklIPCei7Jydt6jKFO7cD6DuOqXv+UtFW4ch5dMkV6rc2Up2 8jYeUsJe6Tq/ntc6bjmJibWtXWSvN6IhNXAmNtzqQzqoLy5YllHw0j5HC7IvVaClxIzv fhakFUaaMDSqnrkDKXIu134KvTvdAHFZ3ordWh9SXMWC7MVmvhTsBKVraDw83+rL4knT gEggjMgFwX+tnY4zoufRPmTp7oAEw4PRMtIXonFvo3CamDDqiRmRVI4kC6X3H2zNIY5X 1ueU+M6UOAEWr8/M6i64jBeyiDl7yi+6Vt43b5Zl/BkylOmWCOtAbYcBb0ic1Cks2hQ+ bQJA== X-Forwarded-Encrypted: i=1; AKwUvBwl+bvulAXYc4WkMNkesagGnGR3V+WPVYmDfD5VFqnlxH6ognwAl9MQ/5oNZWlhR82c1sf2bT9A2cXHsOM=@vger.kernel.org X-Gm-Message-State: AFuF++nBcADTl2z9xZg3S3zF/GxGanIH1eBjYgE3Yvmf/TzB389Hfk07 sw4KobFlZVj2KQYaVmGuF/38UIWGlhJh6hYo5NA6Hn+CjNMekm15QHowjZwgDVINrezHLTy8ByH /e48kiJaL8LYgtbYcN7Rn4dFWrTcoay93FPVWaolRaUUyEsiFFd9eiHJ708aVaaBSN3Q= X-Gm-Gg: AYBFou1XnDPPWdchBPBPQRcRqZDRn3KO62m90h1vNKcTChjKCDdJSyJWHn9A7pb4sUj GpGrXgGdwaygw8eh3OgouQFudTFNqo17czRL3UGXhN46CnPrhVCApapu2VXf8mQaZebwyR9uYxq PguuYqOhcVUetHw8bH4ujNzWOOsKIZGjcWr+JYx+DUDA6s0ShORxL16lGG9hy3gxMOBEVKmPsXH 5VIkY1s1PbPviayUe1IbwwLfMeO/id2BRTekUaGZ5QeNKPV3bNr1drb/o2SW/Ca1KmYjWb1sYiY qH6CeXCy3HADnZ9jSoe6wvlvgoWv7SwXGlQLP7OOI+UwXIQRSdtnsbtWh8n5XT5cjwN67YY0y+2 VZzZnjr2W8Te7rSSrrYS7hQ== X-Received: by 2002:a05:6214:5015:b0:90c:76c3:2aea with SMTP id 6a1803df08f44-910479f881dmr288319856d6.5.1788951370046; Wed, 09 Sep 2026 03:56:10 -0700 (PDT) X-Received: by 2002:a05:6214:5015:b0:90c:76c3:2aea with SMTP id 6a1803df08f44-910479f881dmr288318726d6.5.1788951368368; Wed, 09 Sep 2026 03:56:08 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c260d036469sm756477166b.1.2026.09.09.03.56.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Sep 2026 03:56:07 -0700 (PDT) Message-ID: Date: Wed, 9 Sep 2026 12:56:05 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/3] PCI: qcom: Implement shutdown() callback To: Krishna Chaitanya Chundru , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260905-shutdown-v5-0-f0c6bafa1d4f@oss.qualcomm.com> <20260905-shutdown-v5-3-f0c6bafa1d4f@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260905-shutdown-v5-3-f0c6bafa1d4f@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=a4YAM0SF c=1 sm=1 tr=0 ts=6aa13b4b cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=Z7REpkxyZKBgooIMAs0A:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA5MDEyMSBTYWx0ZWRfXx4yKrNDf7S+U X+zsc9l06pZHxh04QD6BrnrzXSNg0HMqv2oICw22TqfpQ8sk9CZHx5IymangJoQfrQs6XWRhNOG cfqd4HzunT5GhOYIVEz+8gQsqlqw27eqYjFDUM4z0dzTc5gX17ZOSEY74PX9zpzLIBB8ClsFzIV m3/9l+02PZ+H1MhcE4HVQ1aTKKUTHDHZm2wRATP78iQ6USNfOZifnnDrhn9Mik+EWhbPzj9ZPES UUWXM0OYRoujhxkUU4MXp4JMzh0bg9z30jXhMzkhhhDCLTQINtp3kwScjBWKbUUFfmUv7M1l2Ou tflfU48NPfNpGdlKqXwee6rPRvu/q4RlOpfaVcJOnOFxA/Z4V7WzqV3DCmb+ZZuoLuFZekTLP2u mivX56EBHFNIqlIIwQWHT9ZNCMjg+bNW/MSPfwROYRq8a1CzGAZDztgGONTKlz08YjCjHNyQbQ+ UOzFzz2QFjHU4ZGM8SQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA5MDEyMSBTYWx0ZWRfXy/1EYimuZfea VMISZ+6uM4KFM3dRdLok4vyUbweldgpTrGG602FAegHwDAPb4f4DcTn1/7fv5FbuzhWuMT6UqIh u7WQEEsgLkY1+9r3sQ9kecgfrXj6JKE= X-Proofpoint-ORIG-GUID: hW2Gl32KugpVrmyaOR4sv42sOwg52Bq- X-Proofpoint-GUID: hW2Gl32KugpVrmyaOR4sv42sOwg52Bq- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_03,2026-09-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 spamscore=0 adultscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609090121 On 9/5/26 2:48 AM, Krishna Chaitanya Chundru wrote: > From: Manivannan Sadhasivam > > PCIe host controllers should bring the link down cleanly before system > shutdown/reboot proceeds to remove power/clocks from the controller. > Without this, the link may still be up and endpoints still have > transactions in flight when power/clocks are cut, which can trip SMMU > translation faults or NoC protocol errors. [...] > +static void qcom_pcie_shutdown(struct platform_device *pdev) > +{ > + const struct qcom_pcie_cfg *pcie_cfg = of_device_get_match_data(&pdev->dev); > + struct qcom_pcie *pcie; > + > + if (pcie_cfg && pcie_cfg->firmware_managed) { > + /* > + * Firmware owns the link teardown and clock/PHY shutdown in > + * this mode; Linux only owns the chained MSI IRQ(s), which > + * still need to be masked off before shutdown proceeds. > + */ > + struct dw_pcie *pci = platform_get_drvdata(pdev); > + > + if (pci->pp.use_imsi_rx) > + dw_pcie_free_msi(&pci->pp); > + return; > + } > + > + pcie = platform_get_drvdata(pdev); > + if (pcie) { > + if (pcie->pci->pp.use_imsi_rx) > + dw_pcie_free_msi(&pcie->pci->pp); > + > + if (pcie->global_irq) > + disable_irq(pcie->global_irq); > + > + pcie->pci->pp.force_d3cold = true; > + dw_pcie_suspend_noirq(pcie->pci); > + } > + if (!pcie) return/warn (should it be possible?) if (pci->pp.use_imsi_rx) dw_pcie_free_msi(&pci->pp); /* abc xyz */ if (firwmare_managed) return; will save you indentation and de-duplicate the free_msi() call Konrad