From: Reinette Chatre <reinette.chatre@intel.com>
To: Chen Yu <yu.c.chen@intel.com>
Cc: <tony.luck@intel.com>, <ben.horgan@arm.com>,
<james.morse@arm.com>, <Dave.Martin@arm.com>,
<babu.moger@amd.com>, <bp@alien8.de>, <tglx@linutronix.de>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
<fustini@kernel.org>, <fenghuay@nvidia.com>,
<peternewman@google.com>, <linux-kernel@vger.kernel.org>,
<patches@lists.linux.dev>
Subject: Re: [PATCH 4/5] fs/resctrl: Drop unnecessary is_mba_linear() helper
Date: Fri, 4 Sep 2026 08:51:03 -0700 [thread overview]
Message-ID: <ca4646c4-6ef9-4ef6-96fa-372ec0875506@intel.com> (raw)
In-Reply-To: <appLOliNv9E6-Ou6@fengwei-dev>
Hi Chenyu,
On 9/3/26 9:38 PM, Chen Yu wrote:
> On Thu, Sep 03, 2026 at 09:57:06AM -0700, Reinette Chatre wrote:
>> is_mba_linear() assumes it operates on the MBA resource and returns whether
>> the resource is linear. There is only one caller that separately makes the
>> same assumption.
>>
>> Avoid duplicating the resource assumptions and let the only caller access
>> the needed property directly.
>>
>> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
>> ---
>
> Reviewed-by: Chen Yu <yu.c.chen@intel.com>
>
Thank you very much.
Reinette
next prev parent reply other threads:[~2026-09-04 15:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 16:57 [PATCH 0/5] x86,fs/resctrl: Cleanups in preparation for multiple Reinette Chatre
2026-09-03 16:57 ` [PATCH 1/5] fs/resctrl: Drop support for different bandwidth delay mappings Reinette Chatre
2026-09-04 3:33 ` Chen Yu
2026-09-04 15:50 ` Reinette Chatre
2026-09-03 16:57 ` [PATCH 2/5] x86,fs/resctrl: Remove "arch_needs_linear" Reinette Chatre
2026-09-04 3:14 ` Chen Yu
2026-09-04 15:50 ` Reinette Chatre
2026-09-03 16:57 ` [PATCH 3/5] x86,fs/resctrl: Make MSR_IA32_L{2,3}_QOS_CFG scope architecture specific Reinette Chatre
2026-09-03 16:57 ` [PATCH 4/5] fs/resctrl: Drop unnecessary is_mba_linear() helper Reinette Chatre
2026-09-04 4:38 ` Chen Yu
2026-09-04 15:51 ` Reinette Chatre [this message]
2026-09-03 16:57 ` [PATCH 5/5] fs/resctrl: Drop unnecessary parameter from resctrl_io_alloc_parse_line() Reinette Chatre
2026-09-03 17:02 ` [PATCH 0/5] x86,fs/resctrl: Cleanups in preparation for multiple Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca4646c4-6ef9-4ef6-96fa-372ec0875506@intel.com \
--to=reinette.chatre@intel.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=ben.horgan@arm.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=fenghuay@nvidia.com \
--cc=fustini@kernel.org \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=peternewman@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®