From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6532BC4708D for ; Fri, 2 Dec 2022 08:19:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232915AbiLBITi (ORCPT ); Fri, 2 Dec 2022 03:19:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232777AbiLBISe (ORCPT ); Fri, 2 Dec 2022 03:18:34 -0500 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCFD613E07 for ; Fri, 2 Dec 2022 00:17:42 -0800 (PST) Received: by mail-lj1-x231.google.com with SMTP id d3so4611994ljl.1 for ; Fri, 02 Dec 2022 00:17:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JfOE5/j8wj6BlDWOHD6m2libhAmOvjCZ5n2WeZxrTXY=; b=X3Enft4Bpx+GTL1CPeXDZoyBQ66NZLIxzBRVdN+TPzDhGtMCu6dlZ2xMOaMTq+YjHm gC2qrQuZLsuv+KicuuY1xPo5eUrl/Uuzl/EhQx90HB3TbZ0dVeoTvVN7Du/UUq0en3oF SzcZFWepba2yxMyU5cTBjKUQQs9GktN+2efJ1qrqDDUaGBiWoEqFGgeHxWL5PzweU8/d P3BKCaiwFGuWblaZgmv+vQsJPqxk51Roe4mz1p3XPpWuIihygsHcLqHUt9fg5n2yjlRY vFVvEw/C9VVH2I/HHuHX5lfIF6OvahtLdzf9hrRNGPBkZBVXaOgUNIafWH0xK7xup73w WcsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JfOE5/j8wj6BlDWOHD6m2libhAmOvjCZ5n2WeZxrTXY=; b=sQbI6FQN5mYtkEPyXeSl0LRuRPGYdzQjPcyRDKjqUNHRnzeHEpVH+h1b/lADMkxX6K 2/ut5timZ2U1LOkYNrP/hMXwzeZ+xuADMd3qwkkXry2ElSdGCham7uT+f+repXtU27QZ /hM/SGhaPVuB2cv19zdzWqmyFJ/ghoeHkfgdroaqPETvWQPZXXapVBCnEZi9MSDa4pQI GTMQ6Ji5x5GSphv/mj5EepxHt9bKlWUpJRDkNsSlDlJZbvzplZxQYUR1vXdxK5Itn4KK 7R0AEWYolA5ZwUjuAK7Ayg+tmho2NXYeo1O61XqUMW2n5nffA+mr9LVNfGxUlSAFru6K 2q8w== X-Gm-Message-State: ANoB5pm0R+hF8lEx+QKNk7e0T/0/k/A+S7K0lN0tnHLrZuYKqk7ZmDyM 79p5KFucYU+0v1CtxT4rlwlXmQ== X-Google-Smtp-Source: AA0mqf5lKw0C907wt2lGjVxAsXvSsZaJfGqEkfGG95X36RWWZ83jYHx5z+q6KTosvWG1oB+aM3U97A== X-Received: by 2002:a2e:b0c3:0:b0:279:ba97:a2e7 with SMTP id g3-20020a2eb0c3000000b00279ba97a2e7mr4509787ljl.304.1669969061201; Fri, 02 Dec 2022 00:17:41 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id s21-20020a056512203500b004ab98cd5644sm940491lfs.182.2022.12.02.00.17.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Dec 2022 00:17:40 -0800 (PST) Message-ID: Date: Fri, 2 Dec 2022 09:17:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [RFT PATCH v2 1/2] arm64: dts: qcom: sdm845-db845c: drop unneeded qup_spi0_default Content-Language: en-US To: Doug Anderson , Vinod Koul , Bjorn Andersson Cc: Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221118164201.321147-1-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/12/2022 01:49, Doug Anderson wrote: > Hi, > > On Fri, Nov 18, 2022 at 8:42 AM Krzysztof Kozlowski > wrote: >> >> The qup_spi0_default pin override is exactly the same as one already in >> sdm845.dtsi. >> >> Signed-off-by: Krzysztof Kozlowski >> >> --- >> >> Cc: Doug Anderson >> >> Changes since v1: >> 1. New patch. >> --- >> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 8 -------- >> 1 file changed, 8 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts >> index 02dcf75c0745..56a7afb697ed 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts >> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts >> @@ -1274,11 +1274,3 @@ ov7251_ep: endpoint { >> }; >> }; >> }; >> - >> -/* PINCTRL - additions to nodes defined in sdm845.dtsi */ >> -&qup_spi0_default { >> - config { >> - drive-strength = <6>; >> - bias-disable; >> - }; >> -}; > > I guess it's more of a question for what Bjorn thinks, but I view the > fact that the drive-strength / bias are in the dtsi file to begin with > as more as a bug in commit 8f6e20adaaf3 ("arm64: dts: qcom: sdm845: > enable dma for spi"), which is where these properties were introduced > to sdm845.dtsi. > > The historical guidance from Bjorn was that things like > "drive-strength" and "bias" didn't belong in the SoC dtsi file. Later > we came to an agreement that it could be OK to put drive-strength in > the SoC dtsi file but that bias was still problematic because it meant > ugly "/delete-property/" stuff in the board dtsi files [1]. So let's move it from DTSI to all boards? Although what if the board does not use SPI0? Best regards, Krzysztof