From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3235AC433ED for ; Mon, 3 May 2021 12:57:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8DAF611C0 for ; Mon, 3 May 2021 12:57:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233328AbhECM6I (ORCPT ); Mon, 3 May 2021 08:58:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:57956 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231180AbhECM6H (ORCPT ); Mon, 3 May 2021 08:58:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 548D660D07; Mon, 3 May 2021 12:57:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620046633; bh=ogYrfqt3UbmvWma8Wl4DlNQu366hL6XxzCzX3CYiQ9s=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Cr5fbTDiScNHZzvQu1oI+UtnjAVYpyKY6AmDWOqj/KQtn2gBbvyancZ2NXigQxGVF Dex7Tu0pGvKbCcH3p+CNGL0X4RRPuX1JmeDZwXkOhtl1i8MaYd4Bo1M7f5f0Ri93MF mN359FsM1/YAIICiFQsBnR1Vwtw4oYsQBPFQntqPUrrm2Za4sMl/pYDHC2o7cXGzrS wq1RzbC0bdr1NNRbZhxTxUBUecH/3htaYb+XEUK9pfd00j71Y0nDVZuEXKSBZmjYjR HNgVK0/rOWwE+jgQMuMn/6ncaHpkZWCNXvqpcyetfl/irtlRPwmmwzBDTlmrXq8a8k MGP3X0Rh4UJww== Subject: Re: [PATCH 50/69] Revert "dmaengine: qcom_hidma: Check for driver register failure" To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: Aditya Pakki , Vinod Koul References: <20210503115736.2104747-1-gregkh@linuxfoundation.org> <20210503115736.2104747-51-gregkh@linuxfoundation.org> From: Sinan Kaya Message-ID: Date: Mon, 3 May 2021 08:57:11 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210503115736.2104747-51-gregkh@linuxfoundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/3/2021 7:57 AM, Greg Kroah-Hartman wrote: > This reverts commit a474b3f0428d6b02a538aa10b3c3b722751cb382. > > Because of recent interactions with developers from @umn.edu, all > commits from them have been recently re-reviewed to ensure if they were > correct or not. > > Upon review, this commit was found to be incorrect for the reasons > below, so it must be reverted. It will be fixed up "correctly" in a > later kernel change. > > The original change is NOT correct, as it does not correctly unwind from > the resources that was allocated before the call to > platform_driver_register(). > > Cc: Aditya Pakki > Cc: Sinan Kaya > Cc: Vinod Koul > Signed-off-by: Greg Kroah-Hartman > --- > drivers/dma/qcom/hidma_mgmt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c > index 806ca02c52d7..fe87b01f7a4e 100644 > --- a/drivers/dma/qcom/hidma_mgmt.c > +++ b/drivers/dma/qcom/hidma_mgmt.c > @@ -418,8 +418,9 @@ static int __init hidma_mgmt_init(void) > hidma_mgmt_of_populate_channels(child); > } > #endif > - return platform_driver_register(&hidma_mgmt_driver); > + platform_driver_register(&hidma_mgmt_driver); > > + return 0; > } > module_init(hidma_mgmt_init); > MODULE_LICENSE("GPL v2"); > Acked-By: Sinan Kaya