From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751172AbdHUFfB (ORCPT <rfc822;w@1wt.eu>);
        Mon, 21 Aug 2017 01:35:01 -0400
Received: from mail-pg0-f41.google.com ([74.125.83.41]:38457 "EHLO
        mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751010AbdHUFe7 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 21 Aug 2017 01:34:59 -0400
Subject: Re: [PATCH v3 4/5] perf annotate browser: Support --show-nr-samples
 option
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, taeung@kosslab.kr,
        Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>
References: <1503046023-5646-1-git-send-email-treeze.taeung@gmail.com>
 <20170818141740.GI10891@kernel.org>
From: Taeung Song <treeze.taeung@gmail.com>
Message-ID: <ca5862a6-8b91-5085-0bd6-397233f618a8@gmail.com>
Date: Mon, 21 Aug 2017 14:34:55 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170818141740.GI10891@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 08/18/2017 11:17 PM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Aug 18, 2017 at 05:47:03PM +0900, Taeung Song escreveu:
>> Cc: Namhyung Kim <namhyung@kernel.org>
>> Cc: Jiri Olsa <jolsa@redhat.com>
>> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> 
> Ok, now that check for !--stdio is lifted and replaced with:
> 
> -       if (symbol_conf.show_nr_samples && !annotate.use_stdio) {
> -               pr_err("--show-nr-samples is only available in --stdio mode at this time\n");
> +       if (symbol_conf.show_nr_samples && annotate.use_gtk) {
> +               pr_err("--show-nr-samples is not available in --gtk mode at this time\n");
>                  return ret;
>          }
> 
> - Arnaldo
> 

I got it :)

Thanks,
Taeung