From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFF5E14884C for ; Mon, 17 Nov 2025 16:31:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763397097; cv=none; b=WJ2pqiNGKVpEt/07u8tGE+JJXfNQcPiOhrMBogAvOtVOlYEvI8qIHZxDvnGkM1JCvVjDvAti15+V1V6XGh3U8NDTHLQIWfOP9ywdWRnRZPTZiNfD4vDxqVGanEPCO3XtZ7Kqiwwuc1s9D92argCtOOjahiZPlGbG+Qc/pNLiHII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763397097; c=relaxed/simple; bh=Znq+/Z8nJmMpZxFT0nLC9bWacA9xI7ZdyEOSDmaPHB8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A9KUOVj4xhKeKIYoJY+PysXKYdaVqGy8A4RLw0wQSUfU5M5LjupNA+IBuJtv3Gv2JywZtKF1/7TR6F796Oc2Jjws7CT2Wcsk+TBULLiMmv0/N2tZ/MtAzGuh6W/zWN7gsVsurs6X2gRtGhTYsRXt0gHFkNmreMBtnP5VVzBTCuA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N67PNVrv; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N67PNVrv" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-7bc0cd6a13aso2590952b3a.0 for ; Mon, 17 Nov 2025 08:31:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763397095; x=1764001895; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=oQb9o9kIvZYvCgg7VsyLSOUu+m0XVkdwUoPP5wNrJvo=; b=N67PNVrv6fZnOszEItCvXdGnoun9/u9HV5YWbEIEHXg3ce+ZQ5DE/9mR3isdChxC6P XNqzhcStzyG4Wsd6XuHCbyqh7L9mCbKhVWvynzGwawwtaFc/UXB4xIq+Uwl4oyW6q+an nKnZI+63Ozme5EngCCPmTDi//06Im2qroaYIUlDksFEISausLlJWe4C69HZzYscc+zsF CU8rJKVD2OHhUcr4bnlKGPY+eOFQZrs+JAP1xnZNrgnJDC4AgNGxb26GpMlgOgcP02Dx WwoKF2GsJRvMaZd9dC3O9MUOY+D7QpDaLYqUq754OUQyb4uJVuJTu+4Xl53GCY23vDkV TfMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763397095; x=1764001895; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oQb9o9kIvZYvCgg7VsyLSOUu+m0XVkdwUoPP5wNrJvo=; b=E75MEbt+ug57hcBW0o6fskwatfIAvFWzhnBgZvlL1JqrZNnRVLEeBFOLIK5sjcXOfG GvZJiBphLieZR9PJzl4Lcr4rWPDw8xGPHbO4EmcE+oc6FlPJD1CBvZl7lM9zW6gvN7u1 eDwLrgzKITAdTyOwoS7x1hOYocPMrImNpAQ8OTyvvcHixUAkiPNRsPf8HRabAasvNeWZ xbSEm/Qq/SomHBGeJ/V/ZAM8Lo/LpudZ0PwkB5vjG4k6yenOI1AYWqufhRIFvIAJUlio 34mUcY4qwN2I2j55kMuuuyh//uHyohFCY0VtKo3dsKNy1NVefbvj6/+bAC1NI8zjwoqN QmMQ== X-Forwarded-Encrypted: i=1; AJvYcCV4ltkpIzM88cn/uybJhjGZ1ADNheNP1B6kd28eCxf/P5WmhCRBUe3ESnnGZX4e54ReAffzp+u2ewiWT14=@vger.kernel.org X-Gm-Message-State: AOJu0Yxx0IniT9ZZd3YHc7246OB5B+Y34rr3dplm2kjzsYq2Nd0jQtx7 TRXYuUN1FZrTjHrWzoscWPH9uvIcXwHu1wQDNXQGKW9RQf/kqcV89SWb X-Gm-Gg: ASbGnct4F2f6eFByyOMDnMJ+XvOk3t4YIvTV60THEOphDXa019XFFEzZRJObcewHJ0m hgpFeRhm6QcMEMTSQqmp0ryHPzRl63Uls7poPUoc+NYUBlnpD1UMUysTizQ1SKimRo3sjImk8Zi 6kYaidA8djBdYaJYREpYThilX0XRQMm7+JtbVK/e90wLvKOAoZvR5e1/yp3344CpGuGFWSLEJDw 1h5LvlF+AZXnM3qRWHOKQ1nYLRJdd6cjkY3sSxw6LJ8sEaWdkviLffDLETecAli/RPAD2fUANqO 2irNajOHlUU1zIIlRm79oq3SNR88JRwt6kJ0Mq9Sloxb+zYDi7NcFyaXwxQAJ1YqixojP/pW8ve CzTpVVOeYgZPzeilMJThfI2yJAOHbBLjWygEv6LfKIbkGqBq6ElAYBHb5CKhCaqi2d98NKUtQKo Sie2f1yFKzEDTKrlraMNVd9P5LLYQrt4yFA9xOh0lnGudO7cCr X-Google-Smtp-Source: AGHT+IHpJ4uDX4lpjeUvZTRjQRuO+qDaoDfLEprlbIpsQTNE4U11y2mfk8cVtEQcIR3O0NkkEfOikw== X-Received: by 2002:a05:6a20:3d0e:b0:341:2c7b:ed13 with SMTP id adf61e73a8af0-35b9ff89fe5mr14987202637.5.1763397094920; Mon, 17 Nov 2025 08:31:34 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7b927c22b1bsm13550393b3a.66.2025.11.17.08.31.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 08:31:34 -0800 (PST) Sender: Guenter Roeck Message-ID: Date: Mon, 17 Nov 2025 08:31:32 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] hwmon: documentation: add tids To: Thomas Marangoni , linux-hwmon@vger.kernel.org Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, corbet@lwn.net, Jonathan.Cameron@huawei.com, Frank.Li@nxp.com, michal.simek@amd.com, rodrigo.gobbi.7@gmail.com, chou.cosmo@gmail.com, wenswang@yeah.net, nuno.sa@analog.com, paweldembicki@gmail.com, apokusinski01@gmail.com, eajames@linux.ibm.com, vassilisamir@gmail.com, heiko@sntech.de, neil.armstrong@linaro.org, prabhakar.mahadev-lad.rj@bp.renesas.com, kever.yang@rock-chips.com, mani@kernel.org, dev@kael-k.io, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20251117123809.47488-1-Thomas.Marangoni@becom-group.com> <20251117123809.47488-3-Thomas.Marangoni@becom-group.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20251117123809.47488-3-Thomas.Marangoni@becom-group.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/17/25 04:38, Thomas Marangoni wrote: > Add tids driver documentation > --- > Documentation/hwmon/tids.rst | 61 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/hwmon/tids.rst > > diff --git a/Documentation/hwmon/tids.rst b/Documentation/hwmon/tids.rst > new file mode 100644 > index 000000000000..f3fea4e416ea > --- /dev/null > +++ b/Documentation/hwmon/tids.rst > @@ -0,0 +1,61 @@ > +.. SPDX-License-Identifier: GPL-2.0 > + > +Kernel driver tids > +=================== > + > +Supported Chips: > + > + * WSEN TIDS > + > + Prefix: 'tids' > + > + Addresses scanned: None > + > + Datasheet: > + > + English: https://www.we-online.com/components/products/manual/Manual-um-wsen-tids-2521020222501%20(rev1.2).pdf > + > +Author: Thomas Marangoni > + > + > +Description > +----------- > + > +This driver implements support for the WSEN TIDS chip, a temperature > +sensor. Temperature is measured in degree celsius. In sysfs interface, > +all values are scaled by 1000, i.e. the value for 31.5 degrees celsius is 31500. > + > +Usage Notes > +----------- > + > +The device communicates with the I2C protocol. Sensors can have the I2C > +address 0x38 or 0x3F. See Documentation/i2c/instantiating-devices.rst for methods > +to instantiate the device. > + > +Sysfs entries > +------------- > + > +=============== ============================================ > +temp1_input Measured temperature in millidegrees Celsius > +update_interval The interval for polling the sensor, in > + milliseconds. Writable. Must be 5, 10, 20 > + or 40. As mentioned in the driver feedback, this should be more generous and say something like "Supported values are 5, 10, 20, or 40". > +temp1_max_hyst The temperature in millidegrees Celsius, that > + is triggering the temp1_max_alarm. Writable. > + The lowest possible value is -39680 and the As above, s/possible/supported/. We don't usually expect users to know supported value ranges for update intervals or temperature limits. > + highest possible value is 122880. Values are > + saved in steps of 640. > +temp1_min_hyst The temperature in millidegrees Celsius, that > + is triggering the temp1_min_alarm. Writable. > + The lowest possible value is -39680 and the > + highest possible value is 122880. Values are > + saved in steps of 640. As mentioned in the driver feedback, I think those should be temp1_max and temp1_min. I see no evidence that those are hysteresis values, and the description here and in the datasheet confirms this. > +temp1_max_alarm The alarm will be triggered when the level > + reaches the value specified in > + temp1_max_hyst. It will reset automatically > + once it has been read. > +temp1_min_alarm The alarm will be triggered when the level > + reaches the value specified in > + temp1_min_hyst. It will reset automatically > + once it has been read. > +=============== ============================================