From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>, x86@kernel.org
Cc: dwmw@amazon.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86,kvm/xen: Remove superfluous .fixup usage
Date: Mon, 24 Jan 2022 14:53:13 +0100 [thread overview]
Message-ID: <ca66ba8d-63dd-7087-7d5b-b42ccf8debd7@redhat.com> (raw)
In-Reply-To: <20220123124219.GH20638@worktop.programming.kicks-ass.net>
On 1/23/22 13:42, Peter Zijlstra wrote:
>
> Commit 14243b387137 ("KVM: x86/xen: Add KVM_IRQ_ROUTING_XEN_EVTCHN and
> event channel delivery") adds superfluous .fixup usage after the whole
> .fixup section was removed in commit e5eefda5aa51 ("x86: Remove .fixup
> section").
>
> Fixes: 14243b387137 ("KVM: x86/xen: Add KVM_IRQ_ROUTING_XEN_EVTCHN and event channel delivery")
> Reported-by: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
> arch/x86/kvm/xen.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/arch/x86/kvm/xen.c b/arch/x86/kvm/xen.c
> index 0e3f7d6e9fd7..bad57535fad0 100644
> --- a/arch/x86/kvm/xen.c
> +++ b/arch/x86/kvm/xen.c
> @@ -316,10 +316,7 @@ int __kvm_xen_has_interrupt(struct kvm_vcpu *v)
> "\tnotq %0\n"
> "\t" LOCK_PREFIX "andq %0, %2\n"
> "2:\n"
> - "\t.section .fixup,\"ax\"\n"
> - "3:\tjmp\t2b\n"
> - "\t.previous\n"
> - _ASM_EXTABLE_UA(1b, 3b)
> + _ASM_EXTABLE_UA(1b, 2b)
> : "=r" (evtchn_pending_sel),
> "+m" (vi->evtchn_pending_sel),
> "+m" (v->arch.xen.evtchn_pending_sel)
> @@ -335,10 +332,7 @@ int __kvm_xen_has_interrupt(struct kvm_vcpu *v)
> "\tnotl %0\n"
> "\t" LOCK_PREFIX "andl %0, %2\n"
> "2:\n"
> - "\t.section .fixup,\"ax\"\n"
> - "3:\tjmp\t2b\n"
> - "\t.previous\n"
> - _ASM_EXTABLE_UA(1b, 3b)
> + _ASM_EXTABLE_UA(1b, 2b)
> : "=r" (evtchn_pending_sel32),
> "+m" (vi->evtchn_pending_sel),
> "+m" (v->arch.xen.evtchn_pending_sel)
>
Queued, thanks.
Paolo
next prev parent reply other threads:[~2022-01-24 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 12:42 Peter Zijlstra
2022-01-24 13:53 ` Paolo Bonzini [this message]
2022-01-27 9:40 ` [EXTERNAL] " David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca66ba8d-63dd-7087-7d5b-b42ccf8debd7@redhat.com \
--to=pbonzini@redhat.com \
--cc=dwmw@amazon.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®