mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wei Deng <wei.deng@oss.qualcomm.com>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, quic_jiaymao@quicinc.com,
	Konrad Dybcio <konradybcio@kernel.org>,
	linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
	cheng.jiang@oss.qualcomm.com, devicetree@vger.kernel.org,
	Bjorn Andersson <andersson@kernel.org>,
	quic_shuaz@quicinc.com, quic_chezhou@quicinc.com
Subject: Re: [PATCH] arm64: dts: qcom: monaco-evk: Enable Bluetooth support
Date: Tue, 18 Nov 2025 15:07:13 +0800	[thread overview]
Message-ID: <ca6b02d8-07cc-4bc9-ac99-e75d8e3548fe@oss.qualcomm.com> (raw)
In-Reply-To: <CAL_JsqJX3doLFv-Nc6o+L1W_o8VjtvGp9dqdpsotuyG17zU7Lw@mail.gmail.com>

Hi Rob,

Thanks for your comments.

On 11/15/2025 12:18 AM, Rob Herring wrote:
> On Fri, Nov 14, 2025 at 10:06 AM Rob Herring (Arm) <robh@kernel.org> wrote:
>>
>>
>> On Thu, 13 Nov 2025 18:35:19 +0530, Wei Deng wrote:
>>> There's a WCN6855 WiFi/Bluetooth module on an M.2 card. To make
>>> Bluetooth work, we need to define the necessary device tree nodes,
>>> including UART configuration and power supplies.
>>>
>>> Since there is no standard M.2 binding in the device tree at present,
>>> the PMU is described using dedicated PMU nodes to represent the
>>> internal regulators required by the module.
>>>
>>> The module provides a 3.3V supply, which originates from the
>>> main board’s 12V rail. To represent this power hierarchy in the device
>>> tree, add a fixed 12V regulator node as the DC-IN source and link it
>>> to the 3.3V regulator node.
>>>
>>> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
>>> ---
>>>  arch/arm64/boot/dts/qcom/monaco-evk.dts | 99 +++++++++++++++++++++++++
>>>  1 file changed, 99 insertions(+)
>>>
>>
>>
>> My bot found new DTB warnings on the .dts files added or changed in this
>> series.
>>
>> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
>> are fixed by another series. Ultimately, it is up to the platform
>> maintainer whether these warnings are acceptable or not. No need to reply
>> unless the platform maintainer has comments.
>>
>> If you already ran DT checks and didn't see these error(s), then
>> make sure dt-schema is up to date:
>>
>>   pip3 install dtschema --upgrade
>>
>>
>> This patch series was applied (using b4) to base:
>>  Base: attempting to guess base-commit...
>>  Base: tags/next-20251112 (exact match)
>>  Base: tags/next-20251112 (use --merge-base to override)
>>
>> If this is not the correct base, please add 'base-commit' tag
>> (or use b4 which does this automatically)
>>
>> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20251113130519.2647081-1-wei.deng@oss.qualcomm.com:
>>
>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcielp3-supply', 'vddpcielp9-supply' do not match any of the regexes: '^pinctrl-[0-9]+$'
>>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcie1p3-supply' is a required property
>>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcie1p9-supply' is a required property
>>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
> 
> This is the 3rd report of your typos. Is there some reason you are
> ignoring the reports?
> 

Sorry for the delayed response. These warnings are worth addressing 
and will be resolved in the next patch.

> Rob

-- 
Best Regards,
Wei Deng


  reply	other threads:[~2025-11-18  7:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13 13:05 Wei Deng
2025-11-13 20:15 ` Dmitry Baryshkov
2025-11-14 15:58 ` Rob Herring (Arm)
2025-11-14 16:18   ` Rob Herring
2025-11-18  7:07     ` Wei Deng [this message]
2025-11-18  7:19       ` Krzysztof Kozlowski
2025-11-18 13:24         ` Wei Deng
2025-11-18 14:12           ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca6b02d8-07cc-4bc9-ac99-e75d8e3548fe@oss.qualcomm.com \
    --to=wei.deng@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=cheng.jiang@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_chezhou@quicinc.com \
    --cc=quic_jiaymao@quicinc.com \
    --cc=quic_shuaz@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®