mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xiaoming Ni <nixiaoming@huawei.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	"Russell King - ARM Linux admin" <linux@armlinux.org.uk>
Cc: <dima@arista.com>, <will@kernel.org>, <jpoimboe@redhat.com>,
	<akpm@linux-foundation.org>, <christian.brauner@ubuntu.com>,
	<viro@zeniv.linux.org.uk>, <ldufour@linux.ibm.com>,
	<amanieu@gmail.com>, <walken@google.com>,
	<ben.dooks@codethink.co.uk>, <tglx@linutronix.de>,
	<mingo@kernel.org>, <vincent.whitchurch@axis.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <wangle6@huawei.com>,
	<luohaizheng@huawei.com>
Subject: Re: [PATCH] arm:traps: Don't print stack or raw PC/LR values in backtraces
Date: Fri, 9 Oct 2020 16:58:42 +0800	[thread overview]
Message-ID: <ca6d4c91-2059-8325-8622-1445e15bc0b9@huawei.com> (raw)
In-Reply-To: <20201009081820.jargnmck6zfkzegx@linutronix.de>

On 2020/10/9 16:18, Sebastian Andrzej Siewior wrote:
> On 2020-10-09 09:08:50 [+0100], Russell King - ARM Linux admin wrote:
>> I am really not happy about this - it hurts at least my ability to
>> debug the kernel when people post oopses to the mailing list. If

In the reset scenario, dump_mem is retained:

@@ -125,6 +118,9 @@ static void dump_mem(const char *lvl, const char 
*str, unsigned long bottom,
         mm_segment_t fs;
         int i;

+ /* Do not print virtual addresses in non-reset scenarios */
+ if (!panic_on_oops)
+         return;


>> people wish to make the kernel harder to debug, and are prepared
>> to be told "your kernel is undebuggable" then this patch is fine.
> 
> I haven't look at the patch but don't they keep/add the representation:
>    PC: symbol+offset/size
>    LR: symbol+offset/size
> 
> ? This is needed at very least as a replacement for the missing address.

Yes, only %08lx was deleted, but %ps is still retained.

-	printk("%s[<%08lx>] (%ps) from [<%08lx>] (%pS)\n",
-		loglvl, where, (void *)where, from, (void *)from);
+	printk("%s (%ps) from (%pS)\n",
+		loglvl, (void *)where, (void *)from);

Thanks
Xiaoming Ni


  reply	other threads:[~2020-10-09  8:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09  7:59 Xiaoming Ni
2020-10-09  8:08 ` Russell King - ARM Linux admin
2020-10-09  8:18   ` Sebastian Andrzej Siewior
2020-10-09  8:58     ` Xiaoming Ni [this message]
2020-10-11 21:32     ` Russell King - ARM Linux admin
2020-10-12  2:23       ` Xiaoming Ni
2020-10-12 10:03       ` Sebastian Andrzej Siewior
2020-10-12 11:06         ` Russell King - ARM Linux admin
2020-10-10 17:55   ` Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca6d4c91-2059-8325-8622-1445e15bc0b9@huawei.com \
    --to=nixiaoming@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=amanieu@gmail.com \
    --cc=ben.dooks@codethink.co.uk \
    --cc=bigeasy@linutronix.de \
    --cc=christian.brauner@ubuntu.com \
    --cc=dima@arista.com \
    --cc=jpoimboe@redhat.com \
    --cc=ldufour@linux.ibm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=luohaizheng@huawei.com \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vincent.whitchurch@axis.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=walken@google.com \
    --cc=wangle6@huawei.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®