From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>,
Rob Herring <robh@kernel.org>,
sudeep.holla@arm.com, cristian.marussi@arm.com,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linus.walleij@linaro.org, Oleksii_Moisieiev@epam.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [RFC 4/4] dt-bindings: gpio: Add bindings for SCMI pinctrl based gpio
Date: Tue, 3 Oct 2023 10:43:31 +0200 [thread overview]
Message-ID: <ca6f8f30-c305-42bf-a812-b43561c4da2b@linaro.org> (raw)
In-Reply-To: <ZRtjVnWhAK2CZaRM@octopus>
On 03/10/2023 02:41, AKASHI Takahiro wrote:
> Hi Rob,
>
> On Mon, Oct 02, 2023 at 09:41:55AM -0500, Rob Herring wrote:
>> On Mon, Oct 02, 2023 at 11:16:02AM +0900, AKASHI Takahiro wrote:
>>> A dt binding for SCMI pinctrl based gpio driver is defined in this
>>> commit. It basically conforms to generic pinctrl-gpio mapping framework.
>>
>> What is "generic pinctrl-gpio mapping framework"? DT doesn't have
>> frameworks.
>
> I meant to refer to section 2.1-2.3 in "Documentation/devicetree/bindings/gpio/gpio.txt". The semantics is implemented in drivers/gpio/gpiolib(-of).c.
Linux specific GPIO library is as well outside of DT scope. Please focus
here on hardware, not Linux specifics.
>
>>>
>>> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
>>> ---
>>> .../bindings/gpio/arm,scmi-gpio.yaml | 71 +++++++++++++++++++
>>> 1 file changed, 71 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/gpio/arm,scmi-gpio.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/gpio/arm,scmi-gpio.yaml b/Documentation/devicetree/bindings/gpio/arm,scmi-gpio.yaml
>>> new file mode 100644
>>> index 000000000000..2601c5594567
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/gpio/arm,scmi-gpio.yaml
>>> @@ -0,0 +1,71 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/gpio/arm,scmi-gpio.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: SCMI pinctrl based generic GPIO controller
>>> +
>>> +maintainers:
>>> + - AKASHI Takahiro <akashi.takahiro@linaro.org>
>>> +
>>> +properties:
>>> + $nodename:
>>> + pattern: "^scmi_gpio(@[0-9a-f]+)$"
>>
>> Not the correct name.
>
> How not?
Underscores are no allowed and are pointed by dtc (W=2). scmi is
redundant here, because names should be generic. Anyway, we do not add
node name requirements to device schema.
>
>>> +
>>> + compatible:
>>> + const: arm,scmi-gpio-generic
>>
>> What makes it generic? No such thing. Just drop '-generic'.
>
> I will discuss this issue in following Cristian's comment.
>
>>
>>> +
>>> + gpio-controller: true
>>> +
>>> + "#gpio-cells":
>>> + const: 2
>>> +
>>> + gpio-ranges: true
>>> +
>>> + gpio-ranges-group-names: true
>>> +
>>> +patternProperties:
>>> + "^.+-hog(-[0-9]+)?$":
>>> + type: object
>>> + properties:
>>> + gpio-hog: true
>>> + gpios: true
>>> + input: true
>>> + output-high: true
>>> + output-low: true
>>> + line-name: true
>>> +
>>> + required:
>>> + - gpio-hog
>>> + - gpios
>>
>> You don't need all this just 'required: [ gpio-hog ]'. Then the hog
>> schema will check the rest.
>
> Okay.
>
>>> +
>>> + additionalProperties: false
>>> +
>>> +required:
>>> + - compatible
>>> + - gpio-controller
>>> + - "#gpio-cells"
>>> + - gpio-ranges
>>> +
>>> +additionalProperties: false
>>> +
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/gpio/gpio.h>
>>> +
>>> + scmi_gpio_0: scmi_gpio@0 {
>>
>> gpio {
>>
>> But doesn't SCMI have protocol numbers?
>>
>>> + compatible = "arm,scmi-gpio";
>>> + gpio-controller;
>>> + #gpio-cells = <2>;
>>> + gpio-ranges = <&scmi_pinctrl 0 10 5>,
>>> + <&scmi_pinctrl 5 0 0>;
>>> + gpio-ranges-group-names = "",
>>> + "pinmux_gpio";
>>> + };
>>> +
>>> + // Consumer:
>>
>> Outside the scope of this binding. Drop this node.
>
> Even though it's in an example?
> "#gpio-cells" has a meaning in consumer side.
Just look at any other bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-03 8:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 2:15 [RFC 0/4] gpio: add SCMI pinctrl based driver AKASHI Takahiro
2023-10-02 2:15 ` [RFC 1/4] pinctrl: define PIN_CONFIG_INPUT AKASHI Takahiro
2023-10-03 20:49 ` Linus Walleij
2023-10-04 6:54 ` AKASHI Takahiro
2023-10-02 2:16 ` [RFC 2/4] pinctrl: add pinctrl_gpio_get_config() AKASHI Takahiro
2023-10-03 20:52 ` Linus Walleij
2023-10-02 2:16 ` [RFC 3/4] gpio: scmi: add SCMI pinctrl based gpio driver AKASHI Takahiro
2023-10-03 21:35 ` Linus Walleij
2023-10-04 6:53 ` AKASHI Takahiro
2023-10-04 8:35 ` Linus Walleij
2023-10-05 2:42 ` AKASHI Takahiro
2023-10-02 2:16 ` [RFC 4/4] dt-bindings: gpio: Add bindings for SCMI pinctrl based gpio AKASHI Takahiro
2023-10-02 3:25 ` Rob Herring
2023-10-02 14:41 ` Rob Herring
2023-10-02 14:58 ` Cristian Marussi
2023-10-03 1:34 ` AKASHI Takahiro
2023-10-03 0:41 ` AKASHI Takahiro
2023-10-03 8:43 ` Krzysztof Kozlowski [this message]
2023-10-03 13:16 ` Linus Walleij
2023-10-04 7:08 ` AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca6f8f30-c305-42bf-a812-b43561c4da2b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Oleksii_Moisieiev@epam.com \
--cc=conor+dt@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=takahiro.akashi@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®