From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6928918C35F; Mon, 29 Jul 2024 21:51:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722289879; cv=none; b=ByMW1wQrXYkjyA+6zhbm3wubcJzNvSYaHi3+lkEcw6Lj6NESTFe3sT01d+NeQhcfIWcM8iAIk/kkhLjkkRC94d+z4N8oatfQW9qSmK8H+jzMWWfChXrMuo7l5k3wdtCmsBx2UT7+wpUG7fqNAzs+vA7ik6sVSxmG5Yk29EkjIDY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722289879; c=relaxed/simple; bh=LrWqnISsEK8XrCpLK4+pJridYRM/C8H1gnw5Ws+3Xps=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i6BpgVn4lMFOFIERMbri6O/MtOyNHVe7uk3IUgeUa75Hr2JNhqnVfl8TjYfATXABdpNHhW/frIdef5wwhn1t82+/YT9QHyG3yEG97xUYiRskHi53A/COoZsXDULnLaki76v6M2k2NwQ30GfhJzKMiYnSjCz4GpkVu1BwMRN2lgk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EozVifsP; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EozVifsP" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-70d2b921c48so2820229b3a.1; Mon, 29 Jul 2024 14:51:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722289876; x=1722894676; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=HpKFNPu/eyMggjx9nIejJskxEf3iq1M/LEytVjF0bmE=; b=EozVifsP+HsIPdK5vduJ4uC1ALZT73yAAtXjYMQRKUZIXvDS4SmoqC8L5ceBxCMGzc fhbPCkEAb9Hbxsi6aROTCtKnl7uI157ASuUz8wXS6I09WH0OAUFXi9tXhU5m/yJK2vSP v9CW7Ud5yyLdKk4FNWLNyrGdnpFlBTT8uqJjDkvvpWDG78HY4UDjSo4IXeGJncJkOLtL eadEpwWMQg5R612YaELx5XvdA8owL70V1VW9B3N3xNOQLd4IOEV4H1H775/z+pRxunT4 HWx1pTJ9HkP0v5MpsmegUnR3lUSPtv6bKF7LpLzLUcsztC42yz8gTvIcEmemXOFqQXhj aXTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722289876; x=1722894676; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HpKFNPu/eyMggjx9nIejJskxEf3iq1M/LEytVjF0bmE=; b=HqKCat05tAreMAllBd9DEksVVuYi7wwGdqccSonqzZrDf7Y/b7uEZNdS1Cq98XDRlJ oEciDGg9DgogQJ9vwN/K8760j2tt2olyWSGdL0btZuy/djEc1RkGMErWE0Sct3HLhUbm tdfZv00dU3su0bmZi/cwk0BA8nMryWiucxo6aKesRcPTAWAja3Ituew94qOcGQ+P9Aog Z899mxtU5ms5BIeFSjB9/AZrVjwhbFmqpUv40/aN7h1+Nm9QJk5vbu0WZr8NRf8YVL+T AQywV6NbVLSI5z6Jxk3WPQheEBwcq3xKYYcwV3p/5QL12AqMTcB9BwS30jWkrs8hn133 WOaA== X-Forwarded-Encrypted: i=1; AJvYcCVM2V6NWeZ2GQlsTubgmMh8wq/pzW1uc6lgiYfNtRFtn7pPSrtGj6zCl0lb+fpxsm32hOJpAANbZm0GwvtMvrwL+Q2nuaIZ6NPfUdVLVJJpW3KjyftSGX1L18ztmGSz8Fi7Zqzsh5Q6hTLRYyg= X-Gm-Message-State: AOJu0YyF6+B1i1RX35ms4ekZ/Fvcx2jA7Yp7Aajm6nbz9H4f996VtfmS MPJSPSxrxNrHgYnIVzWqGn7rgvbdR1cZ7f1U9z/2xhdikyRiUmx/ X-Google-Smtp-Source: AGHT+IFdoeF4n/4YIqBvowTatVW1tarAT1SSgsixYzO9oJIPThavqzeT2b87gN+FXSmK7pl8YlOz6g== X-Received: by 2002:a05:6a00:b88:b0:70a:efd7:ada1 with SMTP id d2e1a72fcca58-70ecea3fd57mr7470387b3a.17.1722289875450; Mon, 29 Jul 2024 14:51:15 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead8aa702sm7223969b3a.215.2024.07.29.14.51.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jul 2024 14:51:14 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Mon, 29 Jul 2024 14:51:13 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/1] watchdog: imx7ulp_wdt: move post_rcs_wait into struct imx_wdt_hw_feature To: Frank Li , Christophe JAILLET Cc: alice.guo@nxp.com, festevam@gmail.com, imx@lists.linux.dev, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org, wim@linux-watchdog.org, ye.li@nxp.com References: <20240729200601.1995387-1-Frank.Li@nxp.com> <716b9d31-f978-4384-b605-64896f8b2643@wanadoo.fr> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/29/24 14:16, Frank Li wrote: > On Mon, Jul 29, 2024 at 11:12:13PM +0200, Christophe JAILLET wrote: >> Le 29/07/2024 à 22:06, Frank Li a écrit : >>> Move post_rcs_wait into struct imx_wdt_hw_feature to simple code logic for >>> difference compatible string. >>> >>> i.MX93 watchdog needn't wait 2.5 clocks after RCS is done. So needn't set >>> post_rcs_wait. >>> >>> Reviewed-by: Guenter Roeck >>> Signed-off-by: Alice Guo >>> Reviewed-by: Ye Li >>> Signed-off-by: Frank Li >>> --- >>> Chagne from v3 to v4: >>> - Go back to v2 according to Guenter's feedback >>> Change from v2 to v3: >>> - Set post_rcs_wait to false explicitly to maintain code consistency >>> - Add Guenter review tag. >>> Change from v1 to v2: >>> - Combine to one patch >>> --- >>> drivers/watchdog/imx7ulp_wdt.c | 21 +++++++++------------ >>> 1 file changed, 9 insertions(+), 12 deletions(-) >>> >>> diff --git a/drivers/watchdog/imx7ulp_wdt.c b/drivers/watchdog/imx7ulp_wdt.c >>> index 94914a22daff7..3a75a6f98f8f0 100644 >>> --- a/drivers/watchdog/imx7ulp_wdt.c >>> +++ b/drivers/watchdog/imx7ulp_wdt.c >>> @@ -55,6 +55,7 @@ MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default=" >>> struct imx_wdt_hw_feature { >>> bool prescaler_enable; >>> + bool post_rcs_wait; >>> u32 wdog_clock_rate; >>> }; >>> @@ -62,7 +63,6 @@ struct imx7ulp_wdt_device { >>> struct watchdog_device wdd; >>> void __iomem *base; >>> struct clk *clk; >>> - bool post_rcs_wait; >>> bool ext_reset; >>> const struct imx_wdt_hw_feature *hw; >>> }; >>> @@ -95,7 +95,7 @@ static int imx7ulp_wdt_wait_rcs(struct imx7ulp_wdt_device *wdt) >>> ret = -ETIMEDOUT; >>> /* Wait 2.5 clocks after RCS done */ >>> - if (wdt->post_rcs_wait) >>> + if (wdt->hw->post_rcs_wait) >>> usleep_range(wait_min, wait_min + 2000); >>> return ret; >>> @@ -334,15 +334,6 @@ static int imx7ulp_wdt_probe(struct platform_device *pdev) >>> /* The WDOG may need to do external reset through dedicated pin */ >>> imx7ulp_wdt->ext_reset = of_property_read_bool(dev->of_node, "fsl,ext-reset-output"); >>> - imx7ulp_wdt->post_rcs_wait = true; >>> - if (of_device_is_compatible(dev->of_node, >>> - "fsl,imx8ulp-wdt")) { >>> - dev_info(dev, "imx8ulp wdt probe\n"); >>> - imx7ulp_wdt->post_rcs_wait = false; >>> - } else { >>> - dev_info(dev, "imx7ulp wdt probe\n"); >>> - } >>> - >>> wdog = &imx7ulp_wdt->wdd; >>> wdog->info = &imx7ulp_wdt_info; >>> wdog->ops = &imx7ulp_wdt_ops; >>> @@ -403,6 +394,12 @@ static const struct dev_pm_ops imx7ulp_wdt_pm_ops = { >>> static const struct imx_wdt_hw_feature imx7ulp_wdt_hw = { >>> .prescaler_enable = false, >>> .wdog_clock_rate = 1000, >>> + .post_rcs_wait = true, >>> +}; >>> + >>> +static const struct imx_wdt_hw_feature imx8ulp_wdt_hw = { >>> + .prescaler_enable = false, >>> + .wdog_clock_rate = 1000, >>> }; >>> static const struct imx_wdt_hw_feature imx93_wdt_hw = { >>> @@ -411,7 +408,7 @@ static const struct imx_wdt_hw_feature imx93_wdt_hw = { >>> }; >>> static const struct of_device_id imx7ulp_wdt_dt_ids[] = { >>> - { .compatible = "fsl,imx8ulp-wdt", .data = &imx7ulp_wdt_hw, }, >>> + { .compatible = "fsl,imx8ulp-wdt", .data = &imx8ulp_wdt_hw, }, >> >> Nitpick: while touching something here, should imx8ulp be after imx7ulp? > > Yes, it should be better. > > Guenter: do you think it is okay to move it after 7ulp? > Sure Guenter > Frank > >> >> CJ >> >>> { .compatible = "fsl,imx7ulp-wdt", .data = &imx7ulp_wdt_hw, }, >>> { .compatible = "fsl,imx93-wdt", .data = &imx93_wdt_hw, }, >>> { /* sentinel */ } >>