From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f225.google.com (mail-qk1-f225.google.com [209.85.222.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0463A36167F for ; Fri, 7 Aug 2026 06:47:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.225 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786085233; cv=none; b=R8CsKJdYz9s2Fx1IvoJnJ9k8TDQu9X4SobnWPY4Gpi3iFSTWoeeCBZTPyNxCpONZ1cFnSX4PG2h8KO+X4rPEz2SVRbFbwywTSeHLXHHm7ELv+wxyjkhgMh4oEnse+e4fwizHuKoxZkZ7eVDMrrZmi8dUUtoSoG+09qAaZ9r913w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786085233; c=relaxed/simple; bh=9Y5CiBh9ejoquK6ooJ8B7lLV6zQMZFZZqfxbS+uFVnw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uPKmDAvG0esgQcM7adKapT84y87pglz4wX+2OJAuYqwS4zGfPz8YqkwrIqclfP/QTa3YrBEigdu+l6NQbHzL/ZxQLu85sWFVOtHWMyuu83OyyXpyQUbc2PGQ2YuP0YZp47GhL+2U8ingunJG14Kr/5pL7aas7Eo8/g3SPFrcNC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=OSYcUBQ6; arc=none smtp.client-ip=209.85.222.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="OSYcUBQ6" Received: by mail-qk1-f225.google.com with SMTP id af79cd13be357-930f618435cso203150785a.3 for ; Thu, 06 Aug 2026 23:47:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786085231; x=1786690031; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=k1nQYGrcGXQu2s20fusPuZGr3riqxpJDJFHLZrZqcfQ=; b=HtdZw1HN6qiDa0mQqIHWqYo8XTpjKucTZMg9CIaF+wXF3SmznorMZ0pwgIIxnvT8f4 caxW08p7eo7+Q4rDuepxj9p5Q1MZXI0AgbgCzb02g/tQtA9KtV7RQFZlo7a08fhAyUSF Roflzz64ejB1aT+BxGQMVllttg+eRMqPusZ0ksjoP/hrDqGGhfD1Vw65zxBr202HzVRL KcQN8zX/QtO3E4tpF7mRbcmXeIiTaJr54AWPXNdTentHaLIsFRxN1Fjgvjo8tS3zyKx1 hsnHHF5ZDKkeUH010DoKRcUBiUcjwD4sDL5XzT2mTEsvq3sjd7x7Oxn+Jnkx/i61RDl6 9R7w== X-Forwarded-Encrypted: i=1; AHgh+RpKVTL255qzx09OG7omKykGxVyb3jHGPZyrG/QunZXOf1eGol1Ga5jPeou6t5mhibqaMWGPuEisNNDQQEI=@vger.kernel.org X-Gm-Message-State: AOJu0YyZ2o9tuGCNb5jFS8kmZeiARfRm9GMscix5R6MwHn0JTPmKYtNO PZAKqlOR9JGJZiL1l2DHBcPG5vcW0xWOSYyAJpH2onsarTOJsSmlZlrX0ONdFbGOec8oX4if273 eNDry29R5MDQvMeKh0PiRPhTGps8zxuCW9YQX5wJRHFmNwelucY/1DnclIj2tOCq0KuL3iAIRjH NjNj418VYKawhXliq/5h9yv90jpP26IMT/lJMXo3ZYSLsmjqviT1zrStyB6EFeBJd5RJjhCoIcj oVpcalrS2DFOqYn1RUWIrOMxg== X-Gm-Gg: AR+sD13xTFvKtjuTJG9oDmt/KQnQp5m7UKh99Qn4m4XFE/rAQbd5j2eBM1vGAbR99rA 3gnj/ohxmAyCP4P60/3KK4tdc2qVkyShn5TpYnS04usKkvIectk+YcrR0MP9fojqk2CX34ZGFrE FQORZQ2J0U8cvgbPTI08WqL3shYbzrcZCx1+UhC2FriG7qqkvrEsSRJHsUsZeDVMU5abwNyF7Nv 0voeYPAy4sVUii2fdasejAmGkwXtCX8Ix9IyN/sQ++WgQqlg54Hrz7YShngQbvTFMQpWmQDBeLx 7XdeXzJD12GZtBuEWyvLvx2wWvXWd/awZoU8GgwhQweyregYoJMG6poh6R4dVlNM1xGuxVVGvjN a73zINJ/Em7suzG+/SbWm/zFgYJgkvDb3JdZa021GsEmAHLMWncz7zXhkRVBEJOvm5Le7h6deJx C1XmMKKXE9X46MT9Xp1vaBT93RH7eT4+RF1CS+BeU= X-Received: by 2002:a05:620a:aa03:b0:92e:4a4a:4478 with SMTP id af79cd13be357-936490c7bf6mr1784518685a.31.1786085230687; Thu, 06 Aug 2026 23:47:10 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-20.dlp.protect.broadcom.com. [144.49.247.20]) by smtp-relay.gmail.com with ESMTPS id af79cd13be357-9366e22af2bsm18742485a.3.2026.08.06.23.47.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Aug 2026 23:47:10 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-c15fed5653eso217785166b.2 for ; Thu, 06 Aug 2026 23:47:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1786085228; x=1786690028; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=k1nQYGrcGXQu2s20fusPuZGr3riqxpJDJFHLZrZqcfQ=; b=OSYcUBQ6Hc2DPUXFDDKcSONEbDeO7DTmKNXnSXwXzVal4LTXrlUNzGbqycHSS2mwad mk6bi9UuNurebVkEPBS4c6hCopOScb3zfe7ssBslpq2pSgmzr32ojgHiNPlyt3qgv4i0 k0L8LAqI6enKB0ZPEQ/+b4vQ1XtI85pnmtnmc= X-Forwarded-Encrypted: i=1; AHgh+Roc0xlQYuDYYfYuS1kwl6x36vZCg0r+kPIQdvg2I/fHPYOH6qAjbYgKaInt460/CaU1xmWMv1IViCKFvXA=@vger.kernel.org X-Received: by 2002:a17:906:ef01:b0:c20:2b23:71cc with SMTP id a640c23a62f3a-c20731e1113mr305062266b.10.1786085227698; Thu, 06 Aug 2026 23:47:07 -0700 (PDT) X-Received: by 2002:a17:906:ef01:b0:c20:2b23:71cc with SMTP id a640c23a62f3a-c20731e1113mr305058566b.10.1786085226844; Thu, 06 Aug 2026 23:47:06 -0700 (PDT) Received: from [192.168.178.26] (f215227.upc-f.chello.nl. [80.56.215.227]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2080a29a4csm15686666b.1.2026.08.06.23.47.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 23:47:06 -0700 (PDT) Message-ID: Date: Fri, 7 Aug 2026 08:47:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] wifi: brcmfmac: cyw: pass PMKID to firmware if present To: Bogdan Nicolae , Johannes Berg Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260807032209.447044-1-bogdan.nicolae@gmail.com> Content-Language: en-US From: Arend van Spriel In-Reply-To: <20260807032209.447044-1-bogdan.nicolae@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 07/08/2026 05:22, Bogdan Nicolae wrote: > Zero out auth_status on initialization. Otherwise, garbage will > leak from the stack to the firmware (when ssid is less than 32 bytes > and/or when params->pmkid is set). Then, pass the params->pmkid to the > firmware (without it, the firmware caches a garbage PMKID on successful > authentication and denies a subsequent association request that includes > the PMKID). > > Fixes: 66f909308a7c ("wifi: brcmfmac: cyw: support external SAE authentication in station mode") > Signed-off-by: Bogdan Nicolae > Acked-by: Arend van Spriel It looks good, but in patchwork it showed the patch could not be applied so I tried myself: $ patch -p1 < ~/Downloads/v5-wifi-brcmfmac-cyw-pass-PMKID-to-firmware-if-present.diff patching file drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c /usr/bin/patch: **** malformed patch at line 23: bphy_err(drvr, "External authentication failed: status=%d\n", Been staring at it and not seeing the problem. Also checkpatch is not complaining. Look at the hexdump and the last line was missing a space before the tabs, but that was not the issue. The plot thickens... > --- > v5: Fixed line length > 80 chars > v4: Fixed indentation > v3: Added Fixes, Cc: stable, and Acked-by tags Contrary to this there is no CC: stable tag in this patch. > v2: Split into a separate patch > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c > index 873754be5..2c59b5e57 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c > @@ -200,7 +200,7 @@ brcmf_cyw_external_auth(struct wiphy *wiphy, struct net_device *dev, > { > struct brcmf_if *ifp; > struct brcmf_pub *drvr; > - struct brcmf_auth_req_status_le auth_status; > + struct brcmf_auth_req_status_le auth_status = {}; > int ret = 0; > > brcmf_dbg(TRACE, "Enter\n"); > @@ -208,6 +208,8 @@ brcmf_cyw_external_auth(struct wiphy *wiphy, struct net_device *dev, It looks like you hand edited the patch but now the number of line is 9 and not 8. Not sure if Johannes wants to hand edit that, but it does apply once fixed. Let's wait for Johannes to reply. Regards, Arend > ifp = netdev_priv(dev); > drvr = ifp->drvr; > if (params->status == WLAN_STATUS_SUCCESS) { > + if (params->pmkid) > + memcpy(auth_status.pmkid, params->pmkid, > + WLAN_PMKID_LEN); > auth_status.flags = cpu_to_le16(BRCMF_EXTAUTH_SUCCESS); > } else { > bphy_err(drvr, "External authentication failed: status=%d\n", > -- > 2.55.0