From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 759033368B2 for ; Sat, 7 Mar 2026 23:27:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772926064; cv=none; b=JSCcCSO9ufWhXNdoKdMcl7Q9QXYLrtH7SlX7zw2fKHeJLzMTk8UEE1ardlYkfKfpNohdvlw5yPLTrucTKWMM9IHUwscTiWwFlpZsUaGmzrR0Ps9tfAq790gapm2XJY1q1+WaPi3sEyCzJubusCp5S0hhPbALkxyPcvQ2vDDey1Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772926064; c=relaxed/simple; bh=p5Vv0Aqz3jtbsT+EfqrUXimnSUtgcknjnNt7NUA2dh8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WsoO+hZf9aS/LHKXOv9skif6ocPCgZoSyw82xRCnWxQOqOjX9epCFSjl6AFsFxs4qB7iqQl5coob6uCkmQ0TtTGzBfMZtGg/5LDjodePsGgD7G9u1xJtxz5dtubgD4CsCtvDD8PuZSAKotphLXOgyCURezOOuss6+Pi2cnME5lU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=NzkBt+IS; arc=none smtp.client-ip=209.85.160.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="NzkBt+IS" Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-4138136f02eso3988126fac.2 for ; Sat, 07 Mar 2026 15:27:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1772926060; x=1773530860; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0GnJdhG5dPcNKz/714FaQVTOCUr58X47IDgpYtPFows=; b=NzkBt+ISFW/leGuCgKWpu9J/NEbeLiQF61A0BgaVOL2zWgzrgKWwDOTpzH8ghOgwDQ Jh215FxlxFCKYFCmoRjM1cGCV+ZhVTWWw4GUx2EBG3u7wqoKAXhsZgqzExmTm/d9NooZ MY6H/MkC2yRKZMUXHwgK/1gByQyvpONgqEkP6LNaCBE2yHmstsfusO0M0D77OD75RpKL u1H4NVQyGxuiLfYZo0bKrOYkh86nZSa0sWiCWsesEnOAC05dTQTIVQ2WPRLSsCwk6tDy J/xVGumreIbh1bt6qQ9EnG0DszuAlf7y7sDXi/aRGf2oXNDqa+lQzWJC3uGGz49I4KQp vlHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772926060; x=1773530860; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0GnJdhG5dPcNKz/714FaQVTOCUr58X47IDgpYtPFows=; b=ieGvQn+twDcwMe3P4stym8cn3tKQC7aYuNNpHkCDUbos4lu8zlb9yAahnQSvqJkHrO 8ma2IkmxAOXU1cIIObiR13ebxNMw4aFK2mzgby+jtbS66ZH2LHZJUAZ+WwU7MU8rFc5J yDxTXYmYSxt+ta4qGADo2a+kH0ZsN4jA5K/2n+riE55TKUp7D2O3QsE5VZMk65dsrIz0 YQoDj08cFrKASzfglHybFaqf9uLl1BepjXUq5jAME1TC5s+U1zLv7aOpFatUUG797EFr DpHgQ/vw5RrFS41OZWQfF2nVBy/THOArOxjrQtcBQmEj9DjK1Htz1Xki85xT0qp9qFe8 wDKg== X-Forwarded-Encrypted: i=1; AJvYcCVAnJ84oHUBOcVqOMAf+f2e+DSQqrGGNbUDrmTPoImCm0geKzhYASqm5s2dMcOOaX9BzjQY36a3wAmFU0k=@vger.kernel.org X-Gm-Message-State: AOJu0YziKS3yXkFSlyqnqdfgC0koTvWDQv0vlO9qlNnsp2fehv+SUtmt V8FKzvdd/9QbMZ9Om/65H8NIOO8/gupQxfkWWTqmycCEPX4TXIgOt03ZDSjkojEYfpY= X-Gm-Gg: ATEYQzwGBM+54Bk2V+qUAAGsP4RZxOUX9n8BWCN5jSotMmE08icCoxjWln3telDWC6P mIN11H0z1qLTzmwjESajMoT90rvABURtlUXAjS7erR8I5Na5597RR/KN/gzUauJUsqKuy/ht5q5 xC2ID4Mxq/5MBdNjZHHV3H4HBpXpf74wKRvBac9WvOJVWz+IF//U9pj3PvV2y2K0KpUNSz1YmGx iioTbOOym1Bc5E4kUvMFX9Vg3twlAcpClZRSm4oVnoZyT2IxQ5EmH2ln20iDuepSuF8/N1tIc1v 4OwzWLAk42CZVGxuH86cNxCraiFG1hGIOKZviZV4e4SVUevbm3Jx2dlxfpGu8/t1fHcEydoXz5e WS0zOdQeAmECwVwEpKD0kJWB3e3/h7RyRLqNFlDAsf14cqxzJAupaql7mMieO/H/AvegQExFYjE vP77KQT1ql7nQy7SS/JNzCtDVpz8OG/BzrxqAtlre6ZjWI5ulNvQLhl7QzRC8LM+1x+bNIxR0nj Q== X-Received: by 2002:a05:6871:5311:b0:417:1cd9:d382 with SMTP id 586e51a60fabf-4171cd9d7acmr567580fac.4.1772926060371; Sat, 07 Mar 2026 15:27:40 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:cccf:5174:fa72:c520? ([2600:8803:e7e4:500:cccf:5174:fa72:c520]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-416e67d9c9asm4800051fac.13.2026.03.07.15.27.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Mar 2026 15:27:38 -0800 (PST) Message-ID: Date: Sat, 7 Mar 2026 17:27:36 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/sitronix/st7586: fix bad pixel data due to byte swap To: Javier Martinez Canillas , David Lechner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Dmitry Baryshkov Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260228-drm-mipi-dbi-fix-st7586-byte-swap-v1-1-e78f6c24cd28@baylibre.com> <87cy1iv9zb.fsf@ocarina.mail-host-address-is-not-set> Content-Language: en-US From: David Lechner In-Reply-To: <87cy1iv9zb.fsf@ocarina.mail-host-address-is-not-set> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/5/26 4:36 AM, Javier Martinez Canillas wrote: > David Lechner writes: > >> Correctly set dbi->write_memory_bpw for the ST7586 driver. This driver >> is for a monochrome display that has an unusual data format, so the >> default value set in mipi_dbi_spi_init() is not correct simply because >> this controller is non-standard. >> >> Previously, we were using dbi->swap_bytes to make the same sort of >> workaround, but it was removed in the same commit that added >> dbi->write_memory_bpw, so we need to use the latter now to have the >> correct behavior. >> >> This fixes every 3 columns of pixels being swapped on the display. There >> are 3 pixels per byte, so the byte swap caused this effect. >> >> Fixes: df3fb27a74a4 ("drm/mipi-dbi: Make bits per word configurable for pixel transfers") >> Signed-off-by: David Lechner >> --- > > The patch looks good to me. > > Reviewed-by: Javier Martinez Canillas > I pushed this out with: dim push-branch drm-misc-fixes (It's been 5 years since I've done that, so hopefully I did it right - I followed the docs and it all seemed OK to me).