From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-op-o12.zoho.com (sender4-op-o12.zoho.com [136.143.188.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AA4F37EFF3; Thu, 27 Aug 2026 16:56:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.12 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787849781; cv=pass; b=bk03E5rhFuRJnNyfdhkH7YfVrX0zYfAwDck9KGXcx7FVUQKJ1zYaF7YsYqkgJfyHWE/ZPu2nlqubJosoIMoEA+7scHGO0MohTMCzLGD0daZFbdke5Hpkk+xdUmt+x8ihX/bTLT1929Zk41Oey2dqMEpUXKm3ZcC8cvYw0yVNwwQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787849781; c=relaxed/simple; bh=g085QIuW/RPpi7XOzVHapGAb7y2Bdr+tYpuspc8Gg0c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZfiDBvM1IOx4/4aih/jDqNaU4jMvXaViZ/uScUVjqJuAhuTem59OTx74wVEZXQgxpenMRevbO3Hoh0BoX73/rHpCPRzb8i/yRoh6ouKYzdh7cShwr4AGw8qqjENpgTWo2v1qkdia7bMKrTSyU0Q6we0yy914qYXQKWdnUBp1K8c= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=yoavmoshe.com; spf=pass smtp.mailfrom=yoavmoshe.com; dkim=pass (1024-bit key) header.d=yoavmoshe.com header.i=linux@yoavmoshe.com header.b=gKMIzWU2; arc=pass smtp.client-ip=136.143.188.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=yoavmoshe.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yoavmoshe.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=yoavmoshe.com header.i=linux@yoavmoshe.com header.b="gKMIzWU2" ARC-Seal: i=1; a=rsa-sha256; t=1787849735; cv=none; d=zohomail.com; s=zohoarc; b=WXMaM00TBSzjtx2SRRpFTDPC5kS6/EERPQ8V0QWwMnqgHBLc4YdDN6tEYOJv7AO1vcs/i/F3ZnEx+mlylgkOnswL4rLjOVcbgSx5igiNfryaxozBeEBKDfl9jmG4s/3HwymOWvzcrq1tIyiDQQSaH4J9gfTIzxE12exrFpUIuT8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787849735; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=g085QIuW/RPpi7XOzVHapGAb7y2Bdr+tYpuspc8Gg0c=; b=JpXDmv/OMBvJJorvex7b/PsZvaW5VuzYaRv5oZnN0KYYk5qdW4PEsh7DOJQUtzw3KkQCX0bCdUf8+ywkqe3zaCrFxnP5o48gaTMZYnCuWo023nidVr4ZNGgZ4hH/rikSkpB0JVgz3wTPHm/FK+fF13wHiMlcp8YFonTkOmgxggY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=yoavmoshe.com; spf=pass smtp.mailfrom=linux@yoavmoshe.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1787849735; s=zoho; d=yoavmoshe.com; i=linux@yoavmoshe.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=g085QIuW/RPpi7XOzVHapGAb7y2Bdr+tYpuspc8Gg0c=; b=gKMIzWU2Ms3HurNaOBG3rlIct4B6zJx3rifKMzpo6SidXA0RMSLyjcssVz9uiT5t geAvVLeaZ0PzsiPRZaow9/6wtbobuFDC3bKP/uZp8XzvsDtqssw1zE5+oFLBlE0X/rq jt8tVy34MVFQXQd839fKU/fYm1IzKop61/JtgEbM= Received: by mx.zohomail.com with SMTPS id 1787849730914735.4941175159562; Thu, 27 Aug 2026 09:55:30 -0700 (PDT) Message-ID: Date: Thu, 27 Aug 2026 18:55:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] ARM: imx: Fix suspend/resume crash with Clang CFI To: Nick Desaulniers , Yo'av Moshe Cc: Sami Tolvanen , Nathan Chancellor , Frank Li , Sascha Hauer , Russell King , Pengutronix Kernel Team , Fabio Estevam , Bill Wendling , Justin Stitt , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev, stable@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260718111340.159896-1-linux@yoavmoshe.com> <3046e60d-509f-471f-bd15-3ce78c87500b@yoavmoshe.com> <20260721180950.GA3684684@ax162> <180001f5-bddd-4e58-8442-f7ef3c979500@yoavmoshe.com> <7f273a08-b29c-4e15-b340-898b251efe57@yoavmoshe.com> <415ffa24-a30b-43b2-aa6a-a1cde3bd4ef0@yoavmoshe.com> <12a46993-82a5-4109-87fa-61b8fcf764aa@yoavmoshe.com> <91cb0f21-e78a-4931-b123-937c6a01592c@yoavmoshe.com> Content-Language: en-GB, sv-SE From: Yo'av Moshe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 2026-08-25 7:33 PM, Nick Desaulniers wrote: > I do think it's better, but probably still needs revision. All three suggestions worked great. cfi_type fits exactly in the struct's tail padding so I removed the ±8 arithmetic, cfi_get_func_hash() works as you suggested, and I've switched to SYM_TYPED_FUNC_START/SYM_FUNC_END. I only kept a small manual alignment pad before the macro, since it aligns the type hash but not the function entry itself — I'll include details in the v4 notes. Yo'av