From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752670AbdA3IxV (ORCPT ); Mon, 30 Jan 2017 03:53:21 -0500 Received: from foss.arm.com ([217.140.101.70]:33174 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752609AbdA3IxF (ORCPT ); Mon, 30 Jan 2017 03:53:05 -0500 Subject: Re: [PATCH v2 1/2] dt-bindings: arm,gic: Fix binding example for a virt-capable GIC To: Olof Johansson , Rob Herring References: <1485186974-13678-1-git-send-email-marc.zyngier@arm.com> <1485186974-13678-2-git-send-email-marc.zyngier@arm.com> <20170127203001.qvlgzzrh5hx2pykf@rob-hp-laptop> <20170129225129.GK3133@localhost> Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Jason Cooper , Mark Rutland , Tsahee Zidenberg , Antoine Tenart , Russell King , Beno?t Cousson , Tony Lindgren , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Shawn Guo , Sascha Hauer , Fabio Estevam , Santosh Shilimkar , Matthias Brugger , Simon Horman , Magnus Damm , Heiko Stuebner , Maxime Ripard , Chen-Yu Tsai , arm@kernel.org From: Marc Zyngier Organization: ARM Ltd Message-ID: Date: Mon, 30 Jan 2017 08:41:08 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170129225129.GK3133@localhost> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/01/17 22:51, Olof Johansson wrote: > On Fri, Jan 27, 2017 at 02:30:01PM -0600, Rob Herring wrote: >> On Mon, Jan 23, 2017 at 03:56:13PM +0000, Marc Zyngier wrote: >>> The joys of copy/paste: the example of a virtualization capable GIC >>> in the DT binding was wrong, and propagated to dozens of platforms. >>> By having a GICC region that is only 4kB (instead of 8kB), we >>> end-up not being able to access the GICC_DIR register which is on >>> the second page. >>> >>> Oh well. Let's fix the source of the crap before tackling individual >>> offenders. While we're at it, also fix the compatibility string to >>> mention "arm,gic-400", which is the name of the actual implementation >>> of the GICv2 spec. >> >> "While we're at it", code for should be in a separate patch. :) I >> wouldn't really care here, but you are not fixing anything... >> >>> >>> Acked-by: Tony Lindgren >>> Acked-by: Mark Rutland >>> Acked-by: Arnd Bergmann >>> Signed-off-by: Marc Zyngier >>> --- >>> Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt >>> index 5393e2a..a3d51ed 100644 >>> --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt >>> +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt >>> @@ -107,11 +107,11 @@ Required properties: >>> Example: >>> >>> interrupt-controller@2c001000 { >>> - compatible = "arm,cortex-a15-gic"; >>> + compatible = "arm,gic-400"; >> >> Which one is correct really depends on the platform. The A15 can have an >> internal or external (gic-400) GIC. The former string is correct for an >> A15 with an internal GIC. One such platform is Calxeda midway. >> >> Arguably, we should not have arm,gic-400 by itself, but have an SoC >> specific compatible in case it was integrated in interesting ways. > > Good point (and thanks for bringing it up). > > Marc, based on this; want to back the above out so we can apply the rest for > now, while you battle on the compatible details? :) Fair enough. I'll back that out, respin and resend. Thanks, M. -- Jazz is not dead. It just smells funny...