From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A19BAC433FE for ; Sat, 18 Dec 2021 09:09:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232492AbhLRJJJ (ORCPT ); Sat, 18 Dec 2021 04:09:09 -0500 Received: from szxga03-in.huawei.com ([45.249.212.189]:30138 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229757AbhLRJJH (ORCPT ); Sat, 18 Dec 2021 04:09:07 -0500 Received: from kwepemi500007.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4JGKjN6ypFz8vYQ; Sat, 18 Dec 2021 17:06:48 +0800 (CST) Received: from kwepemm600009.china.huawei.com (7.193.23.164) by kwepemi500007.china.huawei.com (7.221.188.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sat, 18 Dec 2021 17:09:05 +0800 Received: from [10.174.176.73] (10.174.176.73) by kwepemm600009.china.huawei.com (7.193.23.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sat, 18 Dec 2021 17:09:04 +0800 Subject: Re: [PATCH v5 0/2] cancel all throttled bios in del_gendisk() To: , , , CC: , , , References: <20211210083143.3181535-1-yukuai3@huawei.com> From: "yukuai (C)" Message-ID: Date: Sat, 18 Dec 2021 17:09:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20211210083143.3181535-1-yukuai3@huawei.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.176.73] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600009.china.huawei.com (7.193.23.164) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2021/12/10 16:31, Yu Kuai дµÀ: > If del_gendisk() is done when some io are still throttled, such io > will not be handled until the throttle is done, which is not > necessary. > > Changes in v2: > - move WARN_ON_ONCE() from throtl_rb_first() to it's caller > - merge some patches into one. > > Changes in v3: > - some code optimization in patch 1 > - hold queue lock to cancel bios in patch 2 > > Changes in v4: > - delete rcu_read_lock() and rcu_read_unlock() in patch 2 > > Changes in v5: > - add comment about rcu lock Friendly ping... > > Yu Kuai (2): > blk-throtl: move WARN_ON_ONCE() from throtl_rb_first() to it's caller > block: cancel all throttled bios in del_gendisk() > > block/blk-throttle.c | 75 ++++++++++++++++++++++++++++++++++++++++++-- > block/blk-throttle.h | 2 ++ > block/genhd.c | 2 ++ > 3 files changed, 76 insertions(+), 3 deletions(-) >