From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1130215165 for ; Wed, 22 Jan 2025 16:47:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737564447; cv=none; b=LRVSMWo8PTELCY1jHfOMOvwjRwqrVJFUfY38uRx2dkZTj+Xc36Nr87sDd3CUPl/A1dMjQgDDGk/7/zGnkh3UbB9RSO7kbSoM8vuM56ZaKPN2gPKf/aZOJuAvPLp+wLlY1XLFxEcCFrlkuovxjqbg/SCQFLOp2FdpER3xSpbDAFI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737564447; c=relaxed/simple; bh=E2//rgTIluA10/JpvJzNsDpQWnlRUgYdqqiql0a8aOs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tGnCmJyW/r9I4asQUnxpe8QtvYVmBTG9TD+kEAYuLw+fv6Ryw05lNzM/MODAWkzfvpCctPqdikgJMbyN0chiONLGQ0nk/qAJ97KeffR7L3KWpvAmViE2Apk+M/CN9VRAneQ6mMUFgfPtwpjpmuyXLlKH5SFw75O7GJ9mvqK1GuU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZxTox/az; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZxTox/az" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3862b40a6e0so4693427f8f.0 for ; Wed, 22 Jan 2025 08:47:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737564444; x=1738169244; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xSBAii7BK2gaCNHWIIUjjrclWZDFTKQN8taZzBleOGc=; b=ZxTox/azYSDcSyN7l8zfAsg0ypW3EnPJx6yGFa+XA8zHjdWDmQLDQ/IlXtbc7Pwkbt 1qMWduz8cy88t9FKz7eJTv59R+O3yL3PJxudRGWeBpL1AcH+JlLnYbm1IO3GU6eAv7nP rXO2s/Ga27epzkAqtIm+w3aRuAeseBHoGEsopqcS6DkTNJ6LVuYl+GVbSXtFC6OXt468 RmePYy+dbluMwWrPWWyNGdFb+Fy1bBYVWY+exXKmAwzR8B3xGSXhVnnrA6sWU98L6HYs SttSH4ws6RxRLoqNhcqN+HB3c9EIApMGdEDFx4KhKQHQNgKrkeCi2AAyLaf/wvhJRzME XV4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737564444; x=1738169244; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xSBAii7BK2gaCNHWIIUjjrclWZDFTKQN8taZzBleOGc=; b=A/230wByR3IPAHh9Ulm5ZYVzpWXBXxhlQD29P1UGP4OnHsdZsTgx9+56T+dj+EPtrv ZmTMT/BPEJQLnK88oTGYsSbH146i6MJswci1uB5ev6HreauD5rvWzfFLq+El+ZHjNPJw JHX8l/7bUfEEDc0WWHGCLbqWK7ryAkpNvOj1NKYxX9l2cxJNcjGpZp1SQPMOe/+wd3WL dRhgnGFo8e98oS+iEFg+pFd5EJESQVIgvxSCpcZeiNNx6DSrJb6I2V18u5vJ62D16GhX yFhnU4Uj3cZQm0Xg2uZipEwoiPhopN6xqa8fHGt2ABXaRrS0xpbK8HejCCpi2SxwnAWA f/oA== X-Forwarded-Encrypted: i=1; AJvYcCXvYAqe5ks1EfR1hQ61Y1H4NW35C/wVnOVAUFu4yAUCAIZ/Mgb6LCk2vgfX5HyImjqKtbVGMahtrZYut0s=@vger.kernel.org X-Gm-Message-State: AOJu0YxQ1SrXqSBDX4VTlSvU7z0pRwHNigKTfC1uV6ppEUQbQaQqKwHs BLK2joZHrrpbRRNxPAIfX3dy4Io8iSXiAWPaIbpzYW++JT58QsAtdTYAyE/6u3M= X-Gm-Gg: ASbGncvqZQvk3H55R1krvHF9MKM86idVtmb6rmPZLXc0JgY44R2U/bG37TJg9xtGuNh L2dNmFSwraoUgh7vT50Uf7YoPdPXN5PKVYhqty/Q5T0+lnLhcejp5N2B75ZIzRa+sdyKGdWKah2 BX5qQPp3Jr3YYJ+KZlW7iiv8Ayy1Fcttw4cCgfvSyU5Hin4p8676hVPGtNe8dAebaRnd8sGyyAq YAvlnjcVTdihpvNBVIJ++DI6r0FNHv3G5P2n2RzIS90mkWhsuirSKP4hEbxnal+/cd+4U3K+iPu 2bVE X-Google-Smtp-Source: AGHT+IH0bumv8/ep45dsbyJ3w/bgIbCNbZvWl8ImNKDmIS37q2b3Bybg40Q9enSZb2jM4zdqkXOTng== X-Received: by 2002:a05:6000:156c:b0:386:1cd3:8a05 with SMTP id ffacd0b85a97d-38bf57ce963mr21812975f8f.54.1737564444187; Wed, 22 Jan 2025 08:47:24 -0800 (PST) Received: from [192.168.68.163] ([212.105.145.45]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf328864esm17087269f8f.99.2025.01.22.08.47.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jan 2025 08:47:23 -0800 (PST) Message-ID: Date: Wed, 22 Jan 2025 16:47:22 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/5] A mechanism for efficient support for per-function metrics To: mark.barnett@arm.com Cc: ben.gainey@arm.com, deepak.surti@arm.com, ak@linux.intel.com, will@kernel.org, james.clark@arm.com, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, adrian.hunter@intel.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, irogers@google.com References: <20250106120156.227273-1-mark.barnett@arm.com> Content-Language: en-US From: James Clark In-Reply-To: <20250106120156.227273-1-mark.barnett@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/01/2025 12:01 pm, mark.barnett@arm.com wrote: > From: Mark Barnett > > This patch introduces the concept of an alternating sample rate to perf > core and provides the necessary basic changes in the tools to activate > that option. > [...] > Changes since v1: > - Rebased onto perf-tools-next, as per request from Ian Rogers. > - Removed unnecessary code that truncated period_left to 0 and restarted > the PMU. > - Renamed variables to use the shorter 'alt_period' instead of > 'alterantive_period'. > - Added patch #5 that addresses an issue in the x86 and PowerPC drivers that > caused the opposite period to be reported in the sample record. > It sounds like it would be better if patch 5 comes first otherwise the feature is introduced as broken.