From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <krzk@kernel.org>, Kevin Jia <kjia@nexthop.ai>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: trivial-devices: Add TDK FS160x and FS1006
Date: Mon, 26 Oct 2026 09:08:23 -0700 [thread overview]
Message-ID: <ca8ea6f9-8eca-400b-9fe2-e4abd69ebf52@roeck-us.net> (raw)
In-Reply-To: <20261023-deft-tentacled-seriema-daa339@quoll>
On 10/23/26 01:57, Krzysztof Kozlowski wrote:
> On Tue, Oct 20, 2026 at 04:48:15PM +0000, Kevin Jia wrote:
>> Add the TDK FS1603, FS1604, FS1606 and FS1006 uPOL converters. The
>> FS1606-0600 and FS1606-2500 presets scale telemetry differently, so they
>> get their own compatibles.
>
> And why tdk,fs1006 has multiple variants? Are they actually different?
>
I checked the datasheet. Unfortunately, they _are_ different, and there seems
to be no way to determine the chip ID by reading chip registers. This is an
odd chip :-(.
Guenter
>>
>> Signed-off-by: Kevin Jia <kjia@nexthop.ai>
>> ---
>> Documentation/devicetree/bindings/trivial-devices.yaml | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2026-10-26 16:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 16:48 [PATCH v2 0/3] hwmon: (fs1603) Add driver for TDK FS160x and FS1006 uPOL converters Kevin Jia
2026-10-20 16:48 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add TDK Kevin Jia
2026-10-26 22:06 ` Guenter Roeck
2026-10-20 16:48 ` [PATCH v2 2/3] dt-bindings: trivial-devices: Add TDK FS160x and FS1006 Kevin Jia
2026-10-23 8:57 ` Krzysztof Kozlowski
2026-10-26 16:08 ` Guenter Roeck [this message]
2026-10-20 16:48 ` [PATCH v2 3/3] hwmon: (fs1603) Add driver for TDK FS160x and FS1006 uPOL converters Kevin Jia
2026-10-26 22:04 ` Guenter Roeck
2026-10-27 23:21 ` Kevin Jia
2026-10-27 23:53 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca8ea6f9-8eca-400b-9fe2-e4abd69ebf52@roeck-us.net \
--to=linux@roeck-us.net \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=kjia@nexthop.ai \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®