mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Böszörményi Zoltán" <zboszor@pr.hu>
To: Guenter Roeck <linux@roeck-us.net>, Jean Delvare <jdelvare@suse.de>
Cc: Wolfram Sang <wsa@the-dreams.de>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c: piix4: Use request_muxed_region
Date: Tue, 13 Feb 2018 12:48:37 +0100	[thread overview]
Message-ID: <ca8f74c0-c249-7698-21f7-e3ee49cd5516@pr.hu> (raw)
In-Reply-To: <20180212185152.GA20877@roeck-us.net>

2018-02-12 19:51 keltezéssel, Guenter Roeck írta:
> On Mon, Feb 12, 2018 at 11:10:41AM +0100, Jean Delvare wrote:
>> Hi Guneter,
>>
>> Sorry for the delay :(
>>
>> On Sat, 30 Dec 2017 08:50:57 -0800, Guenter Roeck wrote:
>>> Accesses to SB800_PIIX4_SMB_IDX can occur from multiple drivers.
>>> Use request_muxed_region() to ensure synchronization.
>>
>> Which ones? Documenting it, at least in the commit message, would seem
>> useful. Out of curiosity, have these other drivers been converted to
>> use request_muxed_region already?
>>
> Primarily watchdog, but there is also unprotected initialization code
> in several locations.

There are three locations touching the same I/O ports:
the PCI-USB quirks code (still doesn't use locking AFAIK), i2c-piix4 and
the sp5100_tco watchdog drivers.

Best regards,
Zoltán Böszörményi

  reply	other threads:[~2018-02-13 11:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-30 16:50 Guenter Roeck
2017-12-30 16:50 ` [PATCH 2/2] i2c: piix4: Use usleep_range() Guenter Roeck
2018-02-11 20:12   ` [2/2] " Guenter Roeck
2018-02-12 10:53   ` [PATCH 2/2] " Jean Delvare
2018-02-12 20:59     ` Guenter Roeck
2018-02-12 21:35       ` Joe Perches
2018-02-12 22:22     ` Guenter Roeck
2018-02-14 14:44       ` Jean Delvare
2018-02-26 19:56     ` Wolfram Sang
2018-02-22  3:59   ` Andrew Cooks
2018-02-11 20:11 ` [1/2] i2c: piix4: Use request_muxed_region Guenter Roeck
2018-02-12 10:10 ` [PATCH 1/2] " Jean Delvare
2018-02-12 18:51   ` Guenter Roeck
2018-02-13 11:48     ` Böszörményi Zoltán [this message]
2018-02-13 14:11       ` Guenter Roeck
2018-02-14 14:23     ` Jean Delvare
2018-02-26 19:55       ` Wolfram Sang
2018-02-26 20:37         ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca8f74c0-c249-7698-21f7-e3ee49cd5516@pr.hu \
    --to=zboszor@pr.hu \
    --cc=jdelvare@suse.de \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®