From: Caleb Connolly <caleb@connolly.tech>
To: Joel Selvaraj <jo@jsfamily.in>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, Amit Pundir <amit.pundir@linaro.org>
Subject: Re: [PATCH 1/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: change firmware path and use mbn format
Date: Wed, 30 Mar 2022 17:51:25 +0000 [thread overview]
Message-ID: <ca8ff74d-0781-1bc8-0f2d-29f5b2154c7f@connolly.tech> (raw)
In-Reply-To: <BY5PR02MB700966DEE6F6044EBEB5B892D91F9@BY5PR02MB7009.namprd02.prod.outlook.com>
On 30/03/2022 07:45, Joel Selvaraj wrote:
> The "qcom/sdm845/" path conflicts with db845c's firmware that are
> present in the linux-firmware package. Xiaomi uses their own signed
> firmware for Poco F1 and can't use the db845c's firmware. So let's
> use "qcom/sdm845/beryllium/" to distinguish Poco F1's firmware files.
>
> For easier handling and packaging, the mdt+bXX files are squashed
> using Bjorn Andersson's pil-squasher tool from this link:
> https://github.com/andersson/pil-squasher
Reviewed-by: Caleb Connolly <caleb@connolly.tech>
>
> Signed-off-by: Joel Selvaraj <jo@jsfamily.in>
> ---
> arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> index 367389526b41..27ba9ad1ad02 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> @@ -121,7 +121,7 @@ vreg_s4a_1p8: vreg-s4a-1p8 {
>
> &adsp_pas {
> status = "okay";
> - firmware-name = "qcom/sdm845/adsp.mdt";
> + firmware-name = "qcom/sdm845/beryllium/adsp.mbn";
> };
>
> &apps_rsc {
> @@ -208,7 +208,7 @@ vreg_l26a_1p2: ldo26 {
>
> &cdsp_pas {
> status = "okay";
> - firmware-name = "qcom/sdm845/cdsp.mdt";
> + firmware-name = "qcom/sdm845/beryllium/cdsp.mbn";
> };
>
> &dsi0 {
> @@ -262,7 +262,7 @@ &gpu {
>
> zap-shader {
> memory-region = <&gpu_mem>;
> - firmware-name = "qcom/sdm845/a630_zap.mbn";
> + firmware-name = "qcom/sdm845/beryllium/a630_zap.mbn";
> };
> };
>
> @@ -289,7 +289,7 @@ &mdss {
>
> &mss_pil {
> status = "okay";
> - firmware-name = "qcom/sdm845/mba.mbn", "qcom/sdm845/modem.mdt";
> + firmware-name = "qcom/sdm845/beryllium/mba.mbn", "qcom/sdm845/beryllium/modem.mbn";
> };
>
> &pm8998_gpio {
> --
> 2.35.1
>
--
Kind Regards,
Caleb
next prev parent reply other threads:[~2022-03-30 17:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220330064505.243799-1-jo@jsfamily.in>
2022-03-30 6:45 ` Joel Selvaraj
2022-03-30 17:51 ` Caleb Connolly [this message]
2022-04-21 14:26 ` Bjorn Andersson
2022-03-30 6:45 ` [PATCH 2/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom ipa driver Joel Selvaraj
2022-03-30 17:52 ` Caleb Connolly
2022-03-30 6:45 ` [PATCH 3/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: fix typo in panel's vddio-supply property Joel Selvaraj
2022-03-30 17:54 ` Caleb Connolly
2022-03-30 6:45 ` [PATCH 4/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable second wifi channel Joel Selvaraj
2022-03-30 17:55 ` Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca8ff74d-0781-1bc8-0f2d-29f5b2154c7f@connolly.tech \
--to=caleb@connolly.tech \
--cc=agross@kernel.org \
--cc=amit.pundir@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jo@jsfamily.in \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®