From: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
To: Douglas Anderson <dianders@chromium.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
cros-qcom-dts-watchers@chromium.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
sheng-liang.pan@quanta.corp-partner.google.com
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc7180: Reorganize trogdor rt5682 audio codec dts
Date: Thu, 17 Aug 2023 16:57:58 +0800 [thread overview]
Message-ID: <ca90fa1b-17aa-fbc2-8ff8-01a77a93a1cc@quanta.corp-partner.google.com> (raw)
In-Reply-To: <20230816112143.2.I29a5a330b6994afca81871f74bbacaf55b155937@changeid>
Hi
> It was asserted that the "/delete-property/ VBAT-supply;" that we
> needed to do in the rt5682s dts fragment was ugly. Let's change up all
> the trogdor device trees to make it explicit which version of "rt5682"
> we have and avoid the need for the "delete-property".
>
> As a side effect, this nicely gets rid of the need for a delete-node
> in coachz, which doesn't use "rt5682" at all.
>
> A few notes:
> - This doesn't get rid of every "/delete-node/" in trogdor, just the
> one that was used for rt5682s.
> - Though we no longer have any "/delete-node/", we do still override
> the "model" in the "sound" node in one case (in pompom) since that
> uses the "2mic" sound setup.
>
> This is validated to produce the same result (other than a few
> properties being reordered) when taking the dtbs generated by the
> kernel build and then doing:
>
> for dtb in *trogdor*.dtb; do
> dtc -I dtb -O dts $dtb -o out/$dtb.dts;
> done
>
> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
> I'm pretty on the fence about this change. I wrote it up at
> Krzysztof's request. While I don't hate it, I'm not convinced that
> this is truly more understandable and it does cause a bit of extra
> duplication. Happy to let others/Bjorn decide.
>
> .../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 1 -
> .../dts/qcom/sc7180-trogdor-homestar.dtsi | 2 +
> .../sc7180-trogdor-lazor-limozeen-nots-r5.dts | 1 +
> .../sc7180-trogdor-lazor-limozeen-nots-r9.dts | 1 +
> .../qcom/sc7180-trogdor-lazor-limozeen-r4.dts | 2 +
> .../qcom/sc7180-trogdor-lazor-limozeen-r9.dts | 1 +
> .../boot/dts/qcom/sc7180-trogdor-lazor-r1.dts | 1 +
> .../dts/qcom/sc7180-trogdor-lazor-r3-kb.dts | 1 +
> .../dts/qcom/sc7180-trogdor-lazor-r3-lte.dts | 1 +
> .../boot/dts/qcom/sc7180-trogdor-lazor-r3.dts | 1 +
> .../dts/qcom/sc7180-trogdor-lazor-r9-kb.dts | 1 +
> .../dts/qcom/sc7180-trogdor-lazor-r9-lte.dts | 1 +
> .../boot/dts/qcom/sc7180-trogdor-lazor-r9.dts | 1 +
> .../sc7180-trogdor-pazquel-lte-parade.dts | 1 +
> .../qcom/sc7180-trogdor-pazquel-lte-ti.dts | 1 +
> .../qcom/sc7180-trogdor-pazquel-parade.dts | 1 +
> .../dts/qcom/sc7180-trogdor-pazquel-ti.dts | 1 +
> .../boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 1 +
> .../qcom/sc7180-trogdor-quackingstick.dtsi | 1 +
> .../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 1 +
> .../dts/qcom/sc7180-trogdor-rt5682i-sku.dtsi | 38 +++++++++++++++++++
> .../dts/qcom/sc7180-trogdor-rt5682s-sku.dtsi | 33 +++++++++++++---
> ...0-trogdor-wormdingler-rev1-boe-rt5682s.dts | 12 +++++-
> .../sc7180-trogdor-wormdingler-rev1-boe.dts | 1 +
> ...0-trogdor-wormdingler-rev1-inx-rt5682s.dts | 6 ++-
> .../sc7180-trogdor-wormdingler-rev1-inx.dts | 1 +
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 27 -------------
> 27 files changed, 104 insertions(+), 36 deletions(-)
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-rt5682i-sku.dtsi
>
Reviewed-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
next prev parent reply other threads:[~2023-08-17 8:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 18:21 [PATCH 1/2] arm64: dts: qcom: sc7180: Move trogdor rt5682s bits to a fragment Douglas Anderson
2023-08-16 18:21 ` [PATCH 2/2] arm64: dts: qcom: sc7180: Reorganize trogdor rt5682 audio codec dts Douglas Anderson
2023-08-17 8:57 ` Sheng-Liang Pan [this message]
2023-08-26 9:36 ` Konrad Dybcio
2023-08-28 15:04 ` Doug Anderson
2023-08-28 15:07 ` Konrad Dybcio
2023-08-17 8:24 ` [PATCH 1/2] arm64: dts: qcom: sc7180: Move trogdor rt5682s bits to a fragment Sheng-Liang Pan
2023-08-26 9:34 ` Konrad Dybcio
2023-09-14 23:37 ` Doug Anderson
2023-09-20 2:13 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca90fa1b-17aa-fbc2-8ff8-01a77a93a1cc@quanta.corp-partner.google.com \
--to=sheng-liang.pan@quanta.corp-partner.google.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®