From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Abel Vesa" <abel.vesa@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] dt-bindings: PCI: qcom,pcie-sa8775p: Add missing required power-domains
Date: Thu, 30 Oct 2025 09:41:10 +0100 [thread overview]
Message-ID: <ca90fd36-8b2c-4b91-9844-fe577c4ec227@linaro.org> (raw)
In-Reply-To: <20251029-dt-bindings-pci-qcom-fixes-power-domains-v1-1-da7ac2c477f4@linaro.org>
On 29/10/2025 16:40, Krzysztof Kozlowski wrote:
> Commit 544e8f96efc0 ("dt-bindings: PCI: qcom,pcie-sa8775p: Move SA8775p
> to dedicated schema") move the device schema to separate file, but it
> missed a "if:not:...then:" clause in the original binding which was
> requiring power-domains for this particular chip.
>
> Fixes: 544e8f96efc0 ("dt-bindings: PCI: qcom,pcie-sa8775p: Move SA8775p to dedicated schema")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
> index 19afe2a03409..f3c54226a19d 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
> @@ -78,6 +78,7 @@ properties:
> required:
> - interconnects
> - interconnect-names
> + - power-domains
I am going through more of the bindings and I noticed now that "resets"
also were within "if:not:" and they should be required here too.
All patchses will be fixed in v2.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-30 8:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 15:40 [PATCH 0/9] dt-bindings: PCI: qcom: " Krzysztof Kozlowski
2025-10-29 15:40 ` [PATCH 1/9] dt-bindings: PCI: qcom,pcie-sa8775p: " Krzysztof Kozlowski
2025-10-30 8:41 ` Krzysztof Kozlowski [this message]
2025-10-29 15:40 ` [PATCH 2/9] dt-bindings: PCI: qcom,pcie-sc7280: " Krzysztof Kozlowski
2025-10-29 15:40 ` [PATCH 3/9] dt-bindings: PCI: qcom,pcie-sc8280xp: " Krzysztof Kozlowski
2025-10-29 15:40 ` [PATCH 4/9] dt-bindings: PCI: qcom,pcie-sm8150: " Krzysztof Kozlowski
2025-10-29 15:40 ` [PATCH 5/9] dt-bindings: PCI: qcom,pcie-sm8250: " Krzysztof Kozlowski
2025-10-29 15:40 ` [PATCH 6/9] dt-bindings: PCI: qcom,pcie-sm8350: " Krzysztof Kozlowski
2025-10-29 15:40 ` [PATCH 7/9] dt-bindings: PCI: qcom,pcie-sm8450: " Krzysztof Kozlowski
2025-10-29 15:40 ` [PATCH 8/9] dt-bindings: PCI: qcom,pcie-sm8550: " Krzysztof Kozlowski
2025-10-29 15:40 ` [PATCH 9/9] dt-bindings: PCI: qcom,pcie-x1e80100: " Krzysztof Kozlowski
2025-10-29 16:46 ` Johan Hovold
2025-10-30 8:16 ` Krzysztof Kozlowski
2025-10-30 18:08 ` Rob Herring
2025-10-31 14:04 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca90fd36-8b2c-4b91-9844-fe577c4ec227@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®