From: Petr Pavlu <petr.pavlu@suse.com>
To: petr.pavlu@suse.com
Cc: "Jens Axboe" <axboe@kernel.dk>,
"Jakub Kicinski" <kuba@kernel.org>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Tvrtko Ursulin" <tursulin@ursulin.net>,
"Matthew Brost" <matthew.brost@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Simon Horman" <horms@kernel.org>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Francois Dugast" <francois.dugast@intel.com>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Daniel Gomez" <da.gomez@kernel.org>,
"Sami Tolvanen" <samitolvanen@google.com>,
"Aaron Tomlin" <atomlin@atomlin.com>,
linux-block@vger.kernel.org, netdev@vger.kernel.org,
linux-api@vger.kernel.org, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] Remove the error-injection.h include from linux/module.h
Date: Thu, 1 Oct 2026 17:10:50 +0200 [thread overview]
Message-ID: <ca910292-5d3d-47b5-ae40-7ca1688f3c06@suse.com> (raw)
In-Reply-To: <20260911-module-include-error_injection-v1-0-5da895d8c84d@suse.com>
On 9/11/26 5:04 PM, Petr Pavlu wrote:
> linux/module.h appears in roughly 15k #include directives across the
> kernel. This makes it a "hot" header, so it should avoid pulling in
> unnecessary definitions.
>
> The header currently includes linux/error-injection.h to obtain the
> definition of `struct error_injection_entry`. However, this is unnecessary
> because the type is only referenced in the file as a pointer, for which an
> incomplete type is sufficient.
>
> Add explicit includes of linux/error-injection.h to files that use the
> ALLOW_ERROR_INJECTION() macro and currently rely on it being provided
> indirectly via linux/module.h. Then remove the linux/error-injection.h
> include from linux/module.h.
>
> The first five patches can go through their respective trees if preferred.
> The final patch depends on the preceding cleanups.
I've queued the series on modules-next for 7.4-rc1.
--
Thanks,
Petr
prev parent reply other threads:[~2026-10-01 15:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 15:04 Petr Pavlu
2026-09-11 15:04 ` [PATCH 1/6] block: Include error-injection.h for ALLOW_ERROR_INJECTION() Petr Pavlu
2026-09-11 15:10 ` Jens Axboe
2026-09-11 15:04 ` [PATCH 2/6] net: " Petr Pavlu
2026-09-11 15:04 ` [PATCH 3/6] syscalls: " Petr Pavlu
2026-09-11 15:04 ` [PATCH 4/6] drm/i915: " Petr Pavlu
2026-09-14 7:51 ` Francois Dugast
2026-09-14 12:03 ` Jani Nikula
2026-09-11 15:04 ` [PATCH 5/6] drm/xe: " Petr Pavlu
2026-09-14 7:41 ` Francois Dugast
2026-09-11 15:04 ` [PATCH 6/6] module: Remove the error-injection.h include from linux/module.h Petr Pavlu
2026-09-11 17:31 ` Aaron Tomlin
2026-09-22 12:25 ` [PATCH 0/6] " Petr Pavlu
2026-10-01 15:10 ` Petr Pavlu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca910292-5d3d-47b5-ae40-7ca1688f3c06@suse.com \
--to=petr.pavlu@suse.com \
--cc=airlied@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=atomlin@atomlin.com \
--cc=axboe@kernel.dk \
--cc=da.gomez@kernel.org \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=francois.dugast@intel.com \
--cc=horms@kernel.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kuba@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=matthew.brost@intel.com \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rodrigo.vivi@intel.com \
--cc=samitolvanen@google.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®