From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ABE744CAD3 for ; Wed, 8 Jul 2026 11:19:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783509569; cv=none; b=rM6tirVcJqSjvddQqd/3WaI7IG0owDzJAXCjgKlqlbGlx7ljjExoMnGXyDVmCGZcEawIw2bm0vEB6DA6zPi9mMhAlPdYv6REnjIA5+SdX5EPe5pSdQrRG93uF6/9qD7z3LZBlg5sy8JqFE5rSZzHZHFiT3q8uQfD4YhLk0rd1ug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783509569; c=relaxed/simple; bh=Lmryp5xahhJqIfp06uw6Ni/Xws3g3QD2M6M4xTh1qsE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KraeeaVU30PqERuGD6b9sACfObkzkmmNVWu3RkFjoxJyO0YMbIRbmZUny3byW6dApDKKPH7H4TjX1kvgwLWjCQPanVFNr3ChGb0jZHRFbL7TELrHiJAbtrB2nd8XcVsB9QaJYgDQG47KAq28nHgsk11S6dlRDU0+71PdkSBc0gc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DfONenWc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZZDd3Rsf; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DfONenWc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZZDd3Rsf" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66888smr2204801 for ; Wed, 8 Jul 2026 11:19:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5uSMsl7Phk/stnh2/hjHDjEP7WKyjI+VE9Mm2SfsUlY=; b=DfONenWcqw14McpL J/DkqrmjBC9uVHzbFj2BzO9FRR8XDvuESRAWusGGxNq/tUsiG0SJWQRw/7RdOrwO RQ6M4luFVQ5NFi+VvaJv6O/5yPqHdAHc/LK9cru63xzU1wnXYn06YArhqbowOWv1 GgN7VDQgEzua/mVo1G/X7xeszOpRbAf0FfZfYAigTekZXNK8KDVoG6JVh15Urab1 vrUSyi9C63KyOd4noaCgKI0FBBmqlWRPnTvKYGdpchdzWipbENQrv7ejS+YRRQ/G fhw0XSDXEMWFmXFcdv76wJcJm1Ml6XNJAHKUWuriUIOcLVVTAzYKbwIysC0rNv9z xDI0/Q== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f9hnv116d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Jul 2026 11:19:27 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-380fe2a3fc7so674426a91.2 for ; Wed, 08 Jul 2026 04:19:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783509567; x=1784114367; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5uSMsl7Phk/stnh2/hjHDjEP7WKyjI+VE9Mm2SfsUlY=; b=ZZDd3Rsf89T8ZVSmdNb4lZ8mKR8fmzs4NCIYfTFE6t3DbPGP5aaGYTKCzjoR8ZaoRf Pc7q/n1znXNblA4/yhmn04PNPckZTdkIVrvMudgETqyVNMF062ksUgLx3o2wNRbXkJG9 EI0aNjNQL5v53vcLQ4GMC6X/tfOJFP+ZgBs/iCN+tn1x5l9IBWMsyRiTxTmSu7TYkyhD PNgtPRphuEAU6tK7vLLl1W0OohNGqX10MSJVxjdsBMvj7HQ9vQJGMrwaiQ1fBp9zMnre V1lW853UvOV4Wt2sxHueMIj7zmrzUzbBQP7nWsgRN1EA9uWOiEFwsj0pO7GCjfbaDhLD 44yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783509567; x=1784114367; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5uSMsl7Phk/stnh2/hjHDjEP7WKyjI+VE9Mm2SfsUlY=; b=ZadOiRdhp9yO5UQUolXJdfmtL3sxPo0dSciZ5UNVOY876sYhdwLOTAqmE5C3cc2/Ak xkV2zPm3ouS/0s3QWsVPMyrWpfNG0FUejFhIY7zSoQfFeidMvkNBffZeu590jgnXwZou UL6Rn0+eiKd3YS8wMt5GxxlI4t1I6q9v5uXTo3HGvzicpJ+KaH0KxSAxMLraHGKJMnNO /aoP02tKdhdCgKHRWyeQGz+OBCWKavQuBuOCgJevv3SwI/nNTAeM4jF7B2vfHyVlOECO hnyjnbkKLRKSjwSP++Q2FusZkW45r4OldbYd1/YKIVLiOioxp1e0YH1lmcM4k19p6jbT YnDg== X-Forwarded-Encrypted: i=1; AHgh+RoBwmuMFq4VV4Jn/kpMwYp8bOqHJ+RsDClIhdIdXrhyk0bTOACjOt5p/pGG2ZZfEeD2kEQ/wvSfZXSScx0=@vger.kernel.org X-Gm-Message-State: AOJu0YyAqpQ2/PwAgbpctxsT8xHmSoFjpU3ZrpO2edXj8KWmV0MGHtpc BRy9V0qyQg8wvlQF/OXKGEm/3IiZbkPtq484OGscG/mzRKFlcAQ+C8Bg7RVvyxHfYDFEp2m8qR+ qoofaS8Wly8axCOsUJxfPWuCkVZIrmRGbCNJjGGjfAjY+aAGJ0IvHBdjPHpKHMRoeO2I= X-Gm-Gg: AfdE7cnAOeRBqvTluATCHEieXzqUy8AfbRtydkNc1C4al+Rt+1n+bYlKHCb/Igz9CvK 27+06brQ7xVl0PgBmCvjSoJOyCuUlIMrcnzxbI+XPm+hFUXC67HlnQMMReGiWYGJXvrf/VRiAgb WoFwcUpTp+DirTbndmGjslksp/z9lxr2/bWqgOvsQfl5ad1R3PPKuFKfSMwq1QHR+qizHU+l5bf PbQOAP4fhWx3RrYQJK9hZbx7OR6KF5ogv+BlJOtiWnwSfJ/SgQbYka5lwYVIOuqLxg/dVumlkRQ HnJ2wj7/99VaTdyrKWNFQijz0CIaq2sjsShz/XltFFQzwv6WPs9x788LF7N1me4S/9KVwVT4LBT 3mqmG/AmQuMeXe7SimlDW0hkFh/fyH5DiXuVovHg= X-Received: by 2002:a17:90b:350c:b0:36d:7b62:4767 with SMTP id 98e67ed59e1d1-3893fe5b986mr2290745a91.5.1783509567026; Wed, 08 Jul 2026 04:19:27 -0700 (PDT) X-Received: by 2002:a17:90b:350c:b0:36d:7b62:4767 with SMTP id 98e67ed59e1d1-3893fe5b986mr2290700a91.5.1783509566602; Wed, 08 Jul 2026 04:19:26 -0700 (PDT) Received: from [10.92.199.168] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-387d17ec015sm2578846a91.9.2026.07.08.04.19.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2026 04:19:26 -0700 (PDT) Message-ID: Date: Wed, 8 Jul 2026 16:49:19 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 08/19] clk: qcom: dispcc-qcm2290: Set HW_CTRL_TRIGGER flag for GDSC To: Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Loic Poulain , Brian Masney , Dmitry Baryshkov Cc: Ajit Pandey , Taniya Das , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260703-shikra-dispcc-gpucc-v5-0-cc13826d4d5a@oss.qualcomm.com> <20260703-shikra-dispcc-gpucc-v5-8-cc13826d4d5a@oss.qualcomm.com> <94abf47a-0fdd-4dcc-b56f-963ba80ba33e@oss.qualcomm.com> Content-Language: en-US From: Imran Shaik In-Reply-To: <94abf47a-0fdd-4dcc-b56f-963ba80ba33e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=KNNqylFo c=1 sm=1 tr=0 ts=6a4e323f cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=aR6tUbKHR8Lh8TkzPOEA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA4MDExMCBTYWx0ZWRfX5uNsnQMn8qHq +z5Zvea+ujOOix7KHoOb9ELqAuwXKqlj48E0IOesQ47UGea4R5F1ZSuMws9FkqAOWc4h6uw9NQG AypMV/OjI4PUHHCtOysMVmo8Y1eBmxg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA4MDExMCBTYWx0ZWRfX8GiX1pWYXwGa T754pR96rVCXrQtVQaRGo+zeZFDzjmdwmVT5oYZU/PLVs88n12ziqBg7Bk1rtlH1sgD0lhQ6Suo uiu4eKWfsRcsOS0gpO07DTiAdACeCpHjfYd2iT5ift9bMbqtqR13ilyUeInF7+AX5WBAb4tE2ji um5hu/n+BYeIj20V8LFpbms/zGydPA9EkyfJGomrRU5dHCe6FEMj4J69x/5vOkWQ9hYhBQnHv9j c81fNVQrNear3bXoWswcjf8IDFr4yw2mdAj5iYTq2cuPwghRFa/uBR8TJc2d8v+aAREr5430gGD KiKHhOw/mEyhsvXxOIJWqXP8/YwSrPenIw0zHj93444Uo0Bwk08dXMOibeSPDuVNpkPqBEXkd54 6HdBEfbiP0goVj5lye80PDYj6I9Rc+gzOHT/ccs7cCbPpv/w28RRt78UnhDK6+jYKx0EhY1EPpo vg305f/gJuAojY7RgVw== X-Proofpoint-ORIG-GUID: Ee8aJXRhs9sLEZS5I561mVxZ2Zrz49nl X-Proofpoint-GUID: Ee8aJXRhs9sLEZS5I561mVxZ2Zrz49nl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-08_01,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 suspectscore=0 spamscore=0 malwarescore=0 phishscore=0 clxscore=1015 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607080110 On 03-07-2026 12:54 pm, Konrad Dybcio wrote: > On 7/2/26 8:31 PM, Imran Shaik wrote: >> Set HW_CTRL_TRIGGER flag for the MDSS GDSC to provide dynamic control to >> switch the GDSC HW and SW modes at runtime. >> >> Signed-off-by: Imran Shaik >> --- >> drivers/clk/qcom/dispcc-qcm2290.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/clk/qcom/dispcc-qcm2290.c b/drivers/clk/qcom/dispcc-qcm2290.c >> index 6f8c21f05ba4536d45c2a609d152f871cb875bbb..89a6cdd26217381cd44a515766363cf94d0aaeeb 100644 >> --- a/drivers/clk/qcom/dispcc-qcm2290.c >> +++ b/drivers/clk/qcom/dispcc-qcm2290.c >> @@ -467,7 +467,7 @@ static struct gdsc mdss_gdsc = { >> .name = "mdss_gdsc", >> }, >> .pwrsts = PWRSTS_OFF_ON, >> - .flags = HW_CTRL, >> + .flags = HW_CTRL_TRIGGER, > > No other dispcc driver sets this (other than kaanapali). Downstream uses > this for when DISP RSC (which agatti doesn't have [1]) is supposed to > idle > > Konrad > > [1] (well maybe it does but there's no RPMH so essentially it's not there) Sure, will drop this change in the next series. Thanks, Imran