From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FFB0C77B7D for ; Wed, 10 May 2023 07:04:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236346AbjEJHEe (ORCPT ); Wed, 10 May 2023 03:04:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236330AbjEJHEb (ORCPT ); Wed, 10 May 2023 03:04:31 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 430248F for ; Wed, 10 May 2023 00:04:30 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-50bc570b4a3so12637168a12.1 for ; Wed, 10 May 2023 00:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683702268; x=1686294268; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/ZkCFCzZD4JzTnaOmZhJFgRNPCw8xQEqtc/R5QiPjAA=; b=a5yKktjzJci/iih+IbtLEXlWS76EBbag1OAy+gRfRxDFwf5YCvXkJhdSlWypHe87Rh i+wqExTbmndbOdSRWh0veTzHIyCG9zVIYmZW7sS5Y9xdUnHm48iAxjV3x+yAc8ri/ak5 Ew6hj8by22Ol1hWCl4QyFoOAZO0yE+90vun71U34mXZl3A4Av+pDZDWOGF1GCqfrQIcF rMikVNcLyAzrb417C9qgmpu+S9Qod32ihXFrQbMl02RcuntS8rWv8LCA2yMd0Ycw2/SC cxynjIaH/9hHH4KspZOxO2ZCd+5a/7+VSNZiwVVyJvvEKWzxux/l4Y6qFp8Is+kFr/5p awtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683702268; x=1686294268; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/ZkCFCzZD4JzTnaOmZhJFgRNPCw8xQEqtc/R5QiPjAA=; b=Vgk1gqOJc6gg2sQfBVbT14Gnnn77SMqQ6up/dl4iSKUO2ur6ddS/9oMd7teR+9Tesn 6wYbQkJnyBovgBsbcAf8D4xY1oweW+pCIaRQJO9gOCgwwx3eVtrt/4DxvLGp8fGSvl1B Zl8t9VNJqHCAqk4gf+yr37lFEzomRBW5AdD0Zv+GUTVhtx1ZtmsB73YIhTNQnGeDB7SV aZWQSD1mOG4p0pfQWUhR1bxsX1RBV2WXhfd3GZdMnp8wNBccbJBVmIVQDzpuUaRTS3Om flUgGGQ/2tUJPEwXUKHbpabsYQJTPiuPUdw4rb2WYz9pOFTGar01TpkT97CdjDKiKOtA AxQQ== X-Gm-Message-State: AC+VfDxZRcQftzmV6QIlvUN7bADjsVxLQOA7ZMofUqU0KGAjAf4zYHXR g0VMCD+XiltkEUOCpB+644xvBA== X-Google-Smtp-Source: ACHHUZ4HmhCpVncMbbPtAqVY5vpN5YsolRPIOPz8n6DozDJQEyEQza7ajEOa/3Qm38aLyM5bEpqqIg== X-Received: by 2002:a17:906:4fd1:b0:961:8d21:a471 with SMTP id i17-20020a1709064fd100b009618d21a471mr14352353ejw.58.1683702268662; Wed, 10 May 2023 00:04:28 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:c175:a0f9:6928:8c9d? ([2a02:810d:15c0:828:c175:a0f9:6928:8c9d]) by smtp.gmail.com with ESMTPSA id b16-20020a170906195000b0094e96e46cc0sm2276891eje.69.2023.05.10.00.04.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 May 2023 00:04:28 -0700 (PDT) Message-ID: Date: Wed, 10 May 2023 09:04:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 2/5] ASoC: dt-bindings: Add tas2781 amplifier Content-Language: en-US To: Shenghao Ding <13916275206@139.com>, broonie@kernel.org, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, lgirdwood@gmail.com, perex@perex.cz, pierre-louis.bossart@linux.intel.com Cc: kevin-lu@ti.com, shenghao-ding@ti.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, x1077012@ti.com, peeyush@ti.com, navada@ti.com, gentuser@gmail.com, Ryan_Chu@wistron.com, Sam_Wu@wistron.com References: <20230508054512.719-1-13916275206@139.com> From: Krzysztof Kozlowski In-Reply-To: <20230508054512.719-1-13916275206@139.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/05/2023 07:45, Shenghao Ding wrote: > Create tas2781.yaml for tas2781 driver. > > Signed-off-by: Shenghao Ding <13916275206@139.com> > > --- > Changes in v7: Your subject says it is v2 and previously it was v6. Make it consistent. > - Submit together with tas2781 codec driver code Fix your patchset threading. I don't think it's possible to apply your one. > - Add more detail description for ti,audio-slots > - Keep consistent for "I2C" > - remove reset-gpios description > - For reg, express as constraints instead > - remove unnecessary '|' > Changes to be committed: > new file: Documentation/devicetree/bindings/sound/ti,tas2781.yaml > --- > .../devicetree/bindings/sound/ti,tas2781.yaml | 90 +++++++++++++++++++ > 1 file changed, 90 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/ti,tas2781.yaml > > diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml > new file mode 100644 > index 000000000000..96c2584855d4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml > @@ -0,0 +1,90 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2022 - 2023 Texas Instruments Incorporated > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/ti,tas2781.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments TAS2781 SmartAMP > + > +maintainers: > + - Shenghao Ding > + > +description: > + The TAS2781 is a mono, digital input Class-D audio amplifier > + optimized for efficiently driving high peak power into small > + loudspeakers. Integrated an on-chip DSP supports Texas Instruments > + Smart Amp speaker protection algorithm. The integrated speaker > + voltage and current sense provides for real time > + monitoring of loudspeaker behavior. > + you miss allOf with ref to saound-dai-common. > +properties: > + compatible: > + enum: > + - ti,tas2781 > + > + reg: > + description: I2C address of the primary device. > + items: > + minimum: 0x38 > + maximum: 0x3f > + > + reset-gpios: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + ti,audio-slots: > + description: > + Multiple tas2781s aggregate as one Audio Amp to support > + multiple audio slots > + $ref: /schemas/types.yaml#/definitions/uint32-array > + maxItems: 4 You said you can have here two addresses. You don't allow it, test it. Missing minItems, but... > + items: > + minimum: 0x38 > + maximum: 0x3f ... So these are fixed? No need to encode them in such case... and anyway actually I agree with Rob here - these addresses should be put in reg. > + description: > + I2C address of the device for different audio slots, > + useless in mono case. > + > + ti,broadcast-addr: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Generic I2C address for all the tas2781 devices in > + purpose of I2C broadcast during the multi-device > + writes, useless in mono case. Probably you can figure it out from previous addresses and there is no need for this property. > + > + '#sound-dai-cells': > + const: 1 > + > +required: > + - compatible > + - reg > + Best regards, Krzysztof