From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCD1FC10DC1 for ; Mon, 4 Dec 2023 15:45:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234713AbjLDPox (ORCPT ); Mon, 4 Dec 2023 10:44:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230496AbjLDPow (ORCPT ); Mon, 4 Dec 2023 10:44:52 -0500 Received: from netrider.rowland.org (netrider.rowland.org [192.131.102.5]) by lindbergh.monkeyblade.net (Postfix) with SMTP id CF9B1B0 for ; Mon, 4 Dec 2023 07:44:57 -0800 (PST) Received: (qmail 384740 invoked by uid 1000); 4 Dec 2023 10:44:57 -0500 Date: Mon, 4 Dec 2023 10:44:57 -0500 From: Alan Stern To: Hardik Gajjar Cc: Greg KH , corbet@lwn.net, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, erosca@de.adit-jv.com, tj@kernel.org, paulmck@kernel.org, Martin.Mueller5@de.bosch.com Subject: Re: [PATCH v3] usb: hub: Add quirk to decrease IN-ep poll interval for Microchip USB491x hub Message-ID: References: <20231201144705.97385-1-hgajjar@de.adit-jv.com> <39f334d2-abe6-4b4d-a48c-b22a907c6ea6@rowland.harvard.edu> <2023120437-opposite-juiciness-e0dd@gregkh> <20231204152543.GA115715@vmlxhi-118.adit-jv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231204152543.GA115715@vmlxhi-118.adit-jv.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 04, 2023 at 04:25:43PM +0100, Hardik Gajjar wrote: > On Mon, Dec 04, 2023 at 08:02:50AM +0100, Greg KH wrote: > > And why not use BIT() as that's what these are. > > > > thanks, > > > > greg k-h > > I am considering aligning with existing quirks. > Is it advisable to use something like HUB_QUIRK_REDUCE_FRAME_INTR_BINTERVAL BIT(2)? > I'm thinking to submit two patches – one to replace hard values with BIT() in existing quirks and a second patch containing my changes. That's a good idea. Alan Stern