From: Jon Hunter <jonathanh@nvidia.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Sumit Gupta <sumitg@nvidia.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] memory: tegra: Add dummy implementation on Tegra194
Date: Tue, 25 Jul 2023 11:14:25 +0100 [thread overview]
Message-ID: <cab267a2-28a0-969a-44cd-c87c8fe65218@nvidia.com> (raw)
In-Reply-To: <1ebfbbec-d5cf-c6ac-2cf1-eab970903500@linaro.org>
Hi Krzysztof,
On 10/07/2023 14:29, Krzysztof Kozlowski wrote:
> On 10/07/2023 15:06, Thierry Reding wrote:
>> On Mon, Jul 10, 2023 at 12:10:43PM +0200, Krzysztof Kozlowski wrote:
>>> On 29/06/2023 18:01, Thierry Reding wrote:
>>>> From: Thierry Reding <treding@nvidia.com>
>>>>
>>>> With the introduction of commit 9365bf006f53 ("PCI: tegra194: Add
>>>> interconnect support in Tegra234"), the PCI driver on Tegra194 and later
>>>> requires an interconnect provider. However, a provider is currently only
>>>> exposed on Tegra234 and this causes PCI on Tegra194 to defer probe
>>>> indefinitely.
>>>>
>>>> Fix this by adding a dummy implementation on Tegra194. This allows nodes
>>>> to be provided to interconnect consumers, but doesn't do any bandwidth
>>>> accounting or frequency scaling.
>>>>
>>>> Fixes: 9365bf006f53 ("PCI: tegra194: Add interconnect support in Tegra234")
>>>> Reported-by: Jon Hunter <jonathanh@nvidia.com>
>>>
>>> Applied with checkpatch warning. Please be sure you run checkpatch
>>> before sending the patches.
>>
>> Are you referring to the Reported-by/Closes complaint?
>
> Yes.
>
>> I didn't include
>> a URL here because this came from an internal test report and there's no
>> corresponding public reference.
>
> Ah, ok, apologies for pickiness then. :)
>
>>
>> I suppose I could've left out the Reported-by altogether.
>
> I think it is fine. Checkpatch warning is just advisory.
We need this in v6.5 as a fix, because without this change PCIe support
is broken on Tegra194 devices. Would you be able to send as a fix for v6.5?
Thanks!
Jon
--
nvpublic
next prev parent reply other threads:[~2023-07-25 10:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 16:01 Thierry Reding
2023-07-06 19:22 ` Sumit Gupta
2023-07-10 10:09 ` Krzysztof Kozlowski
2023-07-10 10:10 ` Krzysztof Kozlowski
2023-07-10 13:06 ` Thierry Reding
2023-07-10 13:29 ` Krzysztof Kozlowski
2023-07-25 10:14 ` Jon Hunter [this message]
2023-07-25 10:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cab267a2-28a0-969a-44cd-c87c8fe65218@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sumitg@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®