From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f182.google.com (mail-dy1-f182.google.com [74.125.82.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C5643A4AD0 for ; Wed, 21 Jan 2026 19:43:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769024607; cv=none; b=BKmyPFS3C1+aONNL5BhodlyfVo4lRypFagkT/PNUaGhUFnQSzTVqoRZxWH9WFnpRDBvWxYGRx2ot38sfezBzoZKUBGDSC4OheBCRpezKz+GjoouESP5jyprNCBUloSbHBVCqpotZLltN6I7Iq9k+fg8KSBrkhpbat0VMLnJcHxI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769024607; c=relaxed/simple; bh=w1kKinpt/YcI0gMNgEnS5zXjFDhZKigaZ8h7epYIB8I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kET8Eq+HV8y9HeztrV9uzofKJ4E958iGxut3JQGInVN0FdZ1Ca8rIQMqdcm0Yj7H7s9gf/ZrS4tx12a+rYoud3wDvsYUk/e0YEIPjVjV2MIcGX6IHbx0OPVPrId/PrcsGBd2yHeMuJo0KeU98wshcbPtRatu2uuZ/LMuhMlBrhM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mojatatu.com; spf=none smtp.mailfrom=mojatatu.com; dkim=pass (2048-bit key) header.d=mojatatu-com.20230601.gappssmtp.com header.i=@mojatatu-com.20230601.gappssmtp.com header.b=wyIfniBd; arc=none smtp.client-ip=74.125.82.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mojatatu.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=mojatatu.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mojatatu-com.20230601.gappssmtp.com header.i=@mojatatu-com.20230601.gappssmtp.com header.b="wyIfniBd" Received: by mail-dy1-f182.google.com with SMTP id 5a478bee46e88-2ae2eb49b4bso429180eec.0 for ; Wed, 21 Jan 2026 11:43:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu-com.20230601.gappssmtp.com; s=20230601; t=1769024604; x=1769629404; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ry8GpQeL1FNrHjzLhRKtbLVCrSqvGfns+hF1JkeMT8c=; b=wyIfniBdxot3ksMrjE0n0bzpL7YvWgg2VvtucR3ENGEYrsK8NAn9JpDTpsNe9pi2i8 fPJVrUisnvQ1702sS/QjiEUJI7iSOQpyyczAv+YYd74yB1GLixqHOqIrS2bQR/osdAOq QDAkBlu5Mu+lAQ8XDbMW58+mUvGm8Ln3lNILTykxaXfEJz1s9zbMDc4EfJw+xyfHjE3M Q2DIQzNs3pPN0j5R3XlsHrOzY7A7lpPA0NkhIWY+nGjru1Nn8iGuYDCgU/mnSM9UaLhq FUMeq969NlO2nDG1evZsAu1oef+bBWgFvft1VpPmeohRRKp1PsjAXALcIX/XPNFqznZO +RZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769024604; x=1769629404; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ry8GpQeL1FNrHjzLhRKtbLVCrSqvGfns+hF1JkeMT8c=; b=lRyQ0m+xkoSHRbkeppCK3j8XTU4Ka2qtZ3MnfSbeA4kxqbC+LoM12KpRx6n+DjBiUf TqHQpiExo9RFjniQg+IktRpxQ7gpld23klQkl3HzC+UJrWfEhgrOYlW7cK95jA2bBux/ dPKUvyVq5/tpj6NStKBpp50iR2NI+e2avdzMVp5skvUBs4yke/GVu00lDRZ3WaRdRj6K KlgLlAUXLrEuFC//u3DcddwSxdgQMmVGF0TcQgCpMdMPfoTinM2H156cynSDX+A8Ky2w dac/PqQEQWa6A31+2FYf5lIJ+psr0NMroGn+FPSie/1z796XID53FizRPKhhiC83uY5d fyEA== X-Forwarded-Encrypted: i=1; AJvYcCVubV6U9j+50QwwrsDLhLtC2YcYyPgTfxJt7m2YEI1h1aWxteFpTRIrSfpeFNaeEvNxqck4Y1b2TStrcUA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6V6wI8c5Jo1dtronrHlGnbAmYua0njlNYs8FoH2beqmJZoSYS /CncmkGn4q+Mxr7FouJusTu3vZZKVZ7Qq+RghzYjRwG58ro4aYD6brbXjy7kLOcCEw== X-Gm-Gg: AZuq6aJwjKJqCwXl9TudTdOkhJSJK7nowTSFu1WKzUIQGn9XUmE2P1DXfY95St+VXWe LaqFA1BjaByAsvBNGObqbV1NOq6sL4zNEucDRXR2f8v0vi4uRGzXvh37XXnbwBogfnCy4rKvTDx sR67KDcNr0CSW6oVMi05XXnVIBDMHyHeQ5JfAmgLJkmdeLyGKbw4qAeBzcoU9g8JhyrpLOwgtN2 gyj678yUGnHD6YlyXhiZJG7s6IwWO+jO1qiwvCb49qEUWAQGe9jpMV6JNhAlNYcarFEr1qaEy/N oGyPfhFNFWuFAKRX5oI0RLWU+pJ+uD9XI8rkCb2IyZWFUzC+Q1zftJ6oBOvdC48p0Jd7SbNBrVK AaBbxaVy313PWEr8gv0npE0I0SpOou/OOxEzMdyqc08Hs1tcLJRgckD9+1+4bEkW207F0lSAeeZ xqgUlLNJDQrUAt2u5Ca6RLNlg4QVk5Xyqe X-Received: by 2002:a05:7300:6da6:b0:2b4:5a2d:80c with SMTP id 5a478bee46e88-2b6fd8fd5a8mr3538584eec.11.1769024602139; Wed, 21 Jan 2026 11:43:22 -0800 (PST) Received: from ?IPV6:2804:14d:5c54:4efb::1c9d? ([2804:14d:5c54:4efb::1c9d]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b6b367cbc9sm25089488eec.32.2026.01.21.11.43.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jan 2026 11:43:21 -0800 (PST) Message-ID: Date: Wed, 21 Jan 2026 16:43:16 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v3 3/7] net/sched: act_gate: build schedule and RCU-swap To: Paul Moses , netdev@vger.kernel.org Cc: Jamal Hadi Salim , Cong Wang , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260121131954.2710459-1-p@1g4.org> <20260121131954.2710459-4-p@1g4.org> Content-Language: en-US From: Victor Nogueira In-Reply-To: <20260121131954.2710459-4-p@1g4.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 21/01/2026 10:20, Paul Moses wrote: > Build a fresh params snapshot and swap it in with rcu_replace_pointer(), > then free the old snapshot via call_rcu(). This is the same publish+defer > pattern used in taprio sched swapping (sch_taprio.c, commit d5c4546062fd6f) > and in act_pedit param updates (act_pedit.c, commit 52cf89f78c01bf). > > When REPLACE omits TCA_GATE_ENTRY_LIST, carry forward the old snapshot fields > (basetime/clockid/flags/cycletime/priority) and only override provided attrs, > so partial updates don’t reset unrelated state. > > Parse entry lists with GFP_KERNEL and explicit error handling, matching taprio’s > schedule parsing (sch_taprio.c, commit 5a781ccbd19e46). > [...] > @@ -388,32 +416,92 @@ static int tcf_gate_init(struct net *net, struct nlattr *nla, > > gact = to_gate(*a); > > - err = tcf_action_check_ctrlact(parm->action, tp, &goto_ch, extack); > - if (err < 0) > + p = kzalloc(sizeof(*p), GFP_KERNEL); > + if (!p) { > + err = -ENOMEM; > goto release_idr; > + } > + INIT_LIST_HEAD(&p->entries); > [...] > if (!cycletime) { > @@ -425,20 +513,26 @@ static int tcf_gate_init(struct net *net, struct nlattr *nla, > cycletime = cycle; > if (!cycletime) { > err = -EINVAL; > - goto chain_put; > + goto release_mem; > } > } > p->tcfg_cycletime = cycletime; You are always using the just allocated params pointer (p) when iterating through the entries [1]. So cycletime will always be 0 when the user doesn't specify it. This is breaking tdc: not ok 1119 3719 - Replace gate base-time action # Command exited with 255, expected 0 # RTNETLINK answers: Invalid argument # We have an error talking to the kernel [1] https://elixir.bootlin.com/linux/v6.18.6/source/net/sched/act_gate.c#L402