From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 177AA3A9D8F for ; Thu, 17 Sep 2026 08:15:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789632909; cv=none; b=pZY+0CLxjOR7UiVlwUd201pfiykEQ0fJZVeughREP+Hyw5s0eYlJbclbAge2QBqcuYNjAz5K8grf+DnZR9Ov+B5kQR6mXRnEcJI4jTtlOUGWg4A1LF5UYtPefNsIm/hoX5Q1hQuFI4w1E59YOkOW1v1evTbHl/JrNNXIDR5UZ7I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789632909; c=relaxed/simple; bh=iKOIRa1RHoGw0PgXLY5XEi0StfgSIxS9X5ymvt3iBCQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BjEkFVlcNR81YLBBGxMm0bsK4C0ndsuZf0th3iTvKGm5S6D2l0thkd0OKVlZs9JCIr/pYofImfHJCc1GE4cFvPFvPl3ZWcMVr0mqD+wVAJ6jLFNxYvnVq5mflTY85+zi2Y6BZXaNqYRztTi6lKjc4HxsYxGYeLt2UmrqGQl6tyE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=DPghrBM+; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="DPghrBM+" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68H621BQ1702777; Thu, 17 Sep 2026 08:14:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=yn9lmi YxAwLXKxiieoNf32Ajz85wxlvrCJpaULMU200=; b=DPghrBM+8Pgyj/TQZtyQPB RJj8SsiYzr2qL5a/3SeX/6uFNV8TjfU/t5mREwQ42JVP3yfKCWaaNa1MXPJUMcMg APqoYtYcx87JpRVfKDMZHcJStkKX52VxMGB7VLTGBfCC6jmEt9gqGVvYwR6MAVYL I4TNkzhrNkuNbZRftaxwecU3V4zL/wfnmeWdWrBnTGDvMXllZONNKCW3zTqf4CyU 8ocjmmpAdVyKZv4VcGS8x+Dy4juoSjZDEZOpTE5qA6K5Zy7SX2zUzaZcXavLXdZy dMBENILJ8qyCw1NMBX1L3gBV20ZuunAx/0komoqu3flyRsP2P0X1twuLOHE2vkdg == Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4gmx84172k-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 17 Sep 2026 08:14:39 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 68H653wB2660555; Thu, 17 Sep 2026 08:14:38 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4gr5fjhg4n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Sep 2026 08:14:38 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (smtpav05.wdc07v.mail.ibm.com [10.39.53.232]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 68H8EbSv1442658 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Sep 2026 08:14:37 GMT Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B35E558043; Thu, 17 Sep 2026 08:14:37 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0209B5805D; Thu, 17 Sep 2026 08:14:33 +0000 (GMT) Received: from [9.123.7.57] (unknown [9.123.7.57]) by smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP; Thu, 17 Sep 2026 08:14:32 +0000 (GMT) Message-ID: Date: Thu, 17 Sep 2026 13:44:31 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvme: work around all -Wformat-security warnings To: Arnd Bergmann , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Cc: Arnd Bergmann , Hannes Reinecke , Maurizio Lombardi , John Garry , Alistair Francis , Eric Biggers , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260917061459.1486026-1-arnd@kernel.org> Content-Language: en-US From: Nilay Shroff In-Reply-To: <20260917061459.1486026-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE3MDEwOCBTYWx0ZWRfX4m8wdQ3arOYs mu+Ed6KNnfxPk1TV340RFMUwDvyv1SmH8OMhTRueRsYaoUi54UifvlbigAsRyJpoIbt3Egc4b4p 1E+ZCNVBkw6a1mMwprMB6ch12Fo0LLEyPejQX2aJ9+E/8TfteCNHa8HwjWvVKmNZb6E/Sgueylf oHLFyZs6Gx1Amr7XZRr6Pnj5vSrNUU9fC2btK1JdX6GrKoph+Z+H5Oims6wiFfk7RNUIu11n2qK I8KUxWjBV/ZuFm0a6mV1uLdsx3nnrdJT5ctEsinsoWSz0rAdZQCchm+5wXNjnFBWJ0HQT6Ntw3K by7W0SNv8wtoGk9oyuR5nCGB4A52NH3zxS667fiFUDDNkrmw9DqtLu6sEn3bBt/D1fu0nhK7UhG HCMSEaAo7PEsCbwKWiGHe8CX2wUtvwp3T7BTHXOWoJ4/uoptc106WBIoeUmRQpR/0uRvIPYF0NA /3x/uU7NLbfA2GdKiuQ== X-Proofpoint-ORIG-GUID: RfExPr82GTHD7THJCC6KIoG1KsUy4uKA X-Proofpoint-GUID: RfExPr82GTHD7THJCC6KIoG1KsUy4uKA X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE3MDEwOCBTYWx0ZWRfX+VSWT+0A9dK8 VgWu6FlkW5GMFER3noTqEEtewsYfIKhncwtwCZbJfWcufVKxAApkZHYr6hxvXFzpm8VUdymbhqD ImNgadA5hkRhZs/FBx4IDonL23TnAOc= X-Authority-Analysis: v=2.4 cv=cY9HPXDM c=1 sm=1 tr=0 ts=6aaba16f cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=VnNF1IyMAAAA:8 a=06IV_GjJFQZO7jKsSJMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=ZXulRonScM0A:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-17_01,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 bulkscore=0 clxscore=1011 suspectscore=0 impostorscore=0 malwarescore=0 phishscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609170108 On 9/17/26 11:34 AM, Arnd Bergmann wrote: > From: Arnd Bergmann > > The sysfs code passes two string variables into sysfs_emit(), which is safe > in this instance but causes the compiler to warn when -Wformat-security > is enabled: > > host/sysfs.c: In function ‘cntrltype_show’: > host/sysfs.c:682:9: error: format not a string literal and no format arguments [-Werror=format-security] > 682 | return sysfs_emit(buf, type[ctrl->cntrltype]); > > Print these using a "%s" format like all other instances in the same file. > > Signed-off-by: Arnd Bergmann Looks good to me. Reviewed-by: Nilay Shroff