From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD6ECC636D4 for ; Mon, 13 Feb 2023 20:09:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230021AbjBMUJD (ORCPT ); Mon, 13 Feb 2023 15:09:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229615AbjBMUJA (ORCPT ); Mon, 13 Feb 2023 15:09:00 -0500 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B60A1CF65; Mon, 13 Feb 2023 12:08:58 -0800 (PST) Received: from [192.168.1.103] (178.176.72.240) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.14; Mon, 13 Feb 2023 23:08:48 +0300 Subject: Re: [PATCH 05/12] pata_parport: remove typedef struct PIA To: Ondrej Zary , Damien Le Moal CC: Christoph Hellwig , Jens Axboe , Tim Waugh , , , , References: <20230211144232.15138-1-linux@zary.sk> <20230211144232.15138-6-linux@zary.sk> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Mon, 13 Feb 2023 23:08:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20230211144232.15138-6-linux@zary.sk> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [178.176.72.240] X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.59, Database issued on: 02/13/2023 19:50:32 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 175483 [Feb 13 2023] X-KSE-AntiSpam-Info: Version: 5.9.59.0 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 504 504 dc137e1f9c062eb6c0671e7d509ab442ae395562 X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 178.176.72.240 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: {Found in DNSBL: 178.176.72.240 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;omp.ru:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 178.176.72.240 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 02/13/2023 19:52:00 X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 2/13/2023 6:59:00 PM X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/11/23 5:42 PM, Ondrej Zary wrote: > Remove typedef struct PIA and use struct pi_adapter directly. Prolly worth mentioning that you drop the spaces in the parameter lists while at it... > Signed-off-by: Ondrej Zary Reviewed-by: Sergey Shtylyov Had some comments tho... [...] > diff --git a/drivers/ata/pata_parport/fit2.c b/drivers/ata/pata_parport/fit2.c > index 28de8e4e41c3..020c93dea362 100644 > --- a/drivers/ata/pata_parport/fit2.c > +++ b/drivers/ata/pata_parport/fit2.c > @@ -37,13 +37,13 @@ devices. > > */ > > -static void fit2_write_regr( PIA *pi, int cont, int regr, int val) > +static void fit2_write_regr(struct pi_adapter *pi, int cont, int regr, int val) Could also kill an extra space after *void*... [...] > diff --git a/drivers/ata/pata_parport/fit3.c b/drivers/ata/pata_parport/fit3.c > index 0366f3123508..03f314ad5ee7 100644 > --- a/drivers/ata/pata_parport/fit3.c > +++ b/drivers/ata/pata_parport/fit3.c > @@ -39,7 +39,7 @@ > > */ > > -static void fit3_write_regr( PIA *pi, int cont, int regr, int val) > +static void fit3_write_regr(struct pi_adapter *pi, int cont, int regr, int val) Here as well... [...] > diff --git a/drivers/ata/pata_parport/kbic.c b/drivers/ata/pata_parport/kbic.c > index 9a99b9e35d41..e065f8367716 100644 > --- a/drivers/ata/pata_parport/kbic.c > +++ b/drivers/ata/pata_parport/kbic.c [...] > @@ -72,7 +72,7 @@ static int kbic_read_regr( PIA *pi, int cont, int regr ) > return -1; > } > > -static void kbic_write_regr( PIA *pi, int cont, int regr, int val) > +static void kbic_write_regr(struct pi_adapter *pi, int cont, int regr, int val) And here... [...] > diff --git a/drivers/ata/pata_parport/ktti.c b/drivers/ata/pata_parport/ktti.c > index d87eb3c139bc..bddd13b4801f 100644 > --- a/drivers/ata/pata_parport/ktti.c > +++ b/drivers/ata/pata_parport/ktti.c > @@ -29,7 +29,7 @@ > > static int cont_map[2] = { 0x10, 0x08 }; > > -static void ktti_write_regr( PIA *pi, int cont, int regr, int val) > +static void ktti_write_regr(struct pi_adapter *pi, int cont, int regr, int val) And here... [...] MBR, Sergey