From: Alex Elder <elder@riscstar.com>
To: Conor Dooley <conor@kernel.org>
Cc: p.zabel@pengutronix.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, mohd.anwar@oss.qualcomm.com,
lorenzo.bianconi@oss.qualcomm.com, danielt@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Daniel Thompson <daniel@riscstar.com>
Subject: Re: [PATCH 1/2] dt-bindings: reset: introduce toshiba,tc9564-reset.yaml
Date: Fri, 23 Oct 2026 14:22:02 -0500 [thread overview]
Message-ID: <cab7475e-8151-4843-855a-5aa47f75272f@riscstar.com> (raw)
In-Reply-To: <20261023-bok-thong-0181aa7f3867@spud>
On 10/23/26 1:00 PM, Conor Dooley wrote:
> On Thu, Oct 22, 2026 at 02:05:12PM -0500, Alex Elder wrote:
>> On 10/22/26 1:34 PM, Conor Dooley wrote:
>>> On Wed, Oct 21, 2026 at 02:50:41PM -0500, Alex Elder wrote:
>>
>> This syscon driver and "sg2044-topsys.c" are awfully trivial,
>> and they seem like they could be wrapped in something along
>> the lines of "simple-mfd-i2c.c".
>
> Yea, I guess there could be some sort of trivial driver that covers
> these syscons with match data that contains the mfd cells and is
> effectively just a probe function that looks like:
> static int _probe(struct platform_device *pdev)
> {
>
> ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
> match_data.devs,
> ARRAY_SIZE(match_data.devs), NULL,
> 0, NULL);
> if (ret)
> return ret;
>
> return devm_of_platform_populate(dev);
> }
>
> The devm_of_platform_populate() you don't need, but there's other
> syscons that could use this that contain subnodes too so might as well
> accommodate them.
I'll add this to an eventual TODO list for myself. I won't
get to it right away but I'd like to see this improved.
We're left with a little duplication of some extremely
simple boilerplate code.
-Alex
next prev parent reply other threads:[~2026-10-23 19:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 16:43 [PATCH 0/2] reset: introduce TC9564 reset support Alex Elder
2026-10-12 16:43 ` [PATCH 1/2] dt-bindings: reset: introduce toshiba,tc9564-reset.yaml Alex Elder
2026-10-12 18:51 ` Conor Dooley
2026-10-12 19:10 ` Alex Elder
2026-10-12 21:22 ` Conor Dooley
2026-10-13 13:22 ` Alex Elder
2026-10-13 17:51 ` Conor Dooley
2026-10-21 19:50 ` Alex Elder
2026-10-22 18:34 ` Conor Dooley
2026-10-22 19:05 ` Alex Elder
2026-10-23 18:00 ` Conor Dooley
2026-10-23 19:22 ` Alex Elder [this message]
2026-10-13 9:25 ` Krzysztof Kozlowski
2026-10-12 16:43 ` [PATCH 2/2] reset: toshiba: introduce a TC9564 SoC reset driver Alex Elder
2026-10-13 13:28 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cab7475e-8151-4843-855a-5aa47f75272f@riscstar.com \
--to=elder@riscstar.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=daniel@riscstar.com \
--cc=danielt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.bianconi@oss.qualcomm.com \
--cc=mohd.anwar@oss.qualcomm.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®