mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: chri <chripell@gmail.com>
To: "Jiri Slaby" <jirislaby@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] max3100 driver
Date: Mon, 17 Dec 2007 09:55:19 +0100	[thread overview]
Message-ID: <cabda6420712170055j78da46c8x6af50b095e3447c0@mail.gmail.com> (raw)
In-Reply-To: <47663726.3010508@gmail.com>

On Dec 17, 2007 9:45 AM, Jiri Slaby <jirislaby@gmail.com> wrote:
>
> You probably wanted to unregister it after _all_ cards are removed, not after
> each...
>

Hi,

thanks you are right. I haven't noticed this since spi devices are not
hot-pluggable so I could remove them only with rmmod (and so all of
them toghether). Anyway the code I sent is ugly, I will correct and
resend.

>
> Also you should synchronize_irq() after stopping them here.
>

I see. I guess I will have problems on suspending with serial activity
otherwise.

Thanks,


-- 
Christian Pellegrin, see http://www.evolware.org/chri/
"Real Programmers don't play tennis, or any other sport which requires
you to change clothes. Mountain climbing is OK, and Real Programmers
wear their climbing boots to work in case a mountain should suddenly
spring up in the middle of the computer room."

  reply	other threads:[~2007-12-17  8:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-17  8:17 chripell
2007-12-17  8:45 ` Jiri Slaby
2007-12-17  8:55   ` chri [this message]
2007-12-17  9:00     ` Jiri Slaby
  -- strict thread matches above, loose matches on Subject: below --
2008-09-20 10:51 Michael Trimarchi
2008-09-20  7:20 Christian Pellegrin
2008-09-20  8:24 ` Andrew Morton
2008-09-20 10:35   ` chri
2008-09-20 13:56   ` Arjan van de Ven
2008-09-20 14:30     ` chri
2008-09-20 14:34     ` Alan Cox
2008-09-21 16:09     ` Ben Pfaff
2008-10-09  6:23   ` chri
2008-10-10 12:08   ` Christian Pellegrin
2008-09-20 14:11 ` Alan Cox
2008-09-20 14:37   ` chri
2008-10-09  6:30   ` chri
2008-10-09  9:18     ` Alan Cox
2007-12-05 10:26 chripell
2007-12-12  9:49 ` Andrew Morton
2007-12-12 11:58   ` chri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cabda6420712170055j78da46c8x6af50b095e3447c0@mail.gmail.com \
    --to=chripell@gmail.com \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®