Re: [PATCH] perf/x86/intel/uncore: Convert comma to semicolon

["Mi, Dapeng" <dapeng1.mi@linux.intel.com>]

On 1/14/2026 9:07 AM, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.

We need a "Fixes" tag here.


> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  arch/x86/events/intel/uncore_snb.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/events/intel/uncore_snb.c b/arch/x86/events/intel/uncore_snb.c
> index e8e44741200e..3dbc6bacbd9d 100644
> --- a/arch/x86/events/intel/uncore_snb.c
> +++ b/arch/x86/events/intel/uncore_snb.c
> @@ -2005,11 +2005,11 @@ static struct intel_uncore_type *nvl_msr_uncores[] = {
>  void nvl_uncore_cpu_init(void)
>  {
>  	mtl_uncore_cbox.num_boxes = 12;
> -	mtl_uncore_cbox.perf_ctr = NVL_UNC_CBOX_PER_CTR0,
> -	mtl_uncore_cbox.event_ctl = NVL_UNC_CBOX_PERFEVTSEL0,
> +	mtl_uncore_cbox.perf_ctr = NVL_UNC_CBOX_PER_CTR0;
> +	mtl_uncore_cbox.event_ctl = NVL_UNC_CBOX_PERFEVTSEL0;
>  
> -	ptl_uncore_santa.perf_ctr = NVL_UNC_SANTA_CTR0,
> -	ptl_uncore_santa.event_ctl = NVL_UNC_SANTA_CTRL0,
> +	ptl_uncore_santa.perf_ctr = NVL_UNC_SANTA_CTR0;
> +	ptl_uncore_santa.event_ctl = NVL_UNC_SANTA_CTRL0;

Thanks for finding and fixing this hidden issue. 


>  
>  	mtl_uncore_cncu.box_ctl = NVL_UNC_CNCU_BOX_CTL;
>  	mtl_uncore_cncu.fixed_ctr = NVL_UNC_CNCU_FIXED_CTR;