From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756783AbcHBThE (ORCPT ); Tue, 2 Aug 2016 15:37:04 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:34039 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754485AbcHBTgy (ORCPT ); Tue, 2 Aug 2016 15:36:54 -0400 Subject: Re: [PATCH] usb: dwc2: Remove deprecated create_singlethread_workqueue To: Bhaktipriya Shridhar , John Youn , Greg Kroah-Hartman , Felipe Balbi References: <20160728082729.GA8746@Karyakshetra> CC: "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Tejun Heo From: John Youn Message-ID: Date: Tue, 2 Aug 2016 12:35:47 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160728082729.GA8746@Karyakshetra> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.9.139.183] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ++ Felipe On 7/28/2016 1:27 AM, Bhaktipriya Shridhar wrote: > alloc_ordered_workqueue replaces the deprecated > create_singlethread_workqueue. > > There are multiple work items on the work queue, which require > ordering. Hence, an ordered workqueue has been used. > > The workqueue "wq_otg" is not being used on a memory reclaim path. > Hence, WQ_MEM_RECLAIM has not been set. > > Signed-off-by: Bhaktipriya Shridhar > --- > drivers/usb/dwc2/hcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c > index 2df3d04..df5a065 100644 > --- a/drivers/usb/dwc2/hcd.c > +++ b/drivers/usb/dwc2/hcd.c > @@ -5040,7 +5040,7 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg, int irq) > > /* Create new workqueue and init work */ > retval = -ENOMEM; > - hsotg->wq_otg = create_singlethread_workqueue("dwc2"); > + hsotg->wq_otg = alloc_ordered_workqueue("dwc2", 0); > if (!hsotg->wq_otg) { > dev_err(hsotg->dev, "Failed to create workqueue\n"); > goto error2; > -- > 2.1.4 > > Acked-by: John Youn John