From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011005.outbound.protection.outlook.com [52.101.52.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF9EA3E0254 for ; Fri, 27 Mar 2026 10:45:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.5 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774608314; cv=fail; b=o2/hnQkQbJyDRuS59OI0JbCeZtSX6rcvqIzszhfiiUgk9w6PEofupWYHibYEtE6VumxERntwHPs7VHXqJGwVPA3e6/fEKRphh4pljmLA5KIYy7vvWL4zQFJu5gfPadWYfLn529vFFAqG7x2fBJuIp0VOb5U93OT8+R24ucITDjQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774608314; c=relaxed/simple; bh=yGhRvtD1PQKn1C6AH01iVEWkoKhVuP4FJmEF2KxXz88=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=qEkiBjXzVQmKvu0xtp1QiWAzie9osVzfCChbT5lz1exZGvohptMM+ji35jesW2ePhaTI5OfpXXYmdoKPuN12QTmER2FF7uiWDn7SZ1HUK+iqRQd1qPuBzm0ZvKqQ9ogJELrerDFpqyATZ5Mu6mQqoje+FdmfhCdn12MGEHLWy28= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=bmNn1VHM; arc=fail smtp.client-ip=52.101.52.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="bmNn1VHM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bnf/Ly3qIyDV80osn9+s0CD9G00328Ymb0lUymMzULwJlv7YvYpahpFFD5mt6B0Q3aXtwJJh7s53ML0N1PDTX/qKW6qiRpa0LM7UOURQxTfvKnukxnAk9f3suhp9PLu/z3TmbWfwhgHzOiGjVUnk9CDm9y68wjccvzPriv25X0c3dYIf8EfNmhMqcp81EGko3XmGXbv0Kd0SlNWOzX5oc2sxulm5LUO3XqQNeipdRlHGouYFsD3EFQMFQnnwtV/+IySdUAA6nN6rb6BXIKmvvBx7O3JjYqQzY2mqOqSflQgcovSmbrQWLl0Ms4La+ZS2F2gSV0v0h6vGLbl6kPb14Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SBo4gmGH23ge0TV0V+DESFXYZlJc6tZqZEZnZZqQSrs=; b=NKvzTxCPoRgRCTbCmFqHhq4aQQTbSsD1oMmg2MnbTAyy7Xr+8Pnpl6aqyvEmPCWqkupX4KmebGuZjmKPhdisWB+ZahjuK0d6TCej1YdQRzU3tjS1ijwgpdkNsF2WWYwP7vKUAJcT8WmbrClT37Hke8zhneU/GgTvKrMAkI9vuYbQANFDx5fj9uYpgFL4aXCzrEGnKpHd9za+HshuN3p6o7j96+UPfEWrZxxlAHMyPO0uAQaw5+V/fcpHrTi4pC4XUz6IVKx8Gah1y6WX1EOqkcIgYqRMVbd+3fWcTgokwrG67EDn+O4X18u/XP2KjKyswRsoPzCnwrsG/sA7NP1WHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nvidia.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SBo4gmGH23ge0TV0V+DESFXYZlJc6tZqZEZnZZqQSrs=; b=bmNn1VHMWpTzC3A+KVntuuRRCrCUL+IiVmif1iPK6c0Dvf+0He6mYY5tszveFUQ7t8m8XtgCSjWBcztaSfjfcGe1ZODab83fCFPz3yobLBsdWTGfbmb3luH9RalNpMCJf6ZRIWzNAHDEcfrUkm+HikLZLwcyT/dhY8MbLVFrwFs= Received: from SJ2PR07CA0024.namprd07.prod.outlook.com (2603:10b6:a03:505::14) by MN2PR12MB4334.namprd12.prod.outlook.com (2603:10b6:208:1d1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.10; Fri, 27 Mar 2026 10:45:08 +0000 Received: from SJ1PEPF000026C5.namprd04.prod.outlook.com (2603:10b6:a03:505:cafe::85) by SJ2PR07CA0024.outlook.office365.com (2603:10b6:a03:505::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9745.22 via Frontend Transport; Fri, 27 Mar 2026 10:45:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by SJ1PEPF000026C5.mail.protection.outlook.com (10.167.244.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.21 via Frontend Transport; Fri, 27 Mar 2026 10:45:07 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 27 Mar 2026 05:45:02 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 27 Mar 2026 05:45:02 -0500 Received: from [10.136.39.136] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Fri, 27 Mar 2026 05:44:59 -0500 Message-ID: Date: Fri, 27 Mar 2026 16:14:57 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] sched/fair: Prefer fully-idle SMT cores in asym-capacity idle selection To: Andrea Righi , Ingo Molnar , "Peter Zijlstra" , Juri Lelli , "Vincent Guittot" CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Christian Loehle , Koba Ko , Felix Abecassis , Balbir Singh , References: <20260326151211.1862600-1-arighi@nvidia.com> <20260326151211.1862600-2-arighi@nvidia.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260326151211.1862600-2-arighi@nvidia.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000026C5:EE_|MN2PR12MB4334:EE_ X-MS-Office365-Filtering-Correlation-Id: 087b6ee4-7fa8-472a-e61a-08de8bede9b8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|7416014|82310400026|1800799024|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: vNBGkTd5SlV5k2YqhQ3CDbSX0ePiqdt2Dt1V0moz2o21/t0dz7JqAfqmYdqS6kXqYNM+V4/CIM+t/doy3Nwwa12E7aMD7Le8batCU+fiYIv95bRZkZ+tdbP3U3nqh7p3RBrg7ncI3dsleM4aW9UABPmYjuWd81MTFTFYeCwhe50aTHjxeINc7V/j8vaIsbBHhbedoCC+kyomdsmkGipUsPaZg9iBNd3dk1jdHqwoWTe89EmiDEj84+ERtPdwUeQm+bTA55s3YGTeWbJjEurdPyTvaWfsoX/dYAz0p3EZ82JxKfIArKAhnhuZsmWn4XKoGGrMgX3trbn4+GXxIW4ArG9QS1oWOYUCu8bcIZQEYP1D+8/vP5Yq69xi6/fD0GrlUZMXhrwPh7VcmNpGszBsiSiIMcSX5AaNXWWgnn2dNaAPhflU800mzsVAxHvUuAzcPvhU40WbPg0/kbv9KVNx6ZVGLi5iUZk13Lw/wNxa7NNGhMnY/Vff76MQqMRmBzETw7aNVemeGJQ4dhYcDyh64MS1ybm3SE7isp3x/G6y8npecQbNsM59jrqQY3YtOZOIwYvrXqAjIf+atUs6Wjjuq61njx2tc/SUok+rbdVP1xa7OYITs9pI81Ud20uB3FPPEI9+gxZIPd6QWF0ENwbLFwJrE0eUPFUb/Dvq+EGVA/+a14r8U8M28OjVLn/ChLR3T3TyBkvdutn0/lewAPEspcV7xSWZNDCsKc9uaRoNPK4sUTl/CvZnedDo+g4qsZ3MPnexjGpSnTRWKNlFCVehSQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(376014)(7416014)(82310400026)(1800799024)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: omIL/GnCRcQo0YF26O95HJ01q69GtN6x5CD+Ap79J19ahGFB9e576XJ3I+arimyNP0MUZJTGDnedFpMxVsXK66oOQWzkPxu1SkG2w8zZ+jQLxk3QNO040+Di48Z2CR9xkJ5jAeAu6H6PIjidXEV7Gy+xP4pHslJSFKt4lG15zr136hvVgOQGGTBwwE8oHcqKIYWbl4sLIffwnUawY0/BAq6ebbUuUcgTiQ4fai9/GUARJB0ciiGDh+Hxo86uXedVjR+HjjHmRYTSjpGAZqhsLpGrjIWPj3vDRbkzY/odd/gSszpm6yslr3BOVqc2VjBR/iDtYaF6XzXJGuG2cVOeb6M90G7Mec9KmWGI6KN7kR+mRNoKMOkCBSk7KW0Y2TQsf39N3EFPuWdMLkB0o2pq7CO1hhuFnVLch3sTAfRe+up9q8Z0IkHtSQ5VyVMi3qQX X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2026 10:45:07.6562 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 087b6ee4-7fa8-472a-e61a-08de8bede9b8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000026C5.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4334 Hello Andrea, On 3/26/2026 8:32 PM, Andrea Righi wrote: > /* This CPU fits with all requirements */ > - if (fits > 0) > - return cpu; > + if (fits > 0) { > + if (prefer_idle_cores && on_idle_core) > + return cpu; > + if (!prefer_idle_cores) > + return cpu; nit. Can the above two be re-wittern as: if (!prefer_idle_cores || on_idle_core) return cpu; since they are equivalent. -- Thanks and Regards, Prateek