From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 603AA1EB9FA for ; Mon, 2 Feb 2026 15:01:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770044506; cv=none; b=WF8BfgEqnLNmTZA6zX958p3pt7Vkqpj3WenTiahQrNLFmi9KtppVt98IvW9do2L9IyZrnR0dK0KJ+07SFf8EW0wgYKfT5Enjwp8fPzjJL40JhhLxLxs2jo102VThSNBJSsP3dJH7FmdYGL//QFzaB9pxld97+51pSl18w7KiWCA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770044506; c=relaxed/simple; bh=JcxIl+U6XrrYzwzysRKriC7B7jJmpe/ag7DnsCLo6KY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JVaA+K53E157v52dy8Fsy9Wj5UjPz4dKeISRQKE2BXSMFzIjJX1I1PZF4MbHMt3xLaSaJ4uwxRavHGJD+Y2zXQ8edPw+sD7K8boWhDeDmsnFaVYgoDVDFJd4YfwiyL5uRlG8Xm6B7jI08q2UmQ7OyTHkZyOTq5a7+khrB1eVt4A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GtaZJJNF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AblAgGM2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GtaZJJNF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AblAgGM2" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 612CVJDt2356979 for ; Mon, 2 Feb 2026 15:01:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= b7LkWBSg9k/hqZXrb855SBQlwZa3bPE252WnYqjGZpc=; b=GtaZJJNFInkB0nDH 54tU49dyHv+VRHJZVBVJMVqJVvxuHoy1ovO4QvYQfZfGdsGfExvWo28Un/bDUCk5 VKxVX2OW1YQnzWUG9zpQkzbVrouNacirwHDWVQItC3VXh46cmsOlYkcgvPKDkcut 5fjMcnaME0scGguzeWG3lvQdQsudjNlzePnArMMwXC4ux0kXQKS5WPZoF2S64/iT fk/2FcJZ6/Y6ZQZiUqttHbdeyQeXljEK2HBkEPtbjVxMLv4Qg5uGQEOeBJ4a93Vz pSsuSXAlg6LQYi4O8n+B1BwjGjUKv/X8dxuXJfgZwprHwaJ7P23ycrkSogrria07 h6XDMA== Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c2v0m8d6r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Feb 2026 15:01:44 +0000 (GMT) Received: by mail-oo1-f69.google.com with SMTP id 006d021491bc7-6610249ef97so953691eaf.1 for ; Mon, 02 Feb 2026 07:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770044504; x=1770649304; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b7LkWBSg9k/hqZXrb855SBQlwZa3bPE252WnYqjGZpc=; b=AblAgGM274VEbWYjs/UhCbYCGtZPQe/YGUiPcBm9cUhrYjyWsNNJrVebLVZGqqjPhG xUqdUMWmjeQKKFQAFKc6klct+3n8OTqJ54+GNSVzbrdv91d3ujqwQAFc0rC4xZxpCY0l Oo2RKwP1QwM/QxbsvGBYdqYX/gxJi269czzwX3FEdhFBl/DMgP7lBesf6m64kee5cQDI yr8gwUKeb2nGO5Itipe4uTIdHygEpcMIY8JI2ClQd8efqdp7WwL2XVKcARAnD6gvIssb 4yMlEmiEMoN3xL+Q3r2t4lmSkSEP6x1/SLvjFt4To7C0vjX69fKEWI0mVdAMIH2flXCR DLkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770044504; x=1770649304; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b7LkWBSg9k/hqZXrb855SBQlwZa3bPE252WnYqjGZpc=; b=vNgjGTEG9aqxr/Lhxy/xNZjLhYfGA3w34uL8GQF9C8eGTXBt70a9VSNI/qWQBHxdFu 7/ZWrK/juPXEEEE8jriDhk0aI9nToMURkIHgM7kS4+MfbQkCQHli9S5+fpNPMNE2RD3s AwlT9X5bNcVKRZQb1GkCOKOazIBz7hKwHsQ5ZACauq0OzXdHxeDAY+zsFyxbfzslhyfR nP0Ph743/gpoXNlVJeu0FU+66fROilktzOVI9b9KlFSmpBQmE3nIaORm59Ii8p8tZApE 7GF+MGowPshz94gcHJXsuhKop6tT2RkNLIdIDGQXG56gyP1iwqsD5Ii79myjqFB+9igX qYMg== X-Forwarded-Encrypted: i=1; AJvYcCXMXpMB3/ukIMkadq27VPrf21RDmDqt6Obh9m1XIbR9gdrasdxz/1yuJPeMpqtzwX4WjvCK01vN/V6qXZU=@vger.kernel.org X-Gm-Message-State: AOJu0YxsvMS7YafIMFYGCW8bN8RkMsz2qFue9NvbxVQPAQGWDaLubBvN E4OV5TGx3V50QTz+N5TounbxQdTIaoi+3lMHTIfZ0R8fSggw2UIyBFopX9KfwMuCQW2e84PqbbG mC65k8x6I6Yl6gVASfHsuNxGRR9D10vrscl/3f4MuKO6WSjPJfZkOt7YgYimRpkeg5T4= X-Gm-Gg: AZuq6aLhhuduI6URyrHE+AbMGrziKE7qg6WRODhrSAabmnv4IVWxVsmbr+ONbogyFuU 0wCFscRu9abOCCiBQCtAVnNRcyMy/d257aHqgqLE7mZojKLMu3euifWxHEKKgcA07LtC9pCZYj/ 99T4Akmvr7ERx5vFNsw7DM2DHu951m0X+5RyhRZT6Lnp1+/KYtLPxfCdxuceduPl3yc4ql16pTU vTza0caeyLg8V/rN1p8qY0J9EvD49k+6LriDwyYuICrS+10RvKcDYukK8GHLGqbI/Q/TyzlE3Za Ze5MgkR//wRbYwMr8jOc4yqX0x83sq/NfS4djZEpMiY6uJ+2OIUgKB+KF+Cg97+nYPwOrEXilbp 72leX4itYEFmLlTQ9tl8nFHxjsbBeJvA5lzUoHIEfRWahRRfItb98L2+CmzWVW81rZjM= X-Received: by 2002:a05:6830:4124:b0:7cf:e23f:5ae3 with SMTP id 46e09a7af769-7d1a525f7acmr4859568a34.1.1770044503726; Mon, 02 Feb 2026 07:01:43 -0800 (PST) X-Received: by 2002:a05:6830:4124:b0:7cf:e23f:5ae3 with SMTP id 46e09a7af769-7d1a525f7acmr4859515a34.1.1770044502743; Mon, 02 Feb 2026 07:01:42 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbf2ecc73sm897795866b.62.2026.02.02.07.01.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Feb 2026 07:01:41 -0800 (PST) Message-ID: Date: Mon, 2 Feb 2026 16:01:38 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/4] Enable ICE clock scaling To: Abhinaba Rakshit Cc: Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Neeraj Soni , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org References: <20260128-enable-ufs-ice-clock-scaling-v4-0-260141e8fce6@oss.qualcomm.com> <7b219a50-6971-4a0c-a465-418f8abd5556@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=dceNHHXe c=1 sm=1 tr=0 ts=6980bc58 cx=c_pps a=lVi5GcDxkcJcfCmEjVJoaw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=fQ1HhNXxD7se1t-yopsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rBiNkAWo9uy_4UTK5NWh:22 X-Proofpoint-GUID: FmwzrcDlU-DyTBQRQ5MgtNKqs3O-F7Ny X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAyMDExOCBTYWx0ZWRfX0u18KyJ98bJM KSWXsha+AoLr6sTf6dUgpf522rKMt7SXOhaCxIEeRGXH7KzIuqGCZRcxrCF+8MjYGWhbiMJcTQ7 mUrVKWSOfeybcC35hr1eE3+mi2A4NzNXm+rw2q5XGwyfvDqBQ1ylFMzj+1u+GaUDqJDLyiAlI3Y GQSjjPWBXVnQeYvrmOJRvmJGD+OCQEjSU1s3vFd/MGL0wlRA62Ag691/5L2pIxK5buBQ0kQcrCV dzGJBv/Po23Hc7uPDLZzGWnrgul5PmJAcgQYvHqBrDusy/9S89Ohcnysf1eQCj0zyyZLHQyzoyN fbD0Ph5S+zM1sJlL717oBhijmjFrtrG/WQbeIEwkgcxwARXfftTzCp4xYjS+zV1866AmKa1yQKR QQKNW20AOV1ldpmzXtx1ad3tp8GM0L7mi5bYfqb+j2HZg6mZ48+jBwAdZWskl0ByxJe5upgMNxY 1B31jxBJ/krLK2t0esw== X-Proofpoint-ORIG-GUID: FmwzrcDlU-DyTBQRQ5MgtNKqs3O-F7Ny X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-02_04,2026-01-30_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 phishscore=0 bulkscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602020118 On 2/2/26 7:36 AM, Abhinaba Rakshit wrote: > On Thu, Jan 29, 2026 at 01:17:51PM +0100, Konrad Dybcio wrote: >> On 1/28/26 9:46 AM, Abhinaba Rakshit wrote: >>> Introduce support for dynamic clock scaling of the ICE (Inline Crypto Engine) >>> using the OPP framework. During ICE device probe, the driver now attempts to >>> parse an optional OPP table from the ICE-specific device tree node to >>> determine minimum and maximum supported frequencies for DVFS-aware operations. >>> API qcom_ice_scale_clk is exposed by ICE driver and is invoked by UFS host >>> controller driver in response to clock scaling requests, ensuring coordination >>> between ICE and host controller. >>> >>> For MMC controllers that do not support clock scaling, the ICE clock frequency >>> is kept aligned with the MMC controller’s clock rate (TURBO) to ensure >>> consistent operation. >> >> You skipped that bit, so I had to do a little digging.. >> >> This paragraph sounds scary on the surface, as leaving a TURBO vote hanging >> would absolutely wreck the power/thermal profile of a running device, >> however sdhci-msm's autosuspend functions quiesce the ICE by calling >> qcom_ice_suspend() >> >> I think you're missing a dev_pm_opp_set(dev, NULL) or so in that function >> and a mirrored restore in _resume > > Thanks for pointing this out, its an important piece which is missed. > We can use dev_pm_opp_set_rate(dev, 0/min_freq) in _suspend and restore the FWIW dev_pm_opp_set_rate(0) will drop the rpmh vote altogether and NOT disable the clock or change its rate dev_pm_opp_set_rate(min_freq) will *lower* the rpmh vote and DO set_rate (the clock is also left on) Konrad > suspended frequency in the _resume. Something similar which is used by sdhci-msm.