From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751869AbcGBIGo (ORCPT ); Sat, 2 Jul 2016 04:06:44 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35116 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751130AbcGBIF7 (ORCPT ); Sat, 2 Jul 2016 04:05:59 -0400 From: Salah Triki To: akpm@linux-foundation.org, viro@zeniv.linux.org.uk Cc: Salah Triki , mhocko@suse.com, vdavydov@virtuozzo.com, luisbg@osg.samsung.com, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] fs: befs: Remove goto from befs_bread_iaddr Date: Sat, 2 Jul 2016 09:05:31 +0100 Message-Id: X-Mailer: git-send-email 1.9.1 In-Reply-To: <9859a616787673d2f36ce21d4aa0220637c55001.1467446561.git.salah.triki@gmail.com> References: <9859a616787673d2f36ce21d4aa0220637c55001.1467446561.git.salah.triki@gmail.com> In-Reply-To: <9859a616787673d2f36ce21d4aa0220637c55001.1467446561.git.salah.triki@gmail.com> References: <9859a616787673d2f36ce21d4aa0220637c55001.1467446561.git.salah.triki@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since goto statement merely returns NULL, replace it with return statement. Signed-off-by: Salah Triki --- fs/befs/io.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/befs/io.c b/fs/befs/io.c index 4223b77..af631a6 100644 --- a/fs/befs/io.c +++ b/fs/befs/io.c @@ -37,7 +37,7 @@ befs_bread_iaddr(struct super_block *sb, befs_inode_addr iaddr) if (iaddr.allocation_group > befs_sb->num_ags) { befs_error(sb, "BEFS: Invalid allocation group %u, max is %u", iaddr.allocation_group, befs_sb->num_ags); - goto error; + return NULL; } block = iaddr2blockno(sb, &iaddr); @@ -49,13 +49,9 @@ befs_bread_iaddr(struct super_block *sb, befs_inode_addr iaddr) if (bh == NULL) { befs_error(sb, "Failed to read block %lu", (unsigned long)block); - goto error; + return NULL; } befs_debug(sb, "<--- %s", __func__); return bh; - - error: - befs_debug(sb, "<--- %s ERROR", __func__); - return NULL; } -- 1.9.1