From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34CFB327C0D for ; Mon, 8 Jun 2026 09:50:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780912205; cv=none; b=GzDtb14zi/c828W5uxElOi0NuVkouybrCLoVdQ5bwKM0mjiuAmfaoqyW6iVGbCRLPafCX6nymza58O1St/u6MEnGjTKFrxTrUevSZSqAOtCyHOUrX/HeFczI3r2ZiYFYNaX9/+PYgUEUiWHU3W5lpqK6HxDL2y8JVjqYdbmOcPs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780912205; c=relaxed/simple; bh=WdGkYj1iMir25SymT1Zkxa2jedNiiwUmRZyq/YzJTKc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=thRT4InG+Lebh3keufAEV64GJCTDLwnrMmKuaJbF8dt4zTBy6V93FuOxRbIeSAggXLclk2DthoZVU7Wi3LfIdKAqYY4N/4oK7/hFxWO/q5yS0JL2LE+ONv9wGN//IVui2+MAnnI8H2lM5OgdH+vJ2anQM1hYkUkP/XG8OkiTN8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eP3/BhXl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZLEBJ1XO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eP3/BhXl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZLEBJ1XO" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6586P2XW2833646 for ; Mon, 8 Jun 2026 09:50:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ySGMNnjP9XasOhRO0MU4TCjJaviX/cKXx1iwvpCKtck=; b=eP3/BhXlTh1U/2Dk VYCfaccSUsrkdgAjLx7JC5cAfFWAn2OAJV9lsz89JAzS1jjpRgXuF+ao0Xb/WLTg 6FQiW+Z5T2qW6pzayQbEWlNi6nuQxx4j3MyppO1Gw6zMZfplm864aDThMSPO9U9G iJGuL1/IZyBli1BOA6oeWR8YVURZQu410MqdmaZ3BulCaDNuKOp1kTLAYJE5LyWN mgQRy3Pxnd/2PrjBL5c7+g/jd/LOZ0OeWAnRBpO2b7Qm6/Nyu1nhuQXMaaHVqyQn U/KchKf0P/3IBM8xyzjy+hpQ8mH5qXSd4hJ3IUOspqeP58Ephc3chRF/y7orQiUY 4e48+w== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4embmrf8k8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Jun 2026 09:50:02 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5178ac43d27so11560531cf.0 for ; Mon, 08 Jun 2026 02:50:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780912201; x=1781517001; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ySGMNnjP9XasOhRO0MU4TCjJaviX/cKXx1iwvpCKtck=; b=ZLEBJ1XOMuYQFzo2bCDgYwiI5vDJ+7kDHumjKJj5nGZQc9WDlFsrNMmtl+0nGnqhDa HjPlNEejn49s/H6VFOgquD9gK6IS7pUzz/dc4LfwptdMxpADsMM+PXy0tXxSEHiTSjdp OZ03YBuVd5lX3UPUr+4jW/ObcbT7VWfSPH9JeTBm1vKuSoH2MN1o88NDirNt3/Ls2Akp NxdAjG3tKi2rXiD3dmYsxArzTd6MncOzAsN/T6QEaEVY8b1sO2VG7C86Kl4vzGunMyRe dD4qkr/JJ5MaVp2VvSWR1uhV25BSpJaPdihJ47c0m+5jB+i6rBuAi0fkyxeNrjXWgams 0FOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780912201; x=1781517001; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ySGMNnjP9XasOhRO0MU4TCjJaviX/cKXx1iwvpCKtck=; b=nScyZYEFdKHITtaXwDsuEYrnEWPSwXCFa/jLSpxuQhMVDr93OIOUTVwWbSeU73zVH5 N4QPqx9uG6drHOx1zeAhDiVWsyAnhWpWsGGICZ2ePfYYjObTJ5mJvXYTUh27O4454L4P MiyIYs6t756aQcgYshQqm9eX7JEhK4Odks3Lg2ZwGTGQ2aZRCjAkLJn8nOrrLljQpVSg l/Sf6jitSKvxjTUcoPHk/hAmToLIabS5lCqQdOW1NSN+c9/24QDcqqKGvYqS9X3abo14 9cSLehmzoCNrY4ttNq0PLIM4ZZ0pkFEchs6ran00SkEq+S9plmVCcPHojR+ldSlvzy3G Zp5Q== X-Forwarded-Encrypted: i=1; AFNElJ+3hduzkOKRm0wc65g9Xj4d72SS2wpJtZLgarsBed9TmxeCFA7702G3S6zN+B/EnCs7dolgErdlhV7e57Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yxsjs+YjRUC+sDTqlqrEZX44QQVKMD6Q740b+fqYZqa1w/xSMWS 5T0+SuyGlIUKP/3JAHezw7CF4pxnblQqN1RVvCy/9Lp7vsODL8PR73SNbxq9ZRH2pl8bVcrScjk DojSDD9JG2NaeHF0/Qra213zKjNKYlYt4hCTw8WjEetji1Nsczron8boXGn8KQ0ijDPc= X-Gm-Gg: Acq92OEUN7lFmQDamh0f9dS3yh+/c588qFPhX/VeHnuxJAT2j6F59s3F4TaXGetCdGU i7rBKAJbzJCpJoB78wL4D1GqPagTOvnbMfUq19e1Axj+5Tf9dHkyQDGDHXZXVb3rSdvqYBXkVzK WE0Ej8g9wmk0bwd3/YNnanERV4Zo0yaFYBiZ3MqVCythk7s13XdIaQsxkHcI5uNKzs7VfVZ+cPl 1hmuODotJCf7n53eRKlptN6R0chTSq+v5iQXLLksuu6im6ugK11tvrx6sKkIpdWQmP6SeBaBA0p APX5ZENseWArE3SCn4YHYNXfFqQ3izTqyXWUMXQ9xRfTHLsvSu9D1GagecGuOz8acsf62IcrbuX IEmo3nn+1ayttCIGyE9dB5tux8Jvf45F0t2cQ1udUIGz/HtIVWNBctUtm X-Received: by 2002:a05:620a:45a4:b0:915:2b2b:fbdc with SMTP id af79cd13be357-915a9c41cbemr1418291185a.2.1780912201638; Mon, 08 Jun 2026 02:50:01 -0700 (PDT) X-Received: by 2002:a05:620a:45a4:b0:915:2b2b:fbdc with SMTP id af79cd13be357-915a9c41cbemr1418288385a.2.1780912201114; Mon, 08 Jun 2026 02:50:01 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf054e0280asm839231466b.33.2026.06.08.02.49.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2026 02:50:00 -0700 (PDT) Message-ID: Date: Mon, 8 Jun 2026 11:49:58 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] ARM: dts: qcom: msm8926-sony-xperia-yukon-eagle: add initial device tree To: Erikas Bitovtas , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260603-yukon-eagle-v2-0-f86b440583f5@gmail.com> <20260603-yukon-eagle-v2-2-f86b440583f5@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260603-yukon-eagle-v2-2-f86b440583f5@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA4MDA5MSBTYWx0ZWRfX4wCikErKv+yh C/CRneP3NO9cx36PBMW2XBCwZTpnBG0Jg51h6JV7m9y/rH1hIAJCoNJu38XUw1pHJ9F7Gt79ep7 i8IkQ9JMYWKotmRdricD32XBZrZv6xuwwPUXTw1kaWYAEwJvJUb5jAUc7OBhmx4QuvWhTGEHQKM 2ogZ9okRyPM3D2Qu/uSRZH6nWTsnkj5Idskis+QtTQveXYUfw7aTgRo1pogGJp8BPjFW1+mRFbz +P+6rMmjwjYT5AjMEHN6+3YZPEfONiU1nP7kMgv96L+dD/Iayy4mR8ZzouEqcDPBK9X7d4P/E5b DPzIWv8G6wvwVp+qUF2zhsofz3uuJpkj4rbhloHanJUIOFz5oABljF0Csoe4IwTYa49/glXo6TA MK+IR+VzuiAEu+pV5RxLIPpN1CwGlHcgfk+tyNnq3fiQhoSX6MOE0qVySSM9yUrZ5QqrtchQWh0 d/wKI7re16bYhYhSdgQ== X-Authority-Analysis: v=2.4 cv=B5eJFutM c=1 sm=1 tr=0 ts=6a26904a cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=CQAop9hJs7bg5q8h2RUA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: kWfyzp96kiDw1GFrfUb_lvXbzUL73pL7 X-Proofpoint-ORIG-GUID: kWfyzp96kiDw1GFrfUb_lvXbzUL73pL7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-08_02,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 spamscore=0 malwarescore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606080091 On 6/3/26 5:48 PM, Erikas Bitovtas wrote: > Add device tree for Sony Xperia M2 (sony-eagle) smartphone > based on the Qualcomm MSM8926 SoC. > > Initial features: > - Framebuffer > - GPIO buttons (Volume Down and Camera) > - Regulators > - Internal storage > - SD card > - Accelerometer > - Magnetometer > - Ambient Light/Proximity sensor > - NFC > - pm8226_resin (Volume Up) > - USB/Charger > > Signed-off-by: Erikas Bitovtas > --- [...] > + gpio-keys { You should define a pinctrl state for each button, to presumably configure pull-ups as necessary [...] > + accelerometer@f { > + compatible = "kionix,kxtj21009"; > + reg = <0x0f>; > + > + interrupts-extended = <&tlmm 49 IRQ_TYPE_EDGE_RISING>; > + > + vdd-supply = <&pm8226_l19>; > + vddio-supply = <&pm8226_lvs1>; > + > + mount-matrix = "0", "1", "0", > + "-1", "0", "0", > + "0", "0", "1"; nit: please align the "s other than that: Reviewed-by: Konrad Dybcio Konrad