From: Sinan Kaya <okaya@codeaurora.org>
To: Randy Dunlap <rdunlap@infradead.org>,
Eric Auger <eric.auger@redhat.com>,
eric.auger.pro@gmail.com, wsa@the-dreams.de,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] i2c: fix ACPI_I2C_OPREGION dependency
Date: Tue, 2 Jan 2018 13:19:49 -0500 [thread overview]
Message-ID: <cad432e6-1722-3080-0266-18629be56e83@codeaurora.org> (raw)
In-Reply-To: <48ff2e75-5ee0-5ac9-8d47-58c3c691ad6e@infradead.org>
On 1/2/2018 1:10 PM, Randy Dunlap wrote:
>>> config ACPI_I2C_OPREGION
>>> bool "ACPI I2C Operation region support"
>>> - depends on I2C=y && ACPI
>>> + depends on I2C && ACPI
>>> default y
>>> help
>>> Say Y here if you want to enable ACPI I2C operation region support.
>>>
>> Anybody picking this up?
> Well. It looks to me like the patch is reversed or the patch description
> needs some improvement. Or I just don't understand it.
I'll let Eric improve the description.
Issue is that if you compile I2C as a module, ACPI_I2C_OPREGION doesn't get selected.
Therefore, any ACPI opregion calls targeting I2C fail with no opregion found.
The goal is to select ACPI_I2C_OPREGION independent of the I2C module type selection.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-01-02 18:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 17:05 Eric Auger
2018-01-02 18:07 ` Sinan Kaya
2018-01-02 18:10 ` Randy Dunlap
2018-01-02 18:19 ` Sinan Kaya [this message]
2018-01-03 13:39 ` Sinan Kaya
2018-01-03 14:03 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cad432e6-1722-3080-0266-18629be56e83@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®