From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 909B830DD11 for ; Tue, 23 Jun 2026 16:11:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782231099; cv=none; b=Q+2XNx0SE/F5ZBUL/yAynLottvux40VFKU7HP0oD5qMv7amRlqaYXpXEvoAkAodD4MoMBJUsVdCiQQ8H7356HuelzkieHipskmjXQrH+xA/nqIjEc90o5CPhjtMBJlIeQakrPFpGoL2XMC7zDCIY9q+EFDViewWP/oIkdhvJrhI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782231099; c=relaxed/simple; bh=F15rI8raRRwQYsuXkvJxdAImYFQOYUO1jCX9P+4euHo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DhjH4Bird369a25ulo3o0EvPOuIVW6FtcETQiqpb1f9+KfhmTbOy5BdmpcJQ3KLR3PvYt3bmytcptzRJNBqn1ILZM1ca1bS8knjG5c8OU1uds74DS/H2KXf2Cb+E1MVvW29jWjcEXzHlAcvJfQAQ2iTk9S7hXm72n4H3VlTk05E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ucp9UF/E; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BMWlnkT8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ucp9UF/E"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BMWlnkT8" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NBZp7K4053103 for ; Tue, 23 Jun 2026 16:11:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cWalCLVslZDoTLDQCTyjSJkS10gzwkPB8ybj9bURY90=; b=Ucp9UF/ETlvAr9Mu 2PMuhoM68GUVa51d/R2sXZipIn2l0dDOkjXSCL0gJeJj60pS/ew4fCsvHIskVJco IkLPK5IWmGI4hpA4HjmPT7woR+7BpQhjB8+Fp6K5nnIv3vcWdBsiA/i1QyiPlvZV 7OrXw8LctvIWw7c2lUeOM/lnkyJlB0krYLRayWUkpVsg0EhfbJ6hqooo2iZd/j4Y bOg2MZGAvpmJaOs4mMTzm0Z5FJkKxILFtm8VSaMDnRh7rFDtTF6PxehUPDhtcYFm H0hZP3n5437HwrWpgfCaBqGrzObKV032H37vawL7oAV6sqX/dXd2WiIbXwJYApQp WdRSqA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyr9ysebu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 16:11:37 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5198e72249dso5060291cf.0 for ; Tue, 23 Jun 2026 09:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782231097; x=1782835897; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cWalCLVslZDoTLDQCTyjSJkS10gzwkPB8ybj9bURY90=; b=BMWlnkT8n0jtHq5E+O5QpW7lOhWXD+umzXCDu72MfKYb4YxAxgqc4HqFs6DmwlTlWG /RaHAe75v2WuxqVc3LTgTKVcJXizxdF8//XDeUhFrjBI+s/DL3fH/8OW1cc1u3Eb28d2 rgfB8tJnc2L9O3OApHeXg9Y0i/1kBoZeiG9O6Dd1E3Qj8hBofUTBrPelKvzGWlI2AGPX eg8W6+iQBG+T91026IocYSIOydLPXWAzFHwBIFEdCzSAasIPvqj/9s1BA7LpV3+VcWPQ ynYSc6dIUYqiBsAMdOkfe6oROAeu8sFAh0Xm9KVfWQj2ZoUx9olGuh+TikzpR7muogTh D3RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782231097; x=1782835897; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cWalCLVslZDoTLDQCTyjSJkS10gzwkPB8ybj9bURY90=; b=i07mxTgEjmr2GyJeTsDE8Kq/vNIMfEHQeZXOsF+ZyFUWP7HQrqnV2xxWtqdlYzbR/H RWSC24Lwjc+zA6h9dKeVzE5yjd+eJhLKUcH0RygVe5PwgoKZXNLAZlVz83/rS49z4nGj /5KVfDNqSg5MtxN1uMkknbUNviMhyLwgJaCEI1eeM3i48st8jnNlXvrhU/KlD1RQThRb 7zQYwXd4AEsZlTwkX3UkTlN97GsX1k0iZH+XhrBDgI8nYzdOQOs8be14f9EAtFeteBGl A5OrjCp5zgNgZr3s0HM1XRyLBcYZpCC8S6dat+C00ZdU9XP2J1ZQET6e/x3/mvYF4o5g JZbw== X-Forwarded-Encrypted: i=1; AFNElJ8rncFlyZsCffYQfrOm1+PHitTH2F6wyI4VCIJLAp2NtRC1Q0FzxHT8oPwm/rQL4bFmTGfg3wyLimniiTg=@vger.kernel.org X-Gm-Message-State: AOJu0YxzHV5ZQooSM2IHBWgbhM7ckHu6XhswbPtpdtEonHJWaF2A1wxn Ks+ljBFejM5tzReP8JFKoY10vOTQdf2Bu6mEY14R2SanaYbXkY1U0x0xCT4SWuBlxlqXSggzaeS KrVZO+RgmIeB34tcngNpxITY3sV0MiphCjzthqhzC+0lD1vCXJ/wchmoBBU5L6r81BYU= X-Gm-Gg: AfdE7cmVRUtviwehSx7VRjEUr2bDn3qgBl06jQfrjF5zRc+ysqO2mYbMDwQbv5ZRlsw 8dyXQ0NPYrmEEtApaMRs7XziyTLJhkeU7R0SUuhtSlKE032M0gVCfiZvRQOh61a3b0joswZVVvM tpkakBWYzEF7smR7FegVtWZ5Xso8hADa/2MskTFd3ca95XgfUg55oZB5GWkiK15icn9ZqcT+/ia kpx4yxaAX7UANbjR+NLbh0nXuF6tJjD9ZZEbyp0ckFOG+v7km44pBS1p74sOt+48V4iDXD/WZXo CZIwGMRGCGRHkephAZPAu+Z1M/AlRRjJlohJb6gGsJaexVbKcoS1L+dv0Bk3q/NomjSC9IbCM3k Ud8Aa+aQGgQFtIC+u28pTfsPnQJb3VitWfn4= X-Received: by 2002:a05:622a:489:b0:50e:5cc1:1de9 with SMTP id d75a77b69052e-51a4f502a89mr56982491cf.7.1782231096754; Tue, 23 Jun 2026 09:11:36 -0700 (PDT) X-Received: by 2002:a05:622a:489:b0:50e:5cc1:1de9 with SMTP id d75a77b69052e-51a4f502a89mr56982051cf.7.1782231096205; Tue, 23 Jun 2026 09:11:36 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-697e9292788sm494756a12.1.2026.06.23.09.11.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 09:11:35 -0700 (PDT) Message-ID: Date: Tue, 23 Jun 2026 18:11:32 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] remoteproc: qcom: q6v5: Release QMP handle on ICC path failure To: Mukesh Ojha , Haoxiang Li Cc: andersson@kernel.org, mathieu.poirier@linaro.org, djakov@kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260623132015.2243317-1-haoxiang_li2024@163.com> <20260623160132.5rknnudcs7g7haoi@hu-mojha-hyd.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260623160132.5rknnudcs7g7haoi@hu-mojha-hyd.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=JYSMa0KV c=1 sm=1 tr=0 ts=6a3ab039 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=Byx-y9mGAAAA:8 a=yyGnx8vvHWscMj4to3wA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: jnC4sP80ZkOf3G4JFHNKeHvHMVtjtSSB X-Proofpoint-ORIG-GUID: jnC4sP80ZkOf3G4JFHNKeHvHMVtjtSSB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDEzMiBTYWx0ZWRfX9NzMuVLJCczR EV2yca9LspV5NAGKIXU1PiXcgO5mFr3sjpUsCRoHWLokD22NNpICa1KhXDhfHIJFbtECtArBDRn x3EhIoLBD3r0uvU7HX8ZuSwvXV782ADuEPN1po9aj9ZGky4ooG7BMCk6cwW7zNYdQ4ZB/4dK63z ERUvFfDdebe+Nl2nEnZ/bR2SIuSz3nOS0Y4OJ6sVX1YqMgZ9aSA85t75l3XfT+OucC9dTrKFF3d w0UEIHmF4FuGlL3CSPp/C0SnG0mVOgYka+bFZafZhrYGlH/DVGhxOIIehZrZgAMlp7MRUbGf2HN rfi1MtB/4rM3gLM1W9Cb2dTsM1BDDsn4bqoEAg/FTppUnt6yfmpYIsDtW+qQBFV/a18JfLgnVXR wA3HZ3bvxX9UKK6bbPI2aOPMBK9z4yrgw6z3fGa34ikdkOByQ5b5zU9A+DDl2O/BJP9SZ4WJBIl IB4WarIjvNs1gftfg1A== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDEzMiBTYWx0ZWRfXxpgILgBB4cac 6iAP1rkQ9XBR+tCfkssphmFk2B1fKd/f2bXajF/h8XaqZrc1oE6aMvOofCUIu22Mf1RkGYCr+WG a+7CRIBEN03oKp74ysJdjZ5FxeUpcAI= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_03,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 adultscore=0 bulkscore=0 impostorscore=0 malwarescore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230132 On 6/23/26 6:01 PM, Mukesh Ojha wrote: > On Tue, Jun 23, 2026 at 09:20:15PM +0800, Haoxiang Li wrote: >> qcom_q6v5_init() acquires the QMP handle before getting the >> interconnect path. If devm_of_icc_get() fails, the function >> returns without releasing the QMP handle, leaking the device >> reference acquired by qmp_get(). >> >> Release the QMP handle on the interconnect error path before returning. >> >> Fixes: 8d9be5c6bdcd ("remoteproc: qcom: q6v5: Add interconnect path proxy vote") >> Signed-off-by: Haoxiang Li >> --- >> drivers/remoteproc/qcom_q6v5.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/remoteproc/qcom_q6v5.c b/drivers/remoteproc/qcom_q6v5.c >> index 58d5b85e58cd..b57041a37d28 100644 >> --- a/drivers/remoteproc/qcom_q6v5.c >> +++ b/drivers/remoteproc/qcom_q6v5.c >> @@ -347,9 +347,11 @@ int qcom_q6v5_init(struct qcom_q6v5 *q6v5, struct platform_device *pdev, >> } >> >> q6v5->path = devm_of_icc_get(&pdev->dev, NULL); >> - if (IS_ERR(q6v5->path)) >> + if (IS_ERR(q6v5->path)) { >> + qmp_put(q6v5->qmp); >> return dev_err_probe(&pdev->dev, PTR_ERR(q6v5->path), >> "failed to acquire interconnect path\n"); >> + } > > I would have preferred to move devm_of_icc_get before qmp_get() Yeah this saves on cleanup Konrad