From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D95AC433FE for ; Sat, 22 Oct 2022 07:18:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229587AbiJVHSo convert rfc822-to-8bit (ORCPT ); Sat, 22 Oct 2022 03:18:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbiJVHSm (ORCPT ); Sat, 22 Oct 2022 03:18:42 -0400 Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64DC427FE84 for ; Sat, 22 Oct 2022 00:18:41 -0700 (PDT) Received: from omf11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 35B161603C3; Sat, 22 Oct 2022 07:18:40 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf11.hostedemail.com (Postfix) with ESMTPA id CEFB420029; Sat, 22 Oct 2022 07:18:23 +0000 (UTC) Message-ID: Subject: Re: [PATCH v3 1/6] staging: vt6655: fix lines ending in a '(' From: Joe Perches To: Tanjuate Brunostar , gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Date: Sat, 22 Oct 2022 00:18:34 -0700 In-Reply-To: <20221022070612.13009-2-tanjubrunostar0@gmail.com> References: <20221022070612.13009-1-tanjubrunostar0@gmail.com> <20221022070612.13009-2-tanjubrunostar0@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Rspamd-Queue-Id: CEFB420029 X-Stat-Signature: hking6ccz1af9g4dp75gah5faz6rb571 X-Rspamd-Server: rspamout04 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/Qk4Udegm35BK3jmzSWYorLoNMBhIVhOA= X-HE-Tag: 1666423103-706658 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2022-10-22 at 07:06 +0000, Tanjuate Brunostar wrote: > fix serveral checkpatch errors related to lines ending with a '(' by > refactoring the code lines [] > diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c [] > @@ -141,13 +141,11 @@ static __le16 vnt_time_stamp_off(struct vnt_private *priv, u16 rate) > */ > static > unsigned int > -s_uGetTxRsvTime( > - struct vnt_private *pDevice, > - unsigned char byPktType, > - unsigned int cbFrameLength, > - unsigned short wRate, > - bool bNeedAck > -) > +s_uGetTxRsvTime(struct vnt_private *pDevice, If you end up doing more work here, ou might consider removing the Hungarian style notations Maybe something like: s_uGetTxRsvTime -> get_tx_rsv_time > + unsigned char byPktType, byPktType -> pkt_type etc... Perhaps patches by unique rename.