From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03568C433FE for ; Wed, 30 Nov 2022 03:40:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232904AbiK3Dku (ORCPT ); Tue, 29 Nov 2022 22:40:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232568AbiK3Dkr (ORCPT ); Tue, 29 Nov 2022 22:40:47 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8ACF663CE; Tue, 29 Nov 2022 19:40:46 -0800 (PST) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NMQ2F1p1XzRpgW; Wed, 30 Nov 2022 11:40:05 +0800 (CST) Received: from kwepemm600001.china.huawei.com (7.193.23.3) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 30 Nov 2022 11:40:45 +0800 Received: from [10.67.111.113] (10.67.111.113) by kwepemm600001.china.huawei.com (7.193.23.3) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 30 Nov 2022 11:40:44 +0800 Message-ID: Date: Wed, 30 Nov 2022 11:40:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH -next] selftests/landlock: Fix selftest ptrace_test run fail Content-Language: en-US To: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= , , , , CC: , , , , , , References: <20221128020409.1545717-1-limin100@huawei.com> <1232e4f3-e4b8-ff23-61e8-5465c8406f6e@digikod.net> <7379a5fd-5593-c6ce-40fd-c543dcf70d2b@huawei.com> From: limin In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.111.113] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600001.china.huawei.com (7.193.23.3) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org configuration https://gitee.com/openeuler/kernel/blob/openEuler-22.09/arch/x86/configs/openeuler_defconfig On 2022/11/29 19:03, Mickaël Salaün wrote: > I tested with next-20221116 and all tests are OK. Could you share your > kernel configuration with a link? What is the content of /proc/cmdline? > > On 29/11/2022 02:42, limin wrote: >> I run test on Linux ubuntu2204 6.1.0-next-20221116 >> >> I did't use yama. >> >> you can reproduce by this step: >> >> cd kernel_src >> >> cd tools/testing/selftests/landlock/ >> make >> ./ptrace_test >> >> >> >> >> On 2022/11/29 3:44, Mickaël Salaün wrote: >>> This patch changes the test semantic and then cannot work on my test >>> environment. On which kernel did you run test? Do you use Yama or >>> something similar? >>> >>> On 28/11/2022 03:04, limin wrote: >>>> Tests PTRACE_ATTACH and PTRACE_MODE_READ on the parent, >>>> trace parent return -1 when child== 0 >>>> How to reproduce warning: >>>> $ make -C tools/testing/selftests TARGETS=landlock run_tests >>>> >>>> Signed-off-by: limin >>>> --- >>>>    tools/testing/selftests/landlock/ptrace_test.c | 5 ++--- >>>>    1 file changed, 2 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/tools/testing/selftests/landlock/ptrace_test.c >>>> b/tools/testing/selftests/landlock/ptrace_test.c >>>> index c28ef98ff3ac..88c4dc63eea0 100644 >>>> --- a/tools/testing/selftests/landlock/ptrace_test.c >>>> +++ b/tools/testing/selftests/landlock/ptrace_test.c >>>> @@ -267,12 +267,11 @@ TEST_F(hierarchy, trace) >>>>            /* Tests PTRACE_ATTACH and PTRACE_MODE_READ on the >>>> parent. */ >>>>            err_proc_read = test_ptrace_read(parent); >>>>            ret = ptrace(PTRACE_ATTACH, parent, NULL, 0); >>>> +        EXPECT_EQ(-1, ret); >>>> +        EXPECT_EQ(EPERM, errno); >>>>            if (variant->domain_child) { >>>> -            EXPECT_EQ(-1, ret); >>>> -            EXPECT_EQ(EPERM, errno); >>>>                EXPECT_EQ(EACCES, err_proc_read); >>>>            } else { >>>> -            EXPECT_EQ(0, ret); >>>>                EXPECT_EQ(0, err_proc_read); >>>>            } >>>>            if (ret == 0) {