From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754133AbcHSAuI (ORCPT ); Thu, 18 Aug 2016 20:50:08 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:37144 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752824AbcHSAuF (ORCPT ); Thu, 18 Aug 2016 20:50:05 -0400 Subject: Re: [PATCH v8 0/4] improvements to the nmi_backtrace code To: Chris Metcalf , Peter Zijlstra , "Rafael J. Wysocki" , Petr Mladek , Russell King , Thomas Gleixner , Aaron Tomlin , Ingo Molnar , Andrew Morton , Mark Rutland , Lorenzo Pieralisi , Ralf Baechle , "David S. Miller" , sparclinux@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org References: <1471377024-2244-1-git-send-email-cmetcalf@mellanox.com> From: Daniel Thompson Message-ID: Date: Thu, 18 Aug 2016 16:46:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1471377024-2244-1-git-send-email-cmetcalf@mellanox.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/08/16 20:50, Chris Metcalf wrote: > This is a rebase of the series onto v4.8-rc2, plus some changes from > various reviewers. > > From the version 1 cover letter: > > This patch series modifies the trigger_xxx_backtrace() NMI-based > remote backtracing code to make it more flexible, and makes a few > small improvements along the way. > > The motivation comes from the task isolation code, where there are > scenarios where we want to be able to diagnose a case where some cpu > is about to interrupt a task-isolated cpu. It can be helpful to > see both where the interrupting cpu is, and also an approximation > of where the cpu that is being interrupted is. The nmi_backtrace > framework allows us to discover the stack of the interrupted cpu. > > I've tested that the change works as desired on tile, and build-tested > x86, arm, mips, and sparc64. For x86 I confirmed that the generic > cpuidle stuff as well as the architecture-specific routines are in the > new cpuidle section. For arm, mips, and sparc I just build-tested it > and made sure the generic cpuidle routines were in the new cpuidle > section, but I didn't attempt to figure out which the > platform-specific idle routines might be. That might be more usefully > done by someone with platform experience in follow-up patches. You can add runtime testing on arm to the list (I didn't try to exploit the new one-line-for-idle feature but there were no regressions). All patches: Tested-by: Daniel Thompson Daniel.